Kanedias (Oleg Chernovskiy)
Engineering

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Mar 26 2016, 7:50 PM (121 w, 20 h)
Availability
Available

Recent Activity

Today

Kanedias added a comment to D6096: Add Wayland RemoteAccess capabilities to KRfb.

@jgrulich thanks, I'll definitely use that. Have my hands fullatm but will definitely return to this diff and refresh once have some free time

Sun, Jul 22, 11:58 AM · Plasma on Wayland

Thu, Jun 28

Kanedias added a comment to D6096: Add Wayland RemoteAccess capabilities to KRfb.

@jgrulich thanks a lot! I'll address these on weekend

Thu, Jun 28, 6:46 PM · Plasma on Wayland

Jun 18 2018

Kanedias updated the test plan for D6096: Add Wayland RemoteAccess capabilities to KRfb.
Jun 18 2018, 5:49 PM · Plasma on Wayland

May 30 2018

Kanedias added a comment to D6096: Add Wayland RemoteAccess capabilities to KRfb.

@alexeymin This is a working version but I plan on adding more in the coming weekends. Just wanted to make sure there's someone motivated to review and merge this.
Thanks for looking at my stuff.

May 30 2018, 7:07 PM · Plasma on Wayland
Kanedias added a comment to D6096: Add Wayland RemoteAccess capabilities to KRfb.
  1. Make sure you have latest versions of KWin, XDG-KDE and Pipewire installed
  2. Services should be started by DBus-activation, if that doesn't happen by whatever reason, first start $ pipewire, then $ /usr/lib(exec)/xdg-desktop-portal, it should in turn start $ /usr/lib(exec)/xdg-desktop-portal-kde by itself
  3. Compile KRfb with this patch and install it, select "pw" in the list of KRfb plugins. If all is ok, XDP-KDE should show you the dialog with screen selection
  4. Try to connect to KRfb through KRDC or any other VNC client
May 30 2018, 7:03 PM · Plasma on Wayland
Kanedias added reviewers for D6096: Add Wayland RemoteAccess capabilities to KRfb: Plasma, KDE Applications.
May 30 2018, 6:02 PM · Plasma on Wayland
Kanedias committed R437:fc3e3951a433: Fix IPv6 connectivity (authored by Kanedias).
Fix IPv6 connectivity
May 30 2018, 6:00 PM
Kanedias closed D13209: Fix IPv6 connectivity.
May 30 2018, 5:59 PM
Kanedias added a comment to D13209: Fix IPv6 connectivity.

Ok, will land this once I'm home

May 30 2018, 8:16 AM
Kanedias added a comment to D13209: Fix IPv6 connectivity.

@alexeymin I checked with KRDC. Just remember to put the address in [ ]

May 30 2018, 8:15 AM
Kanedias added inline comments to D13209: Fix IPv6 connectivity.
May 30 2018, 6:53 AM
Kanedias updated the diff for D13209: Fix IPv6 connectivity.
  • Review comments: redo notifiers as QPointers
May 30 2018, 6:47 AM
Kanedias reopened D13209: Fix IPv6 connectivity.
May 30 2018, 6:47 AM
Kanedias committed R437:bcef3a1bcd50: Review comments: redo notifiers as QPointers (authored by Kanedias).
Review comments: redo notifiers as QPointers
May 30 2018, 6:46 AM
Kanedias committed R437:c4bc3ee3dfd6: Fix IPv6 connectivity (authored by Kanedias).
Fix IPv6 connectivity
May 30 2018, 6:46 AM
Kanedias closed D13209: Fix IPv6 connectivity.
May 30 2018, 6:45 AM

May 29 2018

Kanedias added a comment to D13209: Fix IPv6 connectivity.

@aacid well, it was added 6 years ago :D

May 29 2018, 9:48 PM
Kanedias added reviewers for D13209: Fix IPv6 connectivity: Plasma, KDE Applications.
May 29 2018, 9:11 PM
Kanedias requested review of D13209: Fix IPv6 connectivity.
May 29 2018, 9:07 PM
Kanedias committed R437:bb56a81e74b4: Fix IPv6 connectivity (authored by Kanedias).
Fix IPv6 connectivity
May 29 2018, 9:06 PM

May 27 2018

Kanedias committed R437:211b046906e2: Implement Pipewire framebuffer (authored by Kanedias).
Implement Pipewire framebuffer
May 27 2018, 7:12 PM

May 22 2018

Kanedias added a comment to D6096: Add Wayland RemoteAccess capabilities to KRfb.

@jgrulich @alexeymin please review new framebuffer approach

May 22 2018, 7:20 PM · Plasma on Wayland
Kanedias updated the diff for D6096: Add Wayland RemoteAccess capabilities to KRfb.

Rewrite everything from scratch with Pipewire connectivity in mind

May 22 2018, 7:17 PM · Plasma on Wayland

May 17 2018

Kanedias added a comment to D6096: Add Wayland RemoteAccess capabilities to KRfb.

@jgrulich , thanks for the pointers

May 17 2018, 8:04 PM · Plasma on Wayland
Kanedias added a comment to D6096: Add Wayland RemoteAccess capabilities to KRfb.

Ah, that's because I use custom built XDP-KDE executable, installed to prefix instead of /usr

May 17 2018, 8:02 PM · Plasma on Wayland
Kanedias added a comment to D6096: Add Wayland RemoteAccess capabilities to KRfb.

Nailed it, XDP just thinks KDE is inferior:

XDP: loading /usr/share/xdg-desktop-portal/portals/kde.portal
XDP: portal implementation for KDE
XDP: portal implementation supports org.freedesktop.impl.portal.Access
XDP: portal implementation supports org.freedesktop.impl.portal.AppChooser
XDP: portal implementation supports org.freedesktop.impl.portal.Email
XDP: portal implementation supports org.freedesktop.impl.portal.FileChooser
XDP: portal implementation supports org.freedesktop.impl.portal.Inhibit
XDP: portal implementation supports org.freedesktop.impl.portal.Notification
XDP: portal implementation supports org.freedesktop.impl.portal.Print
May 17 2018, 8:01 PM · Plasma on Wayland

May 16 2018

Kanedias added a comment to D6096: Add Wayland RemoteAccess capabilities to KRfb.

Hmm XDG Desktop Portal 0.11 just simply doesn't have ScreenCast interface on DBus... @jgrulich do I need some bleeding edge version or is it not yet in master branch?

May 16 2018, 10:47 PM · Plasma on Wayland
Kanedias added a comment to D6096: Add Wayland RemoteAccess capabilities to KRfb.

Thanks for the xml, I was able to pass it to qdbus2cpp. Amusingly, if I just try auto reply = dbusXdpService->CreateSession(QVariantMap()); (with empty parameter map), the main desktop portal app just segfaults! I mean, not the kde impl one but the main XDG Desktop Portal!
I'm fixing my parameters thanks to your test app, but... should that really happen?

May 16 2018, 10:01 PM · Plasma on Wayland

May 9 2018

Kanedias updated subscribers of D6096: Add Wayland RemoteAccess capabilities to KRfb.

@jgrulich I started to hack together a very simple krfb-with-dbus-with-xdp-kde-with-pipewire... thingie.
Now I'm curious, you have handle and session_handle paths everywhere in Screencast interface inside XDP-KDE source. Why? I can understand why session_handle is there - to create and track sessions of course, but what is handle used for?

May 9 2018, 5:39 PM · Plasma on Wayland

May 6 2018

Kanedias added a comment to D6096: Add Wayland RemoteAccess capabilities to KRfb.

Too late did I realize that I'm making pipewire-based framebuffer, not xdp-kde based!
I guess rewiring stuff will take another 3-4 days, sorry :D

May 6 2018, 1:02 PM · Plasma on Wayland

Apr 29 2018

Kanedias accepted D12068: Add Screenshot portal.

Looks ok to me, only minor question about how this works

Apr 29 2018, 11:04 PM

Apr 25 2018

Kanedias added a comment to T4457: [kwayland] Virtual Desktop protocol.

afaik gnome already has this, do they have some sort of protocol there?

Apr 25 2018, 6:21 AM · Plasma

Apr 22 2018

Kanedias added a comment to D6096: Add Wayland RemoteAccess capabilities to KRfb.

I've digged through old diff and I must say, many of what's described here will be peeled off. For now we support read-only views, so I'll be focusing on it.

Apr 22 2018, 5:53 PM · Plasma on Wayland

Apr 5 2018

Kanedias accepted D11943: Make screencast support optional.

Seems good to me, thanks!

Apr 5 2018, 7:16 AM

Mar 26 2018

Kanedias added a comment to D6096: Add Wayland RemoteAccess capabilities to KRfb.

Sure, I'll be updating diff this week, will address concerns raised here

Mar 26 2018, 10:25 AM · Plasma on Wayland
Kanedias added a comment to D1230: GBM remote access support for KWin.

I'll take a look once I'm home

Mar 26 2018, 7:27 AM · Plasma on Wayland, KWin
Kanedias added a comment to D1230: GBM remote access support for KWin.

@bcooksley this file was merged in D1231

Mar 26 2018, 6:59 AM · Plasma on Wayland, KWin

Mar 25 2018

Kanedias added a comment to T7785: PipeWire support in remote access to KWin.

Can the remote access protocol be extended in this way? It would make sense by its name to facilitate remote input support here as well.

Mar 25 2018, 5:34 PM · Plasma (Plasma 5.13), KWin, Plasma on Wayland
Kanedias added a comment to T7785: PipeWire support in remote access to KWin.

This finally is ready to proceed, thanks everybody. D10965 to go. I'll begin working on KRfb integration with pipewire stream this week.
We should think about input support as now remote sessions are limited to view-only.

Mar 25 2018, 5:23 PM · Plasma (Plasma 5.13), KWin, Plasma on Wayland
Kanedias added a comment to D1230: GBM remote access support for KWin.

Done! Thanks for looking this through.

Mar 25 2018, 5:21 PM · Plasma on Wayland, KWin
Kanedias added a comment to D1231: Add Remote Access interface to KWayland.
  • squashed before pushing
  • fixed all versions to 5.45
Mar 25 2018, 5:20 PM · Frameworks, Plasma on Wayland
Kanedias committed R108:4d46edd7ba4b: GBM remote access support for KWin (authored by Kanedias).
GBM remote access support for KWin
Mar 25 2018, 5:18 PM
Kanedias closed D1230: GBM remote access support for KWin.
Mar 25 2018, 5:18 PM · Plasma on Wayland, KWin
Kanedias committed R127:5116fe0c6345: Add Remote Access interface to KWayland (authored by Kanedias).
Add Remote Access interface to KWayland
Mar 25 2018, 5:18 PM
Kanedias closed D1231: Add Remote Access interface to KWayland.
Mar 25 2018, 5:18 PM · Frameworks, Plasma on Wayland

Mar 23 2018

Kanedias committed R127:89009a0c82af: Merge branch 'master' into gbm-vnc (authored by Kanedias).
Merge branch 'master' into gbm-vnc
Mar 23 2018, 8:00 AM
Kanedias committed R127:cf9cc7499d2b: Implement releasing of client-freed output (authored by Kanedias).
Implement releasing of client-freed output
Mar 23 2018, 8:00 AM
Kanedias committed R127:bbbaac741c12: Review fixes (authored by Kanedias).
Review fixes
Mar 23 2018, 8:00 AM
Kanedias committed R127:cde28079a238: Fix compilation warnings uint -> int (authored by Kanedias).
Fix compilation warnings uint -> int
Mar 23 2018, 8:00 AM
Kanedias updated the diff for D1231: Add Remote Access interface to KWayland.
  • Merge branch 'master' into gbm-vnc
Mar 23 2018, 6:43 AM · Frameworks, Plasma on Wayland
Kanedias updated the diff for D1231: Add Remote Access interface to KWayland.

Remove already merged changes

Mar 23 2018, 6:41 AM · Frameworks, Plasma on Wayland
Kanedias updated the diff for D1231: Add Remote Access interface to KWayland.
  • Implement releasing of client-freed output
  • Review fixes
Mar 23 2018, 6:40 AM · Frameworks, Plasma on Wayland

Mar 22 2018

Kanedias updated the diff for D1230: GBM remote access support for KWin.

Remove override fix

Mar 22 2018, 6:40 AM · Plasma on Wayland, KWin

Mar 21 2018

Kanedias added a comment to D1230: GBM remote access support for KWin.

This makes sense. Thanks, will try with KDecoration master once I'm home

Mar 21 2018, 11:59 AM · Plasma on Wayland, KWin
Kanedias added a comment to D1230: GBM remote access support for KWin.

I don't have KDecoration checked out. The problem is much more simple. These functions don't override anything but there's override keyword present where it shouldn't be. The fix is still required for them, regardless of KDecoration status.

Mar 21 2018, 10:15 AM · Plasma on Wayland, KWin
Kanedias added a comment to D1230: GBM remote access support for KWin.

They don't override anything and compile fails for me if they are present. GCC 7.3.1.

Mar 21 2018, 9:30 AM · Plasma on Wayland, KWin
Kanedias requested review of D1230: GBM remote access support for KWin.
Mar 21 2018, 7:02 AM · Plasma on Wayland, KWin
Kanedias updated the diff for D1230: GBM remote access support for KWin.
  • Fix clang compilation
  • Fix QPointer
Mar 21 2018, 7:01 AM · Plasma on Wayland, KWin

Mar 15 2018

Kanedias abandoned D9871: Add partial busy-widget support.
Mar 15 2018, 8:04 PM · Frameworks

Mar 13 2018

Kanedias committed R108:51a6402ad55a: Implement remote framebuffer for GBM backend (authored by Kanedias).
Implement remote framebuffer for GBM backend
Mar 13 2018, 8:42 PM
Kanedias updated the diff for D1230: GBM remote access support for KWin.

Typo

Mar 13 2018, 8:42 PM · Plasma on Wayland, KWin
Kanedias committed R108:4b531830b451: Implement remote framebuffer for GBM backend (authored by Kanedias).
Implement remote framebuffer for GBM backend
Mar 13 2018, 8:41 PM
Kanedias added inline comments to D1230: GBM remote access support for KWin.
Mar 13 2018, 8:40 PM · Plasma on Wayland, KWin
Kanedias updated the diff for D1230: GBM remote access support for KWin.

Review fixes

Mar 13 2018, 8:40 PM · Plasma on Wayland, KWin
Kanedias added a comment to D1231: Add Remote Access interface to KWayland.

As I don't see anything related to security in this patch, I have two questions.

Could anyone with access to server:port manage the server wayland sessions or just create a new session?
The access control should be done in the firewall?

Mar 13 2018, 7:35 AM · Frameworks, Plasma on Wayland

Mar 9 2018

Kanedias added a comment to D1231: Add Remote Access interface to KWayland.

It will soon be this patch 2nd birthday. Can we speed up things a bit? I've seen this is scheduled for Plasma 5.13, would be good if we have time to test it.

Mar 9 2018, 1:43 PM · Frameworks, Plasma on Wayland
Kanedias added a comment to D1230: GBM remote access support for KWin.

Please re-review this and D1231 as I'm starting to work on KRfb support for this and it will be the 3rd patch depending on this.
Or suggest reviewers with more spare time so they can look this through.

Mar 9 2018, 1:41 PM · Plasma on Wayland, KWin

Mar 7 2018

Kanedias committed R108:054792f79898: Implement remote framebuffer for GBM backend (authored by Kanedias).
Implement remote framebuffer for GBM backend
Mar 7 2018, 7:01 PM
Kanedias added a comment to D1230: GBM remote access support for KWin.

@romangg , I had to recreate it after rebase, cause I don't have force-push.

Mar 7 2018, 6:58 PM · Plasma on Wayland, KWin
Kanedias updated the diff for D1230: GBM remote access support for KWin.

Review comments

Mar 7 2018, 6:53 PM · Plasma on Wayland, KWin
Kanedias accepted D10965: Add screen cast portal.
Mar 7 2018, 2:23 PM
Kanedias added a comment to D1231: Add Remote Access interface to KWayland.

@graesslin , @davidedmundson , please approve this once again, this was updated numerous times after initial review

Mar 7 2018, 2:14 PM · Frameworks, Plasma on Wayland
Kanedias added a comment to D1230: GBM remote access support for KWin.

@graesslin , @davidedmundson , please approve this once again, this was updated numerous times after initial review

Mar 7 2018, 2:14 PM · Plasma on Wayland, KWin

Mar 4 2018

Kanedias added a comment to D10965: Add screen cast portal.

I'd wrap some pipewire structures into some kind of PipewirePointer like WaylandPointer in KWayland does. But maybe I'm too picky, overall this stuff looks really good!

Mar 4 2018, 10:52 AM
Kanedias added inline comments to D10965: Add screen cast portal.
Mar 4 2018, 10:50 AM

Mar 3 2018

Kanedias added a comment to T7785: PipeWire support in remote access to KWin.

@romangg , @davidedmundson , @graesslin , should we merge D1230 & D1231? D10965 for xdg-desktop-portal depends on this code.

Mar 3 2018, 6:29 PM · Plasma (Plasma 5.13), KWin, Plasma on Wayland
Kanedias added a task to D10965: Add screen cast portal: T7785: PipeWire support in remote access to KWin.
Mar 3 2018, 5:46 PM
Kanedias added a revision to T7785: PipeWire support in remote access to KWin: D10965: Add screen cast portal.
Mar 3 2018, 5:46 PM · Plasma (Plasma 5.13), KWin, Plasma on Wayland

Mar 2 2018

Kanedias added a comment to D10965: Add screen cast portal.

Hi Jan, I'll take a look in the evening once I'm home.
Thanks!

Mar 2 2018, 10:48 AM

Mar 1 2018

Kanedias committed R127:08e7b23c54bd: Implement releasing of client-freed output (authored by Kanedias).
Implement releasing of client-freed output
Mar 1 2018, 7:13 PM
Kanedias closed D10929: Implement releasing of client-freed output.
Mar 1 2018, 7:13 PM · Frameworks

Feb 28 2018

Kanedias added revisions to T7785: PipeWire support in remote access to KWin: D10929: Implement releasing of client-freed output, D1230: GBM remote access support for KWin, D1231: Add Remote Access interface to KWayland.
Feb 28 2018, 8:59 PM · Plasma (Plasma 5.13), KWin, Plasma on Wayland
Kanedias added a task to D1231: Add Remote Access interface to KWayland: T7785: PipeWire support in remote access to KWin.
Feb 28 2018, 8:59 PM · Frameworks, Plasma on Wayland
Kanedias added a task to D1230: GBM remote access support for KWin: T7785: PipeWire support in remote access to KWin.
Feb 28 2018, 8:59 PM · Plasma on Wayland, KWin
Kanedias added a task to D10929: Implement releasing of client-freed output: T7785: PipeWire support in remote access to KWin.
Feb 28 2018, 8:59 PM · Frameworks
Kanedias added a comment to T7785: PipeWire support in remote access to KWin.

@jgrulich For situation where deleting KWayland::Client::Output doesn't help - please see D10929

Feb 28 2018, 8:58 PM · Plasma (Plasma 5.13), KWin, Plasma on Wayland
Kanedias requested review of D10929: Implement releasing of client-freed output.
Feb 28 2018, 8:57 PM · Frameworks

Feb 27 2018

Kanedias updated subscribers of T7785: PipeWire support in remote access to KWin.
Feb 27 2018, 9:59 PM · Plasma (Plasma 5.13), KWin, Plasma on Wayland
Kanedias added a comment to T7785: PipeWire support in remote access to KWin.

I think I know what's the problem with delete output. In KWayland in output.cpp: WaylandPointer<wl_output, wl_output_destroy> output. While this is technically correct it shouldn't destroy output right away.
It should call wl_output_release that will notify destruction to the server so it will know this client has no more bound outputs and RemoteAccess interface and stop sending buffers.

Feb 27 2018, 9:58 PM · Plasma (Plasma 5.13), KWin, Plasma on Wayland
Kanedias added a comment to T7785: PipeWire support in remote access to KWin.

Yep, I managed to get remote stream too, though it doesn't look so good as yours yet, Jan :)
I'll be pushing changes with removing GSource and rewriting it with QSocketNotifier to kwin-remote-receiver, you can take a look if interested.

Feb 27 2018, 8:44 PM · Plasma (Plasma 5.13), KWin, Plasma on Wayland
Kanedias added a comment to T7785: PipeWire support in remote access to KWin.

AFAIK Mesa 17.3.x had a regression that caused lockups on intel iGPUs. Many of them were finally nailed down only in 17.3.6, see here
Can you try new version on your Fedora 27 laptop?

Feb 27 2018, 7:23 PM · Plasma (Plasma 5.13), KWin, Plasma on Wayland

Feb 26 2018

Kanedias added a comment to T7785: PipeWire support in remote access to KWin.

pw_remote_destroy - calls free(remote->error) even if it's not initialized, is this a bug?..

Feb 26 2018, 10:01 PM · Plasma (Plasma 5.13), KWin, Plasma on Wayland

Feb 24 2018

Kanedias added a comment to T7785: PipeWire support in remote access to KWin.

Can't make it crash, unfortunately.
@jgrulich , seems I need some cooperation to make it reliably fail, let's compare our specs.

Feb 24 2018, 6:03 PM · Plasma (Plasma 5.13), KWin, Plasma on Wayland

Feb 22 2018

Kanedias added a comment to T7785: PipeWire support in remote access to KWin.

@jgrulich hooray!

Feb 22 2018, 3:08 PM · Plasma (Plasma 5.13), KWin, Plasma on Wayland

Feb 19 2018

Kanedias added a comment to T7785: PipeWire support in remote access to KWin.

Ok, guess I'm missing something then, I'll take a closer look, thanks!

Feb 19 2018, 6:11 AM · Plasma (Plasma 5.13), KWin, Plasma on Wayland
Kanedias added a comment to T7785: PipeWire support in remote access to KWin.

@jgrulich , were you able to connect the stream to pipewire with the code from xdg-desktop-portal-kde?
It says only "Stream stage changed: connecting" and then "protocol-native: got connection error" to me.

Feb 19 2018, 6:07 AM · Plasma (Plasma 5.13), KWin, Plasma on Wayland
Kanedias added a comment to T7785: PipeWire support in remote access to KWin.

@jgrulich , I think I found a way to make KWin send only needed buffers to support >1 monitor setup.

Feb 19 2018, 5:19 AM · Plasma (Plasma 5.13), KWin, Plasma on Wayland

Feb 6 2018

Kanedias added a comment to T7785: PipeWire support in remote access to KWin.

Guys, in case everyone misses me I'm on vacation right now, will be back by weekend.

Feb 6 2018, 8:29 PM · Plasma (Plasma 5.13), KWin, Plasma on Wayland

Jan 31 2018

Kanedias added a comment to T7785: PipeWire support in remote access to KWin.

clients query kwin, kwin spawns KWRR on demand, gets an FD and returns that to the client

I'd go with this option but not sure how well does it fit the flow. Clients need to query KWin somehow but all they should see is DBus or Pipewire daemon
Right now I start KWRR manually, didn't integrate it with KWin codebase yet.

Jan 31 2018, 10:02 PM · Plasma (Plasma 5.13), KWin, Plasma on Wayland
Kanedias added a comment to T7785: PipeWire support in remote access to KWin.

The procedure as I see it:

Jan 31 2018, 9:03 PM · Plasma (Plasma 5.13), KWin, Plasma on Wayland