Well, okay. I'm not happy that the whole code just got bulkier because of PW 0.3, but that's the only concern.
If you have time on your hands, please split this into two distinct implementations (PWFrameBufferV02 and PWFrameBufferV03) so you won't need to wrack your brains around #ifs in the future

I don't. At this point any proof that I can provide just looks like nitpicking. I remember seeing it clearly in my old QML apps for Android but it was over a year ago. I tried screencasting it but on my desktop it's almost non-palpatable. I mean, my eyes can surely see it when I click calendar for the first time or when I scroll system notifications and track plasmashell memory usage in htop in other window, but it's hard to notice even in screencast. Apparently, the amount of optimizations that went into QML is enormous.

Not all performance problems are from QML. Besides, that'd undermine all the effort KDE team has put into polishing the system.
Alternative is not a replacement. I merely think for arm/phones we need something else, rather than waiting for CPUs to evolve.

@ngraham see here

The only issue left is clipboard sharing. I'm certain it's triggered in some weird way and sends stray packets when VNC Server expects password. I've definitely seen network activity when the password field is selected/filled on Wayland.
Something I didn't see on X. Other than that, I'm mostly satisfied with the result.

@jgrulich I also have to say that I'm not against DBus implementation in general, merely worried a bit. I see you also have keyboard protocol, that's a breakthrough! Never managed to grasp keysyms conversion myself.

@romangg, as you are now maintaining KWin, take a look at this as well.

PW framebuffer looks okay, it's the event system that worries me.

Do we need any libs linked for XKB to work?

I hope you don't mind that.

@jgrulich In my regularly-irregular wanderings I noticed you already picked up changes from this diff and that's totally okay. Should I close this?

@jgrulich you didn't change FindSPA, is it ok?

@jgrulich thanks, I'll definitely use that. Have my hands fullatm but will definitely return to this diff and refresh once have some free time

@jgrulich thanks a lot! I'll address these on weekend

@alexeymin This is a working version but I plan on adding more in the coming weekends. Just wanted to make sure there's someone motivated to review and merge this.
Thanks for looking at my stuff.

1. Make sure you have latest versions of KWin, XDG-KDE and Pipewire installed
2. Services should be started by DBus-activation, if that doesn't happen by whatever reason, first start $ pipewire, then $ /usr/lib(exec)/xdg-desktop-portal, it should in turn start $ /usr/lib(exec)/xdg-desktop-portal-kde by itself
3. Compile KRfb with this patch and install it, select "pw" in the list of KRfb plugins. If all is ok, XDP-KDE should show you the dialog with screen selection
4. Try to connect to KRfb through KRDC or any other VNC client

Ok, will land this once I'm home

@alexeymin I checked with KRDC. Just remember to put the address in [ ]

• Review comments: redo notifiers as QPointers

@aacid well, it was added 6 years ago :D

@jgrulich @alexeymin please review new framebuffer approach

Rewrite everything from scratch with Pipewire connectivity in mind

@jgrulich , thanks for the pointers

Ah, that's because I use custom built XDP-KDE executable, installed to prefix instead of /usr

Nailed it, XDP just thinks KDE is inferior:

XDP: loading /usr/share/xdg-desktop-portal/portals/kde.portal
XDP: portal implementation for KDE
XDP: portal implementation supports org.freedesktop.impl.portal.Access
XDP: portal implementation supports org.freedesktop.impl.portal.AppChooser
XDP: portal implementation supports org.freedesktop.impl.portal.Email
XDP: portal implementation supports org.freedesktop.impl.portal.FileChooser
XDP: portal implementation supports org.freedesktop.impl.portal.Inhibit
XDP: portal implementation supports org.freedesktop.impl.portal.Notification
XDP: portal implementation supports org.freedesktop.impl.portal.Print

Hmm XDG Desktop Portal 0.11 just simply doesn't have ScreenCast interface on DBus... @jgrulich do I need some bleeding edge version or is it not yet in master branch?

Thanks for the xml, I was able to pass it to qdbus2cpp. Amusingly, if I just try auto reply = dbusXdpService->CreateSession(QVariantMap()); (with empty parameter map), the main desktop portal app just segfaults! I mean, not the kde impl one but the main XDG Desktop Portal!
I'm fixing my parameters thanks to your test app, but... should that really happen?

@jgrulich I started to hack together a very simple krfb-with-dbus-with-xdp-kde-with-pipewire... thingie.
Now I'm curious, you have handle and session_handle paths everywhere in Screencast interface inside XDP-KDE source. Why? I can understand why session_handle is there - to create and track sessions of course, but what is handle used for?

Too late did I realize that I'm making pipewire-based framebuffer, not xdp-kde based!
I guess rewiring stuff will take another 3-4 days, sorry :D

Looks ok to me, only minor question about how this works

afaik gnome already has this, do they have some sort of protocol there?

I've digged through old diff and I must say, many of what's described here will be peeled off. For now we support read-only views, so I'll be focusing on it.

Seems good to me, thanks!

Sure, I'll be updating diff this week, will address concerns raised here

I'll take a look once I'm home

@bcooksley this file was merged in D1231

In T7785#134387, @romangg wrote:

Can the remote access protocol be extended in this way? It would make sense by its name to facilitate remote input support here as well.

This finally is ready to proceed, thanks everybody. D10965 to go. I'll begin working on KRfb integration with pipewire stream this week.
We should think about input support as now remote sessions are limited to view-only.

Done! Thanks for looking this through.

• squashed before pushing
• fixed all versions to 5.45

• Merge branch 'master' into gbm-vnc

Remove already merged changes

• Implement releasing of client-freed output
• Review fixes

Remove override fix

This makes sense. Thanks, will try with KDecoration master once I'm home

I don't have KDecoration checked out. The problem is much more simple. These functions don't override anything but there's override keyword present where it shouldn't be. The fix is still required for them, regardless of KDecoration status.

They don't override anything and compile fails for me if they are present. GCC 7.3.1.

• Fix clang compilation
• Fix QPointer

Typo

Review fixes

In D1231#224441, @jtamate wrote:

As I don't see anything related to security in this patch, I have two questions.

Could anyone with access to server:port manage the server wayland sessions or just create a new session?
The access control should be done in the firewall?

It will soon be this patch 2nd birthday. Can we speed up things a bit? I've seen this is scheduled for Plasma 5.13, would be good if we have time to test it.

Please re-review this and D1231 as I'm starting to work on KRfb support for this and it will be the 3rd patch depending on this.
Or suggest reviewers with more spare time so they can look this through.

@romangg , I had to recreate it after rebase, cause I don't have force-push.

Review comments

@graesslin , @davidedmundson , please approve this once again, this was updated numerous times after initial review

@graesslin , @davidedmundson , please approve this once again, this was updated numerous times after initial review

I'd wrap some pipewire structures into some kind of PipewirePointer like WaylandPointer in KWayland does. But maybe I'm too picky, overall this stuff looks really good!

@romangg , @davidedmundson , @graesslin , should we merge D1230 & D1231? D10965 for xdg-desktop-portal depends on this code.

Hi Jan, I'll take a look in the evening once I'm home.
Thanks!