Differential D27453

[Applet]Update toolbar's checkbox spacing
ClosedPublic
Actions

Authored by gvgeo on Feb 17 2020, 10:30 AM.

Details

Reviewers
jgrulich
ngraham
Group Reviewers
Plasma
VDG
Maniphest Tasks
T10470: Improve the visuals of tray popups
Commits
R116:88b8ce5e50b7: [Applet]Update toolbar's checkbox spacing
Summary

Move the switchButton's icon smallSpacing left.
Make icon size smallMedium.

BUG: 417710

Test Plan

Before:


After:

Diff Detail

Repository
R116 Plasma Network Management Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gvgeo created this revision.Feb 17 2020, 10:30 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 17 2020, 10:30 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gvgeo requested review of this revision.Feb 17 2020, 10:30 AM
broulik added a subscriber: broulik.Feb 17 2020, 10:31 AM
broulik added inline comments.
applet/contents/ui/SwitchButton.qml
54–56

Can this bug be fixed? Or is that because we use a CheckBox without a label and so it is icon width + spacing + no label?

gvgeo added inline comments.Feb 17 2020, 10:37 AM
applet/contents/ui/SwitchButton.qml
54–56

I made some tests. I even comment out in checkbox style, label and background but always added spacing.
Only workaround that found to work, was to set spacing: control.text ? smallSpacing : 0, but didn't felt right way to do it.

gvgeo edited the test plan for this revision. (Show Details)Feb 17 2020, 10:41 AM
jgrulich accepted this revision.Feb 17 2020, 10:43 AM
This revision is now accepted and ready to land.Feb 17 2020, 10:43 AM
Closed by commit R116:88b8ce5e50b7: [Applet]Update toolbar's checkbox spacing (authored by gvgeo, committed by ngraham). · Explain WhyFeb 18 2020, 4:42 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mapplet/contents/ui/SwitchButton.qml (16 lines)

Diff 75878

View Options

applet/contents/ui/SwitchButton.qml

Loading...