[mobile/wifi] Use ScrollViewKCM
ClosedPublic

Authored by nicolasfella on Feb 22 2020, 1:17 AM.

Details

Summary

This gives the KCM a proper frame/scrollbar

Needs D27562 to not always show the error message bubble

Test Plan

Before:


After:

Diff Detail

Repository
R116 Plasma Network Management Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Feb 22 2020, 1:17 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 22 2020, 1:17 AM
Restricted Application added a reviewer: jgrulich. · View Herald Transcript
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nicolasfella requested review of this revision.Feb 22 2020, 1:17 AM
nicolasfella edited the test plan for this revision. (Show Details)Feb 22 2020, 1:18 AM
ngraham accepted this revision.Feb 22 2020, 4:46 AM
ngraham added a subscriber: ngraham.

What's the chance we could unify the mobile and desktop versions at some point. Seems a bit anti-Kirigami-ish to maintain a separate mobile view rather than using the power of convergence.

What's the chance we could unify the mobile and desktop versions at some point. Seems a bit anti-Kirigami-ish to maintain a separate mobile view rather than using the power of convergence.

I'm unsure. The mobile wifi KCM and the desktop connections KCM are quite a bit different. The former acts more like the plasmoid since it shows available connections. The latter shows known connections and has very extensive settings for things (that would be a challenge to get into a mobile UI completely).

I'm open for proposals though

What's the chance we could unify the mobile and desktop versions at some point. Seems a bit anti-Kirigami-ish to maintain a separate mobile view rather than using the power of convergence.

The desktop KCM is not fully written in QML. I have a branch, where I started working on it a long time ago, but it still requires significant amount of work.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 8 2020, 4:21 PM
This revision was automatically updated to reflect the committed changes.