[Applet]Fix details layout.
Needs ReviewPublic

Authored by gvgeo on Fri, Feb 14, 7:14 AM.

Details

Reviewers
jgrulich
ngraham
Group Reviewers
Plasma
VDG
Summary

Fix binding loop with detailValueLabel's width.
Remove workaround for contentRect height.
Use Column as root item.
Remove unused topMargin.

Test Plan

Details of connections must remain the same.

Diff Detail

Repository
R116 Plasma Network Management Applet
Branch
details (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22531
Build 22549: arc lint + arc unit
gvgeo created this revision.Fri, Feb 14, 7:14 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFri, Feb 14, 7:14 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gvgeo requested review of this revision.Fri, Feb 14, 7:14 AM
gvgeo added a comment.Fri, Feb 14, 7:15 AM

This patch keeps left margins and opacity.

Can we not make the Column the root item of the component? Then it should propagate the size automatically.

gvgeo updated this revision to Diff 75673.Fri, Feb 14, 10:59 AM

Used Column as root item.

gvgeo updated this revision to Diff 75674.Fri, Feb 14, 11:01 AM

Removed empty line.

gvgeo edited the summary of this revision. (Show Details)Fri, Feb 14, 11:04 AM
gvgeo edited the test plan for this revision. (Show Details)
gvgeo edited the summary of this revision. (Show Details)

Might be nice to port to ColumnLayout while we're at it

gvgeo added a comment.Fri, Feb 14, 5:30 PM

Might be nice to port to ColumnLayout while we're at it

It is not really possible, what makes sense is changing to GridLayout. But because is a similar situation with battery's info bug, I don't want to do it together with these patches.
D26806#inline-151955 (Line 96 in code now)

ngraham accepted this revision.Fri, Feb 14, 6:42 PM
gvgeo updated this revision to Diff 75769.Sun, Feb 16, 2:51 PM

Remove unnecessary anchors.