Drop qmake pri file generation & installation, currently broken
Needs ReviewPublic

Authored by kossebau on Tue, Feb 11, 5:18 PM.

Details

Reviewers
jgrulich
Summary

The library NetworkManager is in the public interface of NetworkManagerQt,
thus needs to be listed as a dependency, so that its include dirs
and library to link are found.
This would need another pri file for the library NetworkManager though,
which there seems none to exist yet.

Diff Detail

Repository
R282 NetworkManagerQt
Branch
dropbrokenprifile
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22372
Build 22390: arc lint + arc unit
kossebau created this revision.Tue, Feb 11, 5:18 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptTue, Feb 11, 5:18 PM
Restricted Application added 1 blocking reviewer(s): jgrulich. · View Herald Transcript
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
kossebau requested review of this revision.Tue, Feb 11, 5:18 PM

Looking at some other frameworks, they basically have same code to generate pri files, are they all broken?

For example: https://cgit.kde.org/bluez-qt.git/tree/src/CMakeLists.txt#n195

Looking at some other frameworks, they basically have same code to generate pri files, are they all broken?

For example: https://cgit.kde.org/bluez-qt.git/tree/src/CMakeLists.txt#n195

They are only broken if they miss a library they have in their public interface, for all of which there should be a qmake module mentioned in the DEPS argument (unless transitively covered, like core being already brought in by gui).

Bluez-qt looks fine by a quick look at what is PUBLIC argument in the target_link_libraries(KF5BluezQt) call, Seems it does all cals via D-Bus and not have any libbluez in its publc interface.

Yet there surely are more case of broken ecm_generate_pri_file calls. Seems many people just copy-paste-replaced the call, not checking the result :) While looking at this patch here, I e.g. came by prison having an even more broken call, in thei case though can be fixed, as again only other libraries are in the public interface for which there also is a qmake module pri file.