Guess that segfault wants to resolve itself :D

Only do that on Wayland

Focus the stackSwitcher when opening the sheet

Properly determine if tools area should be drawn on QDialogs with auto set

Address code concerns; add escape keyboard gesture

Address feedback

This is being moved to GitLab.

Moving to a GitLab MR

In D28873#672598, @mart wrote:

what should happen in this case?

In D29797#672263, @kossebau wrote:

Thanks for the (first) review :)

Open questions I have are these:
a) how to properly check for the presence of the yaml.safe_load() method? and whether to support a fallback to load() otherwise? It was only introduced at a certain version of pyyaml
b) by supposedly breaking support for Python 2, how to properly catch any usage of python2 now?

Improve the small toolbar

Rebase on master

Unsplit template and control for documentation purposes

Split into a template; make borders customisable

In D28873#671043, @ngraham wrote:

In that window, there's plenty of space for the component to expand horizontally. I would prefer to avoid scrolling tabs; their interaction is usually not great.

Avoid trying to display initials of non-Latin characters

In D29667#669622, @ochurlaud wrote:

Don't use file as a variable name as it's a python keyword.

See D29685.

Dump output information as well

While this is neat, I'm fairly sure that creating the CSS for this in a manner that works across themes is going to be hard if not impossible. Even our own Breeze GTK uses palette swaps rather than unique pixmaps for every state.

In D29486#665820, @zzag wrote:

In D29486#665652, @cblack wrote:

So this is a Qt bug where it's not requesting keyboard focus or a KWin bug where it's not granting keyboard focus?

It's our bug because popup grabs are implemented partially in kwayland-server.

In D29486#665433, @davidedmundson wrote:

I don't follow what you're referring to.

We have XdgShellInterface::popupGrabRequested mapped correctly. Tooltips and menus are correctly differentiated.
We don't check the seat and serial properly, but if anything that means we're more likely to acknowledge a grab.

In order to ensure that the topmost grabbing popup has keyboard focus, we need a mechanism for grabbing input devices in kwayland-server.

In D29514#665869, @ngraham wrote:

Hmm, on my system, the file is located at /usr/src/xserver/include/xserver-properties.h, and this doesn't seen to find it:

-- The following features have been disabled:

 * XorgServer, XServer header needed for touchpad KCM (X11 backend)

-- The following OPTIONAL packages have not been found:

 * XorgServer, XServer header needed for touchpad KCM (X11 backend)

Test plan works as advertised and code seems fine.

You should include a video in the test plan since you're creating visual changes with motion.

Parent temporary file to the application

realize you forgot to change the name of the argument in the body as well

Refine method signature and add a comment for less ambiguity

Parent the dynamically created user to the model

Address some of the code feedback from d_ed

In D29486#665619, @davidedmundson wrote:

< snip >

we call a grab, but the knowledge of that is internal to the ShellIntegration based on the window type.
I can't see anything in QWaylandInputDevice::Keyboard that respects that last part.

Address code and icon feedback

In D29081#665203, @ndavis wrote:

Big +1 to the idea, but this shouldn't use darker() because that won't look right in Breeze Dark.

Fix faceValid checking

Clear search text on application change

Add better non-Wayland guards

In D29466#665145, @gikari wrote:

Is it possible to integrate the search into the help menu, if it exists already or create an entry for it. Much like macOS does.

begone, kule

Make sure arc diff does what it should

In D29486#665078, @davidedmundson wrote:

Can you expand on why it's broken currently?

Address code issue and add reset functionality