Differential D29436

Use font: instead of font.pointSize: where possible
ClosedPublic
Actions

Authored by ngraham on May 4 2020, 11:19 PM.

Details

Reviewers
cblack
Group Reviewers
Plasma
Commits
R242:5ef8b1a18937: Use font: instead of font.pointSize: where possible
Summary

Otherwise we're discarding style information possibly set in
the user's small font choices when we want to set a smaller
font.

Test Plan

Stuff that's suposta look small still looks small

Diff Detail

Repository
R242 Plasma Framework (Library)
Branch
use-whole-font (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26359
Build 26377: arc lint + arc unit
ngraham created this revision.May 4 2020, 11:19 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 4 2020, 11:19 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.May 4 2020, 11:19 PM
ngraham updated this revision to Diff 81959.May 4 2020, 11:26 PM

Revert a thing that shoudnta been thunged

ngraham retitled this revision from Use theme.smallestFont instead of various ad-hoc alternatives to Use font: instead of font.pointSize: where possible.May 4 2020, 11:32 PM
ngraham edited the summary of this revision. (Show Details)
ngraham edited the test plan for this revision. (Show Details)
cblack accepted this revision.May 19 2020, 4:13 PM
This revision is now accepted and ready to land.May 19 2020, 4:13 PM
ngraham closed this revision.May 19 2020, 4:18 PM

Revision Contents
Changeset List

Diff 81959

View Options

examples/applets/testcomponents/contents/ui/ThemePage.qml

Loading...
View Options

examples/applets/testtheme/contents/ui/FontTest.qml

Loading...