Translate a few German comments to English
ClosedPublic

Authored by ognarb on Sun, May 10, 9:49 PM.

Details

Diff Detail

Repository
R767 OCS Webserver
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ognarb requested review of this revision.Sun, May 10, 9:49 PM
ognarb created this revision.
ognarb retitled this revision from Translate a few germand comments to english to Translate a few German comments to English.Sun, May 10, 9:49 PM
ognarb added a reviewer: KDE Store.
cblack accepted this revision.Sun, May 10, 9:53 PM
cblack added a subscriber: cblack.
cblack added inline comments.
application/modules/backend/controllers/HiveController.php
247

Successfully

252

Typo

application/modules/backend/views/scripts/legend.phtml
25

No 's

44

Gallery overview

61

Disable

This revision is now accepted and ready to land.Sun, May 10, 9:53 PM
ognarb updated this revision to Diff 82470.Sun, May 10, 9:55 PM
ognarb marked 5 inline comments as done.

Reflect comments

tfella added a subscriber: tfella.Sun, May 10, 10:05 PM
tfella added inline comments.
application/modules/backend/controllers/HiveController.php
145

Typo

164

ffrom

177

ffrom

204

ffrom

application/modules/default/models/Collection.php
1867

I'm not sure if "can not be deleted" means that the product should not be deleted or that the code should not be deleted

ognarb updated this revision to Diff 82472.Sun, May 10, 10:09 PM
ognarb marked 4 inline comments as done.
  • fix typos
ognarb marked an inline comment as done.Sun, May 10, 10:12 PM
ognarb added inline comments.
application/modules/default/models/Collection.php
1867

The code return false if the condition is true: $result['count_comments'] >5 || $result['is_old'] ==1 || $result['plings']>0

The return code could also be simplified to just and it would be less confusing.

return $result['count_comments'] <=5 && $result['is_old'] !==1 && $result['plings'] <= 0;
ognarb marked an inline comment as done.Sun, May 24, 3:57 PM

Ping

alexanderschmidt accepted this revision.Mon, May 25, 8:44 AM
alexanderschmidt added a subscriber: alexanderschmidt.

Thank you. :-)

This revision was automatically updated to reflect the committed changes.