Just got an owner email with the project name! Thanks ronald.
- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Nov 28 2018
Nov 22 2018
Nov 16 2018
Nov 8 2018
Nov 6 2018
Oh awesome. This code seems much easier to read than D15720.
Nov 5 2018
We're currently trying to draw the C++ Breeze/forks window decorations in T9899 (and https://bugs.kde.org/show_bug.cgi?id=399757), which would make these SVGs obsolete. However we can merge these in the short term until that code is ready.
Oct 30 2018
Oct 29 2018
So adding this shooooould work... but doesn't.
In D16516#350641, @ngraham wrote:YES
Oct 24 2018
For now, I'm going to merge this so I can keep the widget in sync with the global menu widget. We can revisit linking to a shared library later on.
Oct 23 2018
Oct 20 2018
KNotifications provides an example of linking to dbusmenu-qt5:
https://github.com/KDE/knotifications/blob/master/src/CMakeLists.txt#L46-L49
Yeah, I'm not 100% sure why the Active Window Control widget needs it. I assume it should be dynamically linking to the /usr/lib/x86_64-linux-gnu/libdbusmenu-qt.so.2, but I wanted to update all the common code first before making major refactoring.
Oct 19 2018
- Application Launcher (Kickoff) is the KDE default menu with the tabbed interface.
- Application Menu (Kicker) is the Windows 95 styled menu.
- Application Dashboard (KickerDash) reuses the Kicker source code, but uses DashboardRepresentation.qml as the entry point instead of main.qml. KickerDash's metadata.desktop file is in the kdeplasma-addons repo. Effectively, everything is in the plasma-desktop repo though as that one .desktop file is the only thing outside it.
Oct 10 2018
Sorry, just merged both to master. Thanks davidedmundson for the patches that updated the ComboBox.
Oct 8 2018
I need to try patching plasma-framework's dialog.cpp and see if that introduces issues. Right now it's mainItem->setParentItem(contentItem());, and I need to test if mainItem->setParent(contentItem()); breaks anything. I haven't patched C++ in frameworks before so I'll need to figure that out.
Oct 5 2018
- Got rid of the signal+slot that emits KNewStuff changes since wallpaperComboBox is automagically updated.
- Reordered the command arguments so the variable is last in wallpaperplugin.knsrc.
- Put the plasmoids.knsrc and wallpaperplugin.knsrc filepaths on separate lines in the CMakeList.txt
Finally got around to updating this patch and formally testing with kdesrc-build (sort of) in Neon Unstable which has Frameworks 5.51.
Sep 30 2018
Sep 24 2018
I confirmed that contentItem()->childItems() did indeed send it to mainItem. It also sends it to the FrameSvgItem too. It no longer sends it to the mysterious ColorScope.
Sep 9 2018
I noticed this in https://phabricator.kde.org/D12249#247452, but didn't realize that it was missing the code for loading the effects in the KCM like D15372 adds. Nice work on D15372!
Sep 6 2018
Nice thinking on using repeater.count instead of the hardcoded 7!
Aug 31 2018
The KPackage patch will end up in... Frameworks 5.51?
And the Plasma 5.14.0 release is set to depend on Frameworks... 5.45 (according to plasma-workspace's CMakeList.txt).
So we'll need to wait for the 5.14 tag to appear (Oct 4th), but to be safe, wait for the 5.14 release on Oct 9th.
Frameworks 5.51 is released Oct 13th, so it'll be easier to test after that (though I'll try to build kpackage with the patch and test it in a sec).
Alright, I'll set a reminder on Oct 17 (just after 5.14.1) to merge my 2 patches.
Aug 30 2018
Jul 19 2018
I tested the x: -main.x % 1 code.
Jul 14 2018
Should the context menu also use this icon?
Jun 19 2018
Thanks @apol for merging it. Thanks @ngraham for testing it and the link and @davidedmundson for explaining how bugfixes are merged.
Jun 13 2018
Jun 6 2018
Would the TextField.readOnly property be useful here?
May 28 2018
No prob.
May 27 2018
May 25 2018
That would complicate shadow rendering code too much.
Would it be possible to draw rounded corners with the compositor as a Desktop Effect? All we need to do is translate a the shadow pixels ontop of the the client rect. Maybe making a few pixels semi transparent.
May 14 2018
Remove unrelated brace formatting.
May 13 2018
May 11 2018
I guess apol's +1 = patch accepted? I'll merge it then.
May 10 2018
Use connect(m_newStuffDialog.data(), ...) to support gcc 4.8.
Add license headers.
May 2 2018
In D12040#257170, @mart wrote:so, if the qpointer is used in a connect, it needs to have .data() to work on gcc 4.8.
if accessed normally, it doesn't need it
Apr 25 2018
I use gcc --version 5.4.0, so I've no idea. I assume that is a QPointer feature though? We can always check the other DownloadDialog initializations:
Apr 24 2018
Remove .data() since it seems to work without it.
Apr 16 2018
Yeah, I can't figure out how to get it to recognize kwineffect.desktop, I'll submit another diff if I figure it out.
Doesn't work...
In D12041#247352, @abetts wrote:Why not save the room on the right of the KCM and instead blur the actual image in the list? Move the controls closer to that list item? The arrangement looks off the way it shows in the screenshots.
I'm still unsure how to update the dropdown after you download a new plugin.
Move open GHNS window function from Wallpaper.Image to ShellPrivate.WallpaperPlugin
Change from Wallpaper.Image to the ShellPrivate.WallpaperPlugin
Apr 14 2018
So you're proposing that folders show the Open With... entry, but omit the recently added additional entry that shows the first app?
- Open with "Sublime Text" / "Atom"
- Open with "K4DirStat"
- Open with "Clementine"
Apr 10 2018
rather on the refactoring_timeline
Apr 9 2018
Thanks for accepting it! I think I'll try having it preview a the text next. Need to replace the %s in the preview with the QTextEdit text.
Apr 8 2018
Remove commented code.
Add " New " to button label.
Apr 6 2018
Um, if (immutability() != Plasma::Types::SystemImmutable) { return; } was pushed.
Apr 5 2018
Yep, D4751 was used instead.
Forgot to add reviewers.