In D21281#466844, @davidhurka wrote:

Is there some more KParts literature? I could find KParts on api.kde.org and the tutorials on community.kde.org, but couldn’t really transfer that to Okular.

• rebase on master
• remove the "Only for PDF documents" tooltips
• change drawing of (R)OpenArrow, (R)ClosedArrow, Slash so that combination with leader line makes sense for dimensioning purpose (I think poppler should be adapted accordingly)
• fix drawing leader lines

• Fix typos spotted by yurchor
• Fix typos spotted by Albert

Didn’t get far yet. Much information is visible in the source code, but what should I put into the class/member documentation, and what is clear just because it’s a Part?

TextPagePrivate::correctTextOrder() calls some complex functions, which are yet undocumented. Interesting stuff is happening in them, so they should get some documentation. I added their prototypes to core/textpage_p.h, so I can add documentation to them.

Thanks for fixing these typos.

Added circle, expose LineAnnotPainer.

Whitespace fix

Use const QString & instead of auto in range loop

This is part of my goal to understand how TextEntity reordering works. There will probably be more patches like this soon.

LGTM too.

Thanks, LGTM. If nobody objects I'll accept and land this on master the day after tomorrow.

What about QMatrix or QTransform?

Thanks, using QTransform now, it's already widely used in Okular.

Is there an existing class for affien matrix operations?

@knambiar If this once lands, you can remove your "for PDF only" tooltip.

In D21202#466066, @aacid wrote:

Do you have some files that exercise this?

Who would we autotest this?

Do you have some files that exercise this?

Declared g_displayProto as std::unique_ptr

Remove unintentionally left qDebug()

Loops now use const and more efficient way of acessing LinkedList

Review D21238 created for the line start style.

Removed useless iterator

I have figured out, what was going on in the QToolButton.

• Toolbar button finally shows the intended menu
• Add icon for Configure... action
• Corrected action-slot connections
• Named enable/disable action "Change Colors" again, looks better in the toolbar

I have added CheckableActionMenu, which cuts the default action connection between the KActionMenu itself and the toolbar button. Now it is possible to make the toolbar button checkable, but not the submenu.

Removed checkbox from submenu, but toolbar button invents other menu structure

The lambda looks much better, but it uses still int as action data, not Okular::SettingsCore::EnumRenderMode::type, which would make more sense. Is it possible to put Okular::SettingsCore::EnumRenderMode::type into the action’s QVariant? It didn’t work because I couldn’t register it as metatype.

• Renamed the menu entries to Color Mode and Enable Color Changing
• Use lambda function instead of function-like macro

it's a bugfix that doesn't seem to carry any danger, so 19.04 and then merge to master

@aacid Should this small fix land on Applications/19.04 branch, or master only?

Changed for to range based loops

In D21092#465127, @sander wrote:

I'm afraid we'll have similar objections to the endStyle, though, specifically “PDF only” — would that be okay?

IMO it would be okay. Plus, with the help of Tobias maybe you can even teach Okular how to draw the start/end markers for non-pdf documents in a separate patch? I remember him saying that that is not very difficult.

I'm afraid we'll have similar objections to the endStyle, though, specifically “PDF only” — would that be okay?

In D21092#464202, @tobiasdeiminger wrote:

@knambiar
Rajeesh, would you be around for another patch? PDF / poppler allow to draw arrows on both ends of a line (aka start style, end style). Your patches currently target only the line end. Would you implement "start style" in the UI too?

Fixed copyright

In D21195#464938, @aacid wrote:

That menu is ultra hard to understand, it's a checked action + menu with an action with the same name inside that is also a checked action

That menu is ultra hard to understand, it's a checked action + menu with an action with the same name inside that is also a checked action

In D21195#464828, @ngraham wrote:

Screenshots are appreciated when submitting patches that change or add UI elements. :)

https://community.kde.org/Infrastructure/Phabricator#Include_some_screenshots

Nate suggested almost exactly this patch in Bug 407326. But instead of hiding Continuous when accessed from the menubar, I moved Continuous completely to the View Mode submenu.

Okular does not follow the KDELibs coding style, so I tried to follow the existing coding style. Maybe I didn’t understand something right, if so, please correct me.

Screenshots are appreciated when submitting patches that change or add UI elements. :)

@knambiar
Rajeesh, would you be around for another patch? PDF / poppler allow to draw arrows on both ends of a line (aka start style, end style). Your patches currently target only the line end. Would you implement "start style" in the UI too?

commited, somehow phabricator decided not to autoclose this

Drop the combobox change

Use QOverload instead of static_cast

please use QOverload<int>::of() instead of static_cast<void (QComboBox::*)(int)> much easier to read.

There's a few #ifdef HAVE_POPPLER_mm_nn checks in the code, may be we could adapt it for 0.72?

In D20760#462808, @tobiasdeiminger wrote:

There's another problem we haven't discussed yet: Line endings work only if you have poppler >= 0.72 installed, else they will be silently ignored. Version 0.72 is quite recent, a lot of people won't have it because their distro ships an older version. Should we try to handle this? If yes, how? We can use cmake to detect poppler version, but I don't see an easy way to propagate the information from generator to UI at runtime.

What would be a better alternative?

In D20760#462747, @aacid wrote:

Please fix the connect to use the new connect syntax,

I can't go on holiday it seems, you sneak things past me :D

Thanks, I've added your preferences there.

@aacid I put myself in the kde dev script relicense thing, so please look at the patch without getting tainted

In D20760#462025, @sander wrote:

I committed the patch, but without any icons at all. Even without them I think the patch is very helpful. The icons can now be added at ease in a separate patch.

Rajeesh, thanks for the patch. I'd be happy to see more of your patches in the future.

I suggested this in D18744#441906.

I committed the patch, but without any icons at all. Even without them I think the patch is very helpful. The icons can now be added at ease in a separate patch.

Ok albert send me an email in private :)
he will look at it in several days :)
tha,ks :)