Feed Advanced Search

Yesterday

aacid abandoned D17929: Hide cursor when tablet stylus leaves proximity of the screen.

Abandoing this since it's now on https://invent.kde.org/kde/okular/merge_requests/9/diffs

Mon, Jul 22, 8:53 PM · Okular
aacid commandeered D17929: Hide cursor when tablet stylus leaves proximity of the screen.
Mon, Jul 22, 8:53 PM · Okular
simgunz added a comment to T8076: Fix design of annotation toolbar.

@andreask Given that you gave your availabilty to work on the new Okular icons, I have opened this bug (408283) with a (messy) list of what icons are needed. I did not provide icon names yet.

Mon, Jul 22, 6:23 PM · VDG, Okular
simgunz updated the task description for T8076: Fix design of annotation toolbar.
Mon, Jul 22, 6:14 PM · VDG, Okular
simgunz added a comment to D22064: General improvements to stamp annotation.

Small code improvements that can be ignored if you want.

Mon, Jul 22, 6:02 PM · Okular
simgunz updated the diff for D22064: General improvements to stamp annotation.
  • Move to init list
  • Add translation context
  • Use new connect syntax
  • Add tooltip to custom stamp button
Mon, Jul 22, 5:46 PM · Okular
davidhurka added a comment to D21376: RFC: In annotations list show highlighted text.

This would help to fix/implement bug 377886. The missing part is tweaking the search field above the annotation tree view.

Mon, Jul 22, 5:35 PM · Okular
simgunz added a comment to D15580: [WIP] New annotation toolbar.

Do you have to move this to gitlab anyway?

Mon, Jul 22, 4:52 PM · Okular
ltoscano added a comment to D15580: [WIP] New annotation toolbar.

@davidhurka Thanks for looking up the bug numbers

Do you know if adding the bug numbers separated by a comma without repeating the keyword BUG would work?

Probably not: https://community.kde.org/Infrastructure/Phabricator#Add_special_keywords

Do you have to move this to gitlab anyway?

Mon, Jul 22, 4:48 PM · Okular
davidhurka added a comment to D15580: [WIP] New annotation toolbar.

@davidhurka Thanks for looking up the bug numbers

Do you know if adding the bug numbers separated by a comma without repeating the keyword BUG would work?

Mon, Jul 22, 4:46 PM · Okular
simgunz updated the summary of D15580: [WIP] New annotation toolbar.
Mon, Jul 22, 4:40 PM · Okular
simgunz added a comment to D15580: [WIP] New annotation toolbar.

@davidhurka Thanks for looking up the bug numbers

Mon, Jul 22, 4:40 PM · Okular
simgunz updated the summary of D15580: [WIP] New annotation toolbar.
Mon, Jul 22, 4:38 PM · Okular
simgunz updated the diff for D15580: [WIP] New annotation toolbar.
  • Check if chosen color is valid before storing it
  • Notify PageViewAnnotator when the color has changed
  • Add missing annotation tools actions
  • Add XML annotation tools and connect corresponding actions
  • Add typewriter annotation tool
  • Set actions groups for all tools and text tools
  • Reimplement setToolsEnabled and setTextToolsEnabled
  • Reimplement setToolsEnabled and setTextToolsEnabled (correct way)
  • Disable code previously used to define annotation toolbar elements
  • Remove unused static constant
  • Revert "New annotation toolbar"
  • Add method to set color picker colorized icon
  • Remove method annotationColor
  • Set color of annotations tools when changed in color picker
  • Read color from settings when annotation tool selected
  • Save annotation tool settings to file on exit
  • Rename and simplify method to deselect all annotation actions
  • Refactor colorChanged slot
  • Add font selector
  • Add methods to access annotation and engine elements
  • Add basic implementation of width selector
  • Minor refactor
  • Remove unused code
  • Store font and width actions
  • Enable config actions based on selected annotation
  • Re-sort code
  • Add arrow annotation
  • Rename variables
  • Add inner color selector
  • Clean setEnabled method
  • Set inner color icon to transparent if tool does not support it
  • Allow setting font color
  • Fix widthAction wrongly enabled for inline-note
  • Fix crash on application exit
  • Improve annotations default colors
  • Fix arrow annotation tool XML
  • Use draw-polyline icon for Polygon
  • Change icon of strikethrough (remove symbolic suffix)
  • Add TODO in code
  • Rename PageViewToolBar to AnnotationActionHandler
  • No need to forceHide mechanism
  • Use KToggleAnnotationToolBar to show/hide toolbar (not working)
  • Remove unused variable
  • Remove tooltips that are never shown in any case
  • Add width action icons
  • Use KToggleAction
  • Make m_toolsDefinition a QDomDocument
  • Remove unused method
  • Refactor code and remove obsolete code
  • Detach annotation when mouse mode is not Normal mode
  • Use Qt5 connect syntax where possible
  • Add Advanced Settings dialog
  • Set better action names
  • Add opacity selection action
  • Fix width text
  • Rename XML actions
  • Keep a state of the selected tool
  • Add favorite annotation tools
  • Correctly enable annotations
  • Fix advanced settings not saved
  • Fix and simplify width action
  • Fix and simplify opacity action
  • Fix annotation tools actions
  • Rename color action
  • Formatting
  • Remove unuseful annotation separators
  • Correctly set favorites action enabled
  • Properly trigger favorite action
  • Allow unchecking annotation actions
  • Minor refactor
  • Save state of continuous mode
  • Clean parseTool
  • Initialize private members
  • Add action to toggle annotation toolbar, set default position below
  • Add i18n
  • Move default value to declaration
  • Add tooltips
  • Fix error in rebase
  • Disable name and type edit for builtin tools
  • Fix action deselected if favorite tool with the same type is activated
  • Fix geom shapes action disabled when okular reparses config
  • Disable text annotation when file does not support them
Mon, Jul 22, 4:34 PM · Okular
davidhurka added a comment to D15580: [WIP] New annotation toolbar.

You could consider to add these bugs as BUG keywords to this patch: 386578, 374728, 352310, 330518, 341914, 157289

Mon, Jul 22, 3:51 PM · Okular

Sun, Jul 21

ngraham added a comment to D22064: General improvements to stamp annotation.

If the feature is considered fundamentally broken, then just hiding it behind a bad UI isn't really enough because people will discover it anyway (I did). It either should be totally removed so we don't torture users until Poppler can handle it properly, or it should be branded with a big banner that says "warning, this is an experimental feature. It may not work in X, Y, or Z circumstances." Personally I would prefer the latter.

Sun, Jul 21, 8:55 PM · Okular
aacid closed D21266: Improve documentation of area classes.
Sun, Jul 21, 6:00 PM · Okular
pino added inline comments to D22064: General improvements to stamp annotation.
Sun, Jul 21, 8:54 AM · Okular
aacid closed D21271: Improve documentation of TextEntity stuff.
Sun, Jul 21, 8:50 AM · Okular
aacid added a comment to D22064: General improvements to stamp annotation.

Small code improvements that can be ignored if you want.

Sun, Jul 21, 8:48 AM · Okular

Wed, Jul 17

ngraham closed D22145: Add "Open Containing Folder" feature.
Wed, Jul 17, 2:38 PM · Okular
aacid accepted D22145: Add "Open Containing Folder" feature.
Wed, Jul 17, 2:17 PM · Okular
ngraham updated the diff for D22145: Add "Open Containing Folder" feature.

Don't crash if setupActions() didn't get run

Wed, Jul 17, 1:58 PM · Okular

Tue, Jul 16

ngraham added a comment to D22145: Add "Open Containing Folder" feature.

Is that a shipit? :)

Tue, Jul 16, 5:46 PM · Okular
davidhurka added a comment to D22145: Add "Open Containing Folder" feature.

Sorry, I forgot about this.

Tue, Jul 16, 10:56 AM · Okular
sander added inline comments to D15347: Modify CloseDialogHelper in parttest.
Tue, Jul 16, 10:50 AM · Okular
sander added a comment to D15347: Modify CloseDialogHelper in parttest.

Could you put a qInfo() << *e in PageViewAnnotator::routeMouseEvent while reproducing bug 409638, so that we're sure what kind of events cause the trouble?

Tue, Jul 16, 8:13 AM · Okular
tobiasdeiminger added a comment to D15347: Modify CloseDialogHelper in parttest.

In bug 409638 it's probably a TabletEnterProximity event instead.

That's unlikely, because TabletEnterProximityEvents are a bit special. From https://doc.qt.io/qt-5/qtabletevent.html :

"The [...] TabletEnterProximity and TabletLeaveProximity [...] are only sent to QApplication"

Tue, Jul 16, 7:57 AM · Okular
sander added a comment to D15347: Modify CloseDialogHelper in parttest.

In bug 409638 it's probably a TabletEnterProximity event instead.

Tue, Jul 16, 4:07 AM · Okular

Mon, Jul 15

aacid added inline comments to D15347: Modify CloseDialogHelper in parttest.
Mon, Jul 15, 10:45 PM · Okular
ngraham updated the diff for D22145: Add "Open Containing Folder" feature.

Put it in the group of other actions that act on the open file

Mon, Jul 15, 7:33 PM · Okular
ngraham added a comment to D22145: Add "Open Containing Folder" feature.

Actually now that I think about it, it should be even lower in the menu since it isn't an action that results in the opening of a new document, it's an action that gets performed on an open document.

Mon, Jul 15, 7:30 PM · Okular
tobiasdeiminger added a comment to D15347: Modify CloseDialogHelper in parttest.

Interestingly, if we remove QTest::mouseMove and just keep QTest::mouseClick in above test, the test passes OK as expected.

Mon, Jul 15, 7:04 PM · Okular
tobiasdeiminger added a comment to D15347: Modify CloseDialogHelper in parttest.

Agreed. I think the first step should be to write a unit test that triggers https://bugs.kde.org/show_bug.cgi?id=409638. That way we get a reproducible way to trigger the problem even for people without a stylus.

Mon, Jul 15, 6:00 PM · Okular
shubham added a comment to D22145: Add "Open Containing Folder" feature.

Shouldn't this be below Open Recent?

Mon, Jul 15, 5:53 PM · Okular
ngraham added a comment to D22145: Add "Open Containing Folder" feature.

And since this contains a new string, if possible I'd like to try to get it into the next release before the freeze, which is in three days.

Mon, Jul 15, 5:29 PM · Okular
ngraham added a comment to D22145: Add "Open Containing Folder" feature.

Works fine with that encrypted PDF.

Mon, Jul 15, 5:28 PM · Okular

Sun, Jul 14

sander added a comment to D15347: Modify CloseDialogHelper in parttest.

Agreed. I think the first step should be to write a unit test that triggers https://bugs.kde.org/show_bug.cgi?id=409638. That way we get a reproducible way to trigger the problem even for people without a stylus.

Sun, Jul 14, 5:31 PM · Okular
simgunz added a comment to D15580: [WIP] New annotation toolbar.

I messed up something... I see many files I have not modified that are marked as modified here. Probably because I changed the origin remote and my master was not in sync with upstream. I'll fix this with the next arc diff, now it does not let me arc diff again because it says that the diff is empty.

Sun, Jul 14, 2:06 PM · Okular
simgunz updated the task description for T8076: Fix design of annotation toolbar.
Sun, Jul 14, 2:02 PM · VDG, Okular
simgunz updated the diff for D15580: [WIP] New annotation toolbar.
  • Fix action deselected if favorite tool with the same type is activated
  • Fix geom shapes action disabled when okular reparses config
  • Disable text annotation when file does not support them
Sun, Jul 14, 1:54 PM · Okular
tobiasdeiminger added a comment to D15347: Modify CloseDialogHelper in parttest.

@tobiasdeiminger , that hidden bug you mention, could it be the cause of https://bugs.kde.org/show_bug.cgi?id=409638 ?

Sun, Jul 14, 10:57 AM · Okular
sander added a comment to D15347: Modify CloseDialogHelper in parttest.

@tobiasdeiminger , that hidden bug you mention, could it be the cause of https://bugs.kde.org/show_bug.cgi?id=409638 ?

Sun, Jul 14, 8:29 AM · Okular

Sun, Jul 7

stevenv abandoned D22259: Reduce default sidebar icon size.
Sun, Jul 7, 5:12 AM · Okular
ngraham added a comment to D22259: Reduce default sidebar icon size.

Yeah I think this needs more design work rather than a defaults change. If we just reduce the icons' size, it won't make any difference because the text is the widest element, and if we remove the text, it will impair usability because the icons aren't meaningful enough on their own to communicate what the tabs do. Maybe we should consider adding a mode selector to the top of the sidebar itself, and a new button on the default toolbar that toggles the sidebar's visibility.

Sun, Jul 7, 2:06 AM · Okular
stevenv added a comment to D22259: Reduce default sidebar icon size.

Apologies for the slightly delayed response, I have been (and still am) traveling. I will try to reply to comments in order.

Sun, Jul 7, 12:54 AM · Okular

Sat, Jul 6

kezik added a watcher for Okular: kezik.
Sat, Jul 6, 10:40 PM
aacid added inline comments to D22145: Add "Open Containing Folder" feature.
Sat, Jul 6, 10:57 AM · Okular

Fri, Jul 5

davidhurka added a comment to D22145: Add "Open Containing Folder" feature.

Show the local file path, which handles the case of locally-downloaded remote files

Fri, Jul 5, 6:20 PM · Okular
sander added a comment to D17929: Hide cursor when tablet stylus leaves proximity of the screen.

With the help of Tobias (thanks!) I wrote a unit test. You can find it at https://invent.kde.org/kde/okular/merge_requests/9 .

Fri, Jul 5, 3:16 PM · Okular
ngraham added a comment to D22145: Add "Open Containing Folder" feature.

I don't have any encrypted PDFs to test. If you have any, could you send one along? Or better yet, test it with this feature?

Fri, Jul 5, 2:05 PM · Okular
ngraham updated the diff for D22145: Add "Open Containing Folder" feature.

Show the local file path, which handles the case of locally-downloaded remote files

Fri, Jul 5, 2:04 PM · Okular
ngraham planned changes to D22145: Add "Open Containing Folder" feature.

Good points!

Fri, Jul 5, 1:14 PM · Okular
ngraham requested changes to D22259: Reduce default sidebar icon size.

I like the idea of having a thinner sidebar, but I don't like the idea of having unlabelled views by default. I think hiding labels would hurt usability for first time users.

Fri, Jul 5, 1:04 PM · Okular
simgunz added a comment to T8076: Fix design of annotation toolbar.

How will you do what currently a double-click does? It should still be possible to do more than one annotation in one go.

Fri, Jul 5, 7:20 AM · VDG, Okular
simgunz updated the task description for T8076: Fix design of annotation toolbar.
Fri, Jul 5, 7:06 AM · VDG, Okular
simgunz updated the diff for D15580: [WIP] New annotation toolbar.
  • Add i18n
  • Move default value to declaration
  • Add tooltips
Fri, Jul 5, 7:06 AM · Okular
simgunz updated the task description for T8076: Fix design of annotation toolbar.
Fri, Jul 5, 5:37 AM · VDG, Okular
simgunz updated subscribers of D15580: [WIP] New annotation toolbar.

I have managed to re-enable the action Tools > Review to show/hide the annotation toolbar.

Fri, Jul 5, 5:35 AM · Okular
simgunz updated the diff for D15580: [WIP] New annotation toolbar.
  • Clean parseTool
  • Initialize private members
  • Add action to toggle annotation toolbar, set default position below
Fri, Jul 5, 5:05 AM · Okular

Thu, Jul 4

ndavis added a comment to D22259: Reduce default sidebar icon size.

I like the idea of having a thinner sidebar, but I don't like the idea of having unlabelled views by default. I think hiding labels would hurt usability for first time users.

I was on the fence about hiding the text for exactly that reason. But since the text is so wide it keeps the sidebar huge too. From a usability standpoint I think the tooltips might be enough, but I'm not a designer.

Thu, Jul 4, 5:17 PM · Okular
aacid added a comment to D22259: Reduce default sidebar icon size.

Unless you can give me empirical data that people prefer what you suggest i don't see the point in a change.

Thu, Jul 4, 5:09 PM · Okular
aacid added a comment to D22262: Thumbnails sidebar always open when okular starts.

Please use invent.kde.org for new Merge requests agains okular.

Thu, Jul 4, 5:05 PM · Okular
stevenv added a comment to D22259: Reduce default sidebar icon size.

I like the idea of having a thinner sidebar, but I don't like the idea of having unlabelled views by default. I think hiding labels would hurt usability for first time users.

Thu, Jul 4, 3:53 PM · Okular
mayankchoudhary added a comment to D22262: Thumbnails sidebar always open when okular starts.

When I am trying to write autotests the pointer moves outside of the okular window. I tried

Thu, Jul 4, 10:17 AM · Okular
mayankchoudhary added a comment to D22262: Thumbnails sidebar always open when okular starts.

Should i write autotests ?

Thu, Jul 4, 10:09 AM · Okular
mayankchoudhary added reviewers for D22262: Thumbnails sidebar always open when okular starts: aacid, ngraham, Okular.
Thu, Jul 4, 10:08 AM · Okular
mayankchoudhary requested review of D22262: Thumbnails sidebar always open when okular starts.
Thu, Jul 4, 10:06 AM · Okular
ndavis added a comment to D22259: Reduce default sidebar icon size.

I like the idea of having a thinner sidebar, but I don't like the idea of having unlabeled views by default. I think hiding labels would hurt usability for first time users.

Thu, Jul 4, 3:06 AM · Okular
stevenv requested review of D22259: Reduce default sidebar icon size.
Thu, Jul 4, 2:29 AM · Okular

Mon, Jul 1

aacid added a comment to D22118: Shifts focus to the document when collapsing a sidebar view.

can we get an autotest so we don't regress in the future?

Mon, Jul 1, 6:34 PM · Okular
mayankchoudhary added a comment to D22118: Shifts focus to the document when collapsing a sidebar view.

Please before the merge commit, change my username to "Mayank Choudhary".

Mon, Jul 1, 4:10 PM · Okular
davidhurka added a comment to D22145: Add "Open Containing Folder" feature.

How does it work when the document is not local, or is deleted?
E. g. do

okular https://20years.kde.org/book/20yearsofKDE.pdf
Mon, Jul 1, 3:26 PM · Okular
mayankchoudhary added a comment to D22118: Shifts focus to the document when collapsing a sidebar view.

@aacid May you please review this ?

Mon, Jul 1, 2:40 PM · Okular
maguirre added a watcher for Okular: maguirre.
Mon, Jul 1, 3:19 AM

Sun, Jun 30

steffenh updated the diff for D21759: Hold zoom center below center/mouse position.
  • lock mouse cursor for middle mouse button zooming
  • adjust for disappear and appear of scrollbars
  • try to recenter if zoom center moving below the mouse cursor
Sun, Jun 30, 4:00 PM · Okular

Fri, Jun 28

ngraham accepted D22118: Shifts focus to the document when collapsing a sidebar view.

Thanks, this has driven me crazy for years. Works fine and LGTM, though I'd like a review from @aacid or @sander or another Okular person first.

Fri, Jun 28, 3:51 PM · Okular
ngraham added reviewers for D22118: Shifts focus to the document when collapsing a sidebar view: Okular, aacid, sander.
Fri, Jun 28, 3:50 PM · Okular
ngraham requested review of D22145: Add "Open Containing Folder" feature.
Fri, Jun 28, 3:44 PM · Okular
simgunz retitled D15580: [WIP] New annotation toolbar from New annotation toolbar to [WIP] New annotation toolbar.
Fri, Jun 28, 6:09 AM · Okular
simgunz updated subscribers of D22064: General improvements to stamp annotation.

@aacid Can you also have a look at this revision when you have the time?

Fri, Jun 28, 6:08 AM · Okular

Thu, Jun 27

mayankchoudhary requested review of D22118: Shifts focus to the document when collapsing a sidebar view.
Thu, Jun 27, 10:47 AM · Okular

Tue, Jun 25

aacid added a comment to D17929: Hide cursor when tablet stylus leaves proximity of the screen.

I've been wondering whether it would be possible to write a unit test that sends out all the necessary events. That would allow to debug the problem without actually having the required hardware. Is that possible in principle?

Tue, Jun 25, 9:21 PM · Okular
aacid added a comment to D17929: Hide cursor when tablet stylus leaves proximity of the screen.

Albert, how much would a suitable pen cost you? I offer to give you one as donation if that would help you finish this patch.

Tue, Jun 25, 9:21 PM · Okular
ngraham accepted D22064: General improvements to stamp annotation.

Looks good to me, but I'd like a review from an Okular person, too.

Tue, Jun 25, 6:53 PM · Okular
simgunz updated the summary of D22064: General improvements to stamp annotation.
Tue, Jun 25, 6:09 PM · Okular
simgunz added a comment to D22064: General improvements to stamp annotation.

Added the enum, much better now.

Tue, Jun 25, 6:08 PM · Okular
simgunz updated the diff for D22064: General improvements to stamp annotation.
  • Define enum for preview position
Tue, Jun 25, 6:05 PM · Okular
yurchor added a comment to D22064: General improvements to stamp annotation.

@yurchor Are you willing to update the documentation regarding this modification after we merge this? (I saw you changed the doc regarding the refactor of the annotation tools config dialogs, and it seems you have experience with the documentation aspect).

Tue, Jun 25, 8:06 AM · Okular
sander added a comment to D17929: Hide cursor when tablet stylus leaves proximity of the screen.

Albert, how much would a suitable pen cost you? I offer to give you one as donation if that would help you finish this patch.

Tue, Jun 25, 7:52 AM · Okular
ngraham added inline comments to D22064: General improvements to stamp annotation.
Tue, Jun 25, 7:42 AM · Okular
ngraham updated the summary of D22064: General improvements to stamp annotation.
Tue, Jun 25, 7:36 AM · Okular
simgunz updated subscribers of D22064: General improvements to stamp annotation.

@yurchor Are you willing to update the documentation regarding this modification after we merge this? (I saw you changed the doc regarding the refactor of the annotation tools config dialogs, and it seems you have experience with the documentation aspect).

Tue, Jun 25, 7:30 AM · Okular

Mon, Jun 24

davidhurka added a comment to D21734: [WIP] Improve class documentation for PageView and PageViewItem.
Mon, Jun 24, 8:09 PM · Okular
davidhurka updated the diff for D21734: [WIP] Improve class documentation for PageView and PageViewItem.
  • Forgot to de-rename out_firstpage in doxygen
  • Fix compilation by renaming a parameter I named “default”
  • Fix grammar in PageViewItem
Mon, Jun 24, 8:08 PM · Okular
davidhurka updated the summary of D21266: Improve documentation of area classes.
Mon, Jun 24, 2:54 PM · Okular
davidhurka added a comment to D21266: Improve documentation of area classes.

Changed 3 more lines yesterday.
Now removing [WIP]; I have some remaining questions (inline coments without “done”), but these are not important for this patch.

Mon, Jun 24, 2:50 PM · Okular
volkov abandoned D21363: Fix build with poppler < 0.51.

It's specific only for AstraLinux.

Mon, Jun 24, 10:21 AM · Okular
ngraham added a comment to D22064: General improvements to stamp annotation.

This is fantastic! I tested it out and it works perfectly. Huge improvement.

Mon, Jun 24, 9:10 AM · Okular
simgunz added a comment to D22064: General improvements to stamp annotation.


Okular embedded stamp

Mon, Jun 24, 6:23 AM · Okular