chm plugin is now disabled and okular is on KF6.

Okular is on KF6 now without KJS.
for pdf, Volker ported it.

A first approximation for a solution is to stop building the chm plugin at the KF6 port. I'm not sure if it will happen for the megarelease or not; there does not seem to be much progress.

Still relevant: https://invent.kde.org/graphics/okular/-/blob/047400294d4a0a8798d7045f0d6745c3f0b6eb8c/CMakeLists.txt#L268

Hey,
So I sent a merge request for this, but the issue is now that clazy formatting in the ci/cd of the build requires these too lines be changed to something more readable:

// output a left-to-right section
for (j = i; j < origTxtOrder.length() && ! origTxtOrder.at(j)->text().isRightToLeft(); ++j) ;

and

Done, but I can't test it:
https://invent.kde.org/graphics/okular/-/merge_requests/595

Step 1 would be to open a merge request at https://invent.kde.org/graphics/okular/-/merge_requests . Can you do that?

Hey, Any progress on this?
What needs to change in core/textpage.cpp in order for this to work correctly?

Beautiful!

The redesign has finished. Let's close this.

Please subscribe to the mailing list and discuss there, i want to let phabricator die as soon as possible.

As discussed in today's BoF: removing from KF6 board, not a blocker for KF6 itself.

Great. If there's a plan, then it's not a blocker for KF6 itself anymore -> removing the KF6 tag.

Another potential solution is using litehtml/qlitehtml that seems to know how to paint to a qpainter and would solve the reason for which we can't move to qwebengine for example

Exactly, QJSEngine::setInterrupted really seems like one can hook a qtimer from another thread to stop it, so that is the last missing feature from KJS as far as i can see.

I think we might be thinking about QJSEngine::setInterrupted
https://doc.qt.io/qt-6/qjsengine.html#setInterrupted

Albert says it's now possible to force-stop the interpreter in ... QQmlEngine?

I think we can call this done now. Further improvements can be tracked with Okular's workboard/issue-tracker-used-being-used-as-a-replacement-for-phabricator-tasks.

I read the reported test results as if this doesn’t work correctly. However, without this patch it doesn’t work at all, so that may already be an argument to accept this patch.

I'm still experiencing this bug.

PLOT TWIST

ognarb is Carl ;)

You are right @aacid, you were super nice and I am really thankful for your answers 🙏🥰 I was actually going to write you a mail thanking you before I saw this issue, sorry

It is not fair to say that you got no answer, i answered you.

So I don't think I can mentor a website related season of KDE alone (I want to focus on NeoChat or the documentation for SoK), but some people volunteered to help in the website channel so I might become a co-mentor ;) It would be nice to also have someone from the Okular team so that we can create something that there are happy with.

Hi! I would be interested in taking the task of updating Okular's website using HUGO as part of Season of KDE 2020. I posted a message on the okular-devel and kde-www mailing list, but got no answer. Would my work be useful? Would someone take me as their mentor?

chmk Not happening for 20.12, maybe 21.04, and even if it doesn, i don't see a reason to drop chm support from okular until KF6-okular

In T11539#231361, @aacid wrote:

Potential solution, just drop CHM support https://tsdgeos.blogspot.com/2020/05/chmk-simple-chm-viewer.html

It is still open :D I had some very basic work on it on a branch somewhere on my computer that I just pushed in this branch: https://invent.kde.org/carlschwan/okular-kde-org/-/tree/hugo.

@ognarb I would like to work on this, If its still open.

In D20868#615357, @aacid wrote:

Please move as a Merge Request in https://invent.kde.org/kde/okular

We have pre-commit CI and lots of checks including clazy and clang-tidy there so it's a much better place for doing the review/approval/merge of the code.

As i mentioned on the part task, this is not possible at this point

Moved:

Potential solution, just drop CHM support https://tsdgeos.blogspot.com/2020/05/chmk-simple-chm-viewer.html

The patch is now at https://invent.kde.org/kde/okular/-/merge_requests/163

Thanks for the patch! Okular uses GitLab now. Can you re-submit this as a Merge Request at https://invent.kde.org/kde/okular/-/merge_requests/?

Merge request at https://invent.kde.org/kde/okular/-/merge_requests/141

Moved to invent as https://invent.kde.org/kde/okular/-/merge_requests/152

Please use invent.kde.org for patches so we get the pre-commit CI

I made some experiments.

1. color-mode-black-white
2. color-mode-change-dark-light
3. color-mode-hue-shift-240
4. color-mode-hue-shift-120
5. paper-color
6. color-mode-invert-text
7. color-mode-invert-image
8. Alternative to color-mode-invert-image
9. Alternative to color-mode-invert-image
10. color-mode-invert
11. Alternative to color-mode-invert
12. Alternative to color-mode-invert-text

That makes sense to me.

Moved to https://invent.kde.org/kde/okular/-/merge_requests/135

The patch is now at https://invent.kde.org/kde/okular/-/merge_requests/134.

See also https://community.kde.org/Infrastructure/GitLab

When you create the merge request:

• set the title to WIP: title of merge request to mark it as work in progress
• push the commits as you work so you have a backup, can see the results of the CI tests and possibly receive feedbacks

And someone needs to explain how to create merge requests on invent.kde.org. I tried three ways and failed, and unfortunately I can only find instructions for Phabricator.

In D15580#606022, @aacid wrote:

In D15580#605913, @davidhurka wrote:

In D15580#605611, @simgunz wrote:

aacid requested to write some autotest for the ToggleActionMenu before merging this. I'll merge master in this review and work on the autotests soon.

It’s okay to me that you write the autotests. If you wish, I could do that instead.

I am new to autotests, so I will have to learn how to do that. I am also unsure about what should be tested. The ToggleActionMenu itself, or its behaviour in Okular?

davidhurka (David Hurka)

User

Moved to KDE invent.

Please move as a Merge Request in https://invent.kde.org/kde/okular

Please move as a Merge Request in https://invent.kde.org/kde/okular

Please move as a Merge Request in https://invent.kde.org/kde/okular

Please move as a Merge Request in https://invent.kde.org/kde/okular

Please move as a Merge Request in https://invent.kde.org/kde/okular

Please move as a Merge Request in https://invent.kde.org/kde/okular

Please move as a Merge Request in https://invent.kde.org/kde/okular

Please move as a Merge Request in https://invent.kde.org/kde/okular

Please move as a Merge Request in https://invent.kde.org/kde/okular

Please move as a Merge Request in https://invent.kde.org/kde/okular

Please move as a Merge Request in https://invent.kde.org/kde/okular

Please move as a Merge Request in https://invent.kde.org/kde/okular

Please move as a Merge Request in https://invent.kde.org/kde/okular

Please move as a Merge Request in https://invent.kde.org/kde/okular

Please move as a Merge Request in https://invent.kde.org/kde/okular

Please move as a Merge Request in https://invent.kde.org/kde/okular

Please move as a Merge Request in https://invent.kde.org/kde/okular

Please move as a Merge Request in https://invent.kde.org/kde/okular

Please move as a Merge Request in https://invent.kde.org/kde/okular

Please move as a Merge Request in https://invent.kde.org/kde/okular

Please move as a Merge Request in https://invent.kde.org/kde/okular

Please move as a Merge Request in https://invent.kde.org/kde/okular

Please move as a Merge Request in https://invent.kde.org/kde/okular

Please move to https://invent.kde.org/kde/okular/

Moved to KDE invent.

@simgunz now that we have https://invent.kde.org/kde/okular/merge_requests/105 can you discard this one?

In D15580#606046, @yurchor wrote:

It would be nice if someone can test compile and run Kile with the new toolbar.

Kile cannot be stared (immediately crashes) here. I have Kile and Okular from git/master.

However, Kile works fine with Okular from release/19.12 branch.

Thanks in advance for your testing.

It would be nice if someone can test compile and run Kile with the new toolbar.

In D15580#605913, @davidhurka wrote:

In D15580#605611, @simgunz wrote:

aacid requested to write some autotest for the ToggleActionMenu before merging this. I'll merge master in this review and work on the autotests soon.

It’s okay to me that you write the autotests. If you wish, I could do that instead.

I am new to autotests, so I will have to learn how to do that. I am also unsure about what should be tested. The ToggleActionMenu itself, or its behaviour in Okular?