Feed Advanced Search

Yesterday

aacid added a comment to D21281: [RFC] Write a bit Documentation for Part and PageView.

Is there some more KParts literature? I could find KParts on api.kde.org and the tutorials on community.kde.org, but couldn’t really transfer that to Okular.

Sun, May 19, 10:13 PM · Okular
aacid added inline comments to D21266: [WIP] Improve documentation of area classes.
Sun, May 19, 10:09 PM · Okular
davidhurka added inline comments to D21271: [WIP] Improve documentation of TextEntity stuff.
Sun, May 19, 9:31 PM · Okular
tobiasdeiminger updated the diff for D21248: Add line annotation ending arrows for non PDF documents.
  • rebase on master
  • remove the "Only for PDF documents" tooltips
  • change drawing of (R)OpenArrow, (R)ClosedArrow, Slash so that combination with leader line makes sense for dimensioning purpose (I think poppler should be adapted accordingly)
  • fix drawing leader lines
Sun, May 19, 9:09 PM · Okular
davidhurka updated the diff for D21271: [WIP] Improve documentation of TextEntity stuff.
  • Fix typos spotted by yurchor
  • Fix typos spotted by Albert
Sun, May 19, 9:00 PM · Okular
aacid added inline comments to D21271: [WIP] Improve documentation of TextEntity stuff.
Sun, May 19, 8:45 PM · Okular
tobiasdeiminger closed D21238: Okular Annotation: add support for line start style for Straight Line tool.
Sun, May 19, 7:34 AM · Okular
tobiasdeiminger accepted D21238: Okular Annotation: add support for line start style for Straight Line tool.
Sun, May 19, 7:03 AM · Okular

Sat, May 18

davidhurka added a comment to D21281: [RFC] Write a bit Documentation for Part and PageView.

Didn’t get far yet. Much information is visible in the source code, but what should I put into the class/member documentation, and what is clear just because it’s a Part?

Sat, May 18, 11:57 PM · Okular
davidhurka requested review of D21281: [RFC] Write a bit Documentation for Part and PageView.
Sat, May 18, 11:52 PM · Okular
davidhurka added a comment to D21271: [WIP] Improve documentation of TextEntity stuff.

TextPagePrivate::correctTextOrder() calls some complex functions, which are yet undocumented. Interesting stuff is happening in them, so they should get some documentation. I added their prototypes to core/textpage_p.h, so I can add documentation to them.

Sat, May 18, 12:47 PM · Okular
yurchor added a comment to D21271: [WIP] Improve documentation of TextEntity stuff.

Thanks for fixing these typos.

Sat, May 18, 12:38 PM · Okular
davidhurka requested review of D21271: [WIP] Improve documentation of TextEntity stuff.
Sat, May 18, 12:26 PM · Okular
tobiasdeiminger updated the test plan for D21248: Add line annotation ending arrows for non PDF documents.
Sat, May 18, 8:58 AM · Okular
tobiasdeiminger updated the diff for D21248: Add line annotation ending arrows for non PDF documents.

Added circle, expose LineAnnotPainer.

Sat, May 18, 8:49 AM · Okular
knambiar updated the diff for D21238: Okular Annotation: add support for line start style for Straight Line tool.

Whitespace fix

Sat, May 18, 5:59 AM · Okular
knambiar updated the diff for D21238: Okular Annotation: add support for line start style for Straight Line tool.

Use const QString & instead of auto in range loop

Sat, May 18, 5:57 AM · Okular

Fri, May 17

davidhurka added a comment to D21266: [WIP] Improve documentation of area classes.

This is part of my goal to understand how TextEntity reordering works. There will probably be more patches like this soon.

Fri, May 17, 11:46 PM · Okular
davidhurka requested review of D21266: [WIP] Improve documentation of area classes.
Fri, May 17, 11:06 PM · Okular
tobiasdeiminger added inline comments to D21238: Okular Annotation: add support for line start style for Straight Line tool.
Fri, May 17, 5:43 PM · Okular
ngraham added a comment to D21238: Okular Annotation: add support for line start style for Straight Line tool.

LGTM too.

Fri, May 17, 4:01 PM · Okular
tobiasdeiminger added a comment to D21238: Okular Annotation: add support for line start style for Straight Line tool.

Thanks, LGTM. If nobody objects I'll accept and land this on master the day after tomorrow.

Fri, May 17, 10:38 AM · Okular
tobiasdeiminger updated the summary of D21248: Add line annotation ending arrows for non PDF documents.
Fri, May 17, 7:33 AM · Okular
tobiasdeiminger updated the diff for D21248: Add line annotation ending arrows for non PDF documents.

What about QMatrix or QTransform?

Thanks, using QTransform now, it's already widely used in Okular.

Fri, May 17, 7:30 AM · Okular
sander added a comment to D21248: Add line annotation ending arrows for non PDF documents.

Is there an existing class for affien matrix operations?

Fri, May 17, 4:39 AM · Okular

Thu, May 16

tobiasdeiminger updated subscribers of D21248: Add line annotation ending arrows for non PDF documents.

@knambiar If this once lands, you can remove your "for PDF only" tooltip.

Thu, May 16, 10:46 PM · Okular
tobiasdeiminger requested review of D21248: Add line annotation ending arrows for non PDF documents.
Thu, May 16, 10:41 PM · Okular
joaonetto added a comment to D21202: Added basic JavaScript functions to support animated PDF.

Do you have some files that exercise this?

Who would we autotest this?

Thu, May 16, 8:58 PM · Okular
aacid added a comment to D21202: Added basic JavaScript functions to support animated PDF.

Do you have some files that exercise this?

Thu, May 16, 8:55 PM · Okular
sander added inline comments to D21202: Added basic JavaScript functions to support animated PDF.
Thu, May 16, 12:50 PM · Okular
joaonetto updated the diff for D21202: Added basic JavaScript functions to support animated PDF.

Declared g_displayProto as std::unique_ptr

Thu, May 16, 12:00 PM · Okular
joaonetto updated the diff for D21202: Added basic JavaScript functions to support animated PDF.

Remove unintentionally left qDebug()

Thu, May 16, 11:47 AM · Okular
anthonyfieroni added inline comments to D21202: Added basic JavaScript functions to support animated PDF.
Thu, May 16, 11:45 AM · Okular
joaonetto added inline comments to D21202: Added basic JavaScript functions to support animated PDF.
Thu, May 16, 11:42 AM · Okular
joaonetto updated the diff for D21202: Added basic JavaScript functions to support animated PDF.

Loops now use const and more efficient way of acessing LinkedList

Thu, May 16, 11:41 AM · Okular
knambiar added a comment to D21092: Okular Annotation: use the new signal-slot connect syntax.

Review D21238 created for the line start style.

Thu, May 16, 6:45 AM · Okular
knambiar requested review of D21238: Okular Annotation: add support for line start style for Straight Line tool.
Thu, May 16, 6:43 AM · Okular
pino added inline comments to D21202: Added basic JavaScript functions to support animated PDF.
Thu, May 16, 6:27 AM · Okular
anthonyfieroni added inline comments to D21202: Added basic JavaScript functions to support animated PDF.
Thu, May 16, 5:54 AM · Okular
sander added inline comments to D21202: Added basic JavaScript functions to support animated PDF.
Thu, May 16, 4:53 AM · Okular

Wed, May 15

joaonetto updated the diff for D21202: Added basic JavaScript functions to support animated PDF.

Removed useless iterator

Wed, May 15, 10:19 PM · Okular
aacid added inline comments to D21202: Added basic JavaScript functions to support animated PDF.
Wed, May 15, 10:06 PM · Okular
davidhurka added a comment to D21195: [RFC] Create a Change Colors menu (with toolbar button).

I have figured out, what was going on in the QToolButton.

Wed, May 15, 4:38 PM · Okular
davidhurka updated the diff for D21195: [RFC] Create a Change Colors menu (with toolbar button).
  • Toolbar button finally shows the intended menu
  • Add icon for Configure... action
  • Corrected action-slot connections
  • Named enable/disable action "Change Colors" again, looks better in the toolbar
Wed, May 15, 4:09 PM · Okular
davidhurka added a comment to D21195: [RFC] Create a Change Colors menu (with toolbar button).

I have added CheckableActionMenu, which cuts the default action connection between the KActionMenu itself and the toolbar button. Now it is possible to make the toolbar button checkable, but not the submenu.

Wed, May 15, 3:16 PM · Okular
GB_2 added inline comments to D21195: [RFC] Create a Change Colors menu (with toolbar button).
Wed, May 15, 3:00 PM · Okular
davidhurka updated the diff for D21195: [RFC] Create a Change Colors menu (with toolbar button).

Removed checkbox from submenu, but toolbar button invents other menu structure

Wed, May 15, 2:53 PM · Okular

Tue, May 14

davidhurka added a comment to D21195: [RFC] Create a Change Colors menu (with toolbar button).

The lambda looks much better, but it uses still int as action data, not Okular::SettingsCore::EnumRenderMode::type, which would make more sense. Is it possible to put Okular::SettingsCore::EnumRenderMode::type into the action’s QVariant? It didn’t work because I couldn’t register it as metatype.

Tue, May 14, 11:51 PM · Okular
davidhurka updated the diff for D21195: [RFC] Create a Change Colors menu (with toolbar button).
  • Renamed the menu entries to Color Mode and Enable Color Changing
  • Use lambda function instead of function-like macro
Tue, May 14, 11:40 PM · Okular
tobiasdeiminger closed D21136: Fix line annotation leader line angle.
Tue, May 14, 9:41 PM · Okular
aacid added a comment to D21136: Fix line annotation leader line angle.

it's a bugfix that doesn't seem to carry any danger, so 19.04 and then merge to master

Tue, May 14, 8:57 PM · Okular
tobiasdeiminger updated subscribers of D21136: Fix line annotation leader line angle.

@aacid Should this small fix land on Applications/19.04 branch, or master only?

Tue, May 14, 7:48 PM · Okular
joaonetto updated the summary of D21202: Added basic JavaScript functions to support animated PDF.
Tue, May 14, 1:36 PM · Okular
joaonetto updated the diff for D21202: Added basic JavaScript functions to support animated PDF.

Changed for to range based loops

Tue, May 14, 1:32 PM · Okular
tobiasdeiminger added a comment to D21092: Okular Annotation: use the new signal-slot connect syntax.

I'm afraid we'll have similar objections to the endStyle, though, specifically “PDF only” — would that be okay?

IMO it would be okay. Plus, with the help of Tobias maybe you can even teach Okular how to draw the start/end markers for non-pdf documents in a separate patch? I remember him saying that that is not very difficult.

Tue, May 14, 11:45 AM · Okular
sander added a comment to D21092: Okular Annotation: use the new signal-slot connect syntax.

I'm afraid we'll have similar objections to the endStyle, though, specifically “PDF only” — would that be okay?

Tue, May 14, 11:25 AM · Okular
knambiar added a comment to D21092: Okular Annotation: use the new signal-slot connect syntax.

@knambiar
Rajeesh, would you be around for another patch? PDF / poppler allow to draw arrows on both ends of a line (aka start style, end style). Your patches currently target only the line end. Would you implement "start style" in the UI too?

Tue, May 14, 10:48 AM · Okular
sander accepted D21136: Fix line annotation leader line angle.
Tue, May 14, 10:02 AM · Okular
davidre added inline comments to D21195: [RFC] Create a Change Colors menu (with toolbar button).
Tue, May 14, 7:22 AM · Okular
sander added inline comments to D21202: Added basic JavaScript functions to support animated PDF.
Tue, May 14, 3:56 AM · Okular
joaonetto updated the diff for D21202: Added basic JavaScript functions to support animated PDF.

Fixed copyright

Tue, May 14, 12:05 AM · Okular

Mon, May 13

joaonetto added reviewers for D21202: Added basic JavaScript functions to support animated PDF: aacid, Okular.
Mon, May 13, 11:56 PM · Okular
joaonetto requested review of D21202: Added basic JavaScript functions to support animated PDF.
Mon, May 13, 11:56 PM · Okular
davidhurka added a comment to D21195: [RFC] Create a Change Colors menu (with toolbar button).

That menu is ultra hard to understand, it's a checked action + menu with an action with the same name inside that is also a checked action

Mon, May 13, 10:04 PM · Okular
davidre added inline comments to D21195: [RFC] Create a Change Colors menu (with toolbar button).
Mon, May 13, 9:11 PM · Okular
aacid added a comment to D21195: [RFC] Create a Change Colors menu (with toolbar button).

That menu is ultra hard to understand, it's a checked action + menu with an action with the same name inside that is also a checked action

Mon, May 13, 9:04 PM · Okular
davidhurka added a comment to D21195: [RFC] Create a Change Colors menu (with toolbar button).

Screenshots are appreciated when submitting patches that change or add UI elements. :)

https://community.kde.org/Infrastructure/Phabricator#Include_some_screenshots

Mon, May 13, 6:48 PM · Okular
davidhurka added a comment to D21196: [RFC] Move Continuous option to View Mode submenu.

Nate suggested almost exactly this patch in Bug 407326. But instead of hiding Continuous when accessed from the menubar, I moved Continuous completely to the View Mode submenu.

Mon, May 13, 6:47 PM · Documentation, Okular
davidhurka added a comment to D21195: [RFC] Create a Change Colors menu (with toolbar button).

Okular does not follow the KDELibs coding style, so I tried to follow the existing coding style. Maybe I didn’t understand something right, if so, please correct me.

Mon, May 13, 6:36 PM · Okular
davidhurka updated the summary of D21195: [RFC] Create a Change Colors menu (with toolbar button).
Mon, May 13, 6:11 PM · Okular
davidhurka updated the summary of D21196: [RFC] Move Continuous option to View Mode submenu.
Mon, May 13, 6:04 PM · Documentation, Okular
davidhurka requested review of D21196: [RFC] Move Continuous option to View Mode submenu.
Mon, May 13, 5:56 PM · Documentation, Okular
ngraham added a comment to D21195: [RFC] Create a Change Colors menu (with toolbar button).

Screenshots are appreciated when submitting patches that change or add UI elements. :)

Mon, May 13, 5:53 PM · Okular
davidhurka requested review of D21195: [RFC] Create a Change Colors menu (with toolbar button).
Mon, May 13, 5:47 PM · Okular

Sun, May 12

tobiasdeiminger added a comment to D21092: Okular Annotation: use the new signal-slot connect syntax.

@knambiar
Rajeesh, would you be around for another patch? PDF / poppler allow to draw arrows on both ends of a line (aka start style, end style). Your patches currently target only the line end. Would you implement "start style" in the UI too?

Sun, May 12, 7:42 PM · Okular
aacid closed D21092: Okular Annotation: use the new signal-slot connect syntax.

commited, somehow phabricator decided not to autoclose this

Sun, May 12, 7:05 PM · Okular
aacid accepted D21092: Okular Annotation: use the new signal-slot connect syntax.
Sun, May 12, 8:45 AM · Okular

Sat, May 11

knambiar updated the diff for D21092: Okular Annotation: use the new signal-slot connect syntax.

Drop the combobox change

Sat, May 11, 8:26 AM · Okular

Fri, May 10

tobiasdeiminger updated the summary of D21136: Fix line annotation leader line angle.
Fri, May 10, 11:53 PM · Okular
tobiasdeiminger requested review of D21136: Fix line annotation leader line angle.
Fri, May 10, 11:48 PM · Okular
aacid added inline comments to D21092: Okular Annotation: use the new signal-slot connect syntax.
Fri, May 10, 8:06 PM · Okular
knambiar updated the diff for D21092: Okular Annotation: use the new signal-slot connect syntax.

Use QOverload instead of static_cast

Fri, May 10, 8:47 AM · Okular

Thu, May 9

aacid added a comment to D21092: Okular Annotation: use the new signal-slot connect syntax.

please use QOverload<int>::of() instead of static_cast<void (QComboBox::*)(int)> much easier to read.

Thu, May 9, 10:17 PM · Okular
tobiasdeiminger added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.

There's a few #ifdef HAVE_POPPLER_mm_nn checks in the code, may be we could adapt it for 0.72?

Thu, May 9, 9:19 AM · Okular
knambiar added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.

There's another problem we haven't discussed yet: Line endings work only if you have poppler >= 0.72 installed, else they will be silently ignored. Version 0.72 is quite recent, a lot of people won't have it because their distro ships an older version. Should we try to handle this? If yes, how? We can use cmake to detect poppler version, but I don't see an easy way to propagate the information from generator to UI at runtime.

Thu, May 9, 8:53 AM · Okular
sander closed D21069: [RFC] Improve documentation of Document::setPageTextSelection().
Thu, May 9, 8:50 AM · Okular
tobiasdeiminger added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.

What would be a better alternative?

Thu, May 9, 7:51 AM · Okular
knambiar added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.

Please fix the connect to use the new connect syntax,

Thu, May 9, 6:14 AM · Okular
knambiar requested review of D21092: Okular Annotation: use the new signal-slot connect syntax.
Thu, May 9, 6:12 AM · Okular

Wed, May 8

aacid accepted D21069: [RFC] Improve documentation of Document::setPageTextSelection().
Wed, May 8, 11:13 PM · Okular
aacid added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.

I can't go on holiday it seems, you sneak things past me :D

Wed, May 8, 11:04 PM · Okular
davidhurka added a reviewer for D21069: [RFC] Improve documentation of Document::setPageTextSelection(): Okular.
Wed, May 8, 7:48 PM · Okular

Tue, May 7

ngraham added a comment to D20437: Make selection scrolling go at 60 fps.

Thanks, I've added your preferences there.

Tue, May 7, 5:50 PM · Okular
kezik added a comment to D20437: Make selection scrolling go at 60 fps.

@aacid I put myself in the kde dev script relicense thing, so please look at the patch without getting tainted

Tue, May 7, 3:33 PM · Okular
knambiar added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.

I committed the patch, but without any icons at all. Even without them I think the patch is very helpful. The icons can now be added at ease in a separate patch.

Rajeesh, thanks for the patch. I'd be happy to see more of your patches in the future.

Tue, May 7, 12:54 PM · Okular
davidhurka added a comment to D21069: [RFC] Improve documentation of Document::setPageTextSelection().

I suggested this in D18744#441906.

Tue, May 7, 11:13 AM · Okular
davidhurka requested review of D21069: [RFC] Improve documentation of Document::setPageTextSelection().
Tue, May 7, 10:49 AM · Okular
sander added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.

I committed the patch, but without any icons at all. Even without them I think the patch is very helpful. The icons can now be added at ease in a separate patch.

Tue, May 7, 9:10 AM · Okular
sander closed D20760: Okular Annotation: add support for line ending style for Straight Line tool.
Tue, May 7, 9:07 AM · Okular

Mon, May 6

mlaurent added a comment to D20832: Fix some clazy warning.

Ok albert send me an email in private :)
he will look at it in several days :)
tha,ks :)

Mon, May 6, 2:52 PM · Okular