Please also add the versioning data to the appdata file (maybe also add the information for the previous version this time):
https://community.kde.org/ReleasingSoftware#Versioning_in_AppStream_files
- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Aug 7 2019
@yurchor, this was fast! Thanks!
Please review by August 10, EOD. Thanks!
Aug 5 2019
The new code works using Kubuntu 18.04 and 19.04. Krusader behaves as expected when it's asked to be closed:
- when its internal editor is not used,
- when its internal editor has a file that is not saved,
- when its internal editor has a file that is not saved and the computer is asked to reboot.
Aug 4 2019
the target audience of Krusader are more advanced users
If any developer is reading this, he'll probably know that those developments end up being a very complex subject. Thank you for all the source code, Alex!
I'm unsure about this. In contrast to Dolphin the target audience of Krusader are more advanced users. We should have more confidence in them imo. On the other hand a confirmation doesn't hurt...
Okay, I'm not against adding comments:)
Ah, FileItem::isDir() can also return true for symlinks. Thanks again for fixing the bug i introduced, Toni!
Hmm, when looking at my commit I cannot say what caused setting the "current" item before.
Anyway, thanks for fixing Toni!
Aug 2 2019
Aug 1 2019
Minor changes were performed.
I think the same, Nikita, and thanks for testing and informing!
I agree with you, Nikita. Thanks for testing and all the information!
Jul 31 2019
It's a useful feature for people that like to keep their environment clean. Thanks for working on this, Toni!
If you'd like this fix to be included in v2.7.2, please push it to master by Aug 4 and I'll backport to stable. Please don't forget to specify BUG, FIXED, Differential Revision tags in the commit message.
If you'd like this fix to be included in v2.7.2, please push it to master by Aug 4 and I'll backport to stable. Please don't forget to specify BUG, FIXED, Differential Revision tags in the commit message.
Jul 30 2019
The new files were updated (copyright years were changed).
Jul 29 2019
This is the new version of the source code, after some minor improvements, having updated it because of the changes to the source code that have happened since the last time (like in krsearchdialog.cpp), and having used daily the classes meanwhile.
Jul 28 2019
It works properly now - thanks!
I checked the commit you mentioned in the bug. Before it the checkbox was still ignored but the links were always not followed.
It works and I'm fine with the proposed fix. Thanks Toni!
Jul 27 2019
Jul 23 2019
(optional) I'd use QFontMetrics::horizontalAdvance(A) and QFontMetrics::width(A) for additional type check.
Jul 22 2019
Thanks Davide! It's cleaner and macro name is good. No issues with fonts were discovered when I tested.
Jul 21 2019
No objections
Changed with macro, as suggested by @nmel; the code now is cleaner (and QFONTMETRICS_HORIZONTAL_ADVANCE seems a bit long)
Thanks for testing again!
Thanks for testing everyone!
If you'd like this fix to be included into v2.7.2, please merge by the end of the month.
If you'd like this fix to be included into v2.7.2, please merge by the end of the month.
It's an improvement. Thanks!
Jul 20 2019
It works fine but please fix coding style before pushing your changes. Thanks!
I agree we can substitute the width method with the horizontalAdvance, however I propose we use compat.h to eliminate code duplication here.
Thanks for checking, Davide! :)
Jul 19 2019
The new code works using Kubuntu 18.04. Although the final behavior of Synchronizer is not perfect, the patch improves the current situation, therefore: thanks, Alex! (and Yuri :-) )
Jul 18 2019
The new code works as expected using Kubuntu 18.04. Thanks, Alex! (and Yuri and Nikita :-) )
@yurchor : I follwed the guidelines from the documentation (https://doc.qt.io/qt-5/qfontmetrics-obsolete.html#width); I haven't tried to see where the difference really is, I think there could be some pixel overlapped or some extra space.
Isn't it be easier to use boundingRect(text).width() as a replacement of horizontalAdvance(text) which does not require Qt 5.11 and is not deprecated?
Looking at Qt, all the new methods are present in version 5.9 so that no checks with preprocessor are needed.
Jul 17 2019
Jul 13 2019
Tested on Fedora 30; it compiles and the bug is not present anymore; during the same test, a Krusader version without this patch was having this problem while the patched one was able to rename the file.
Reminder for git push :)
Jul 3 2019
Works fine for me (3-day testing). Thanks.
Jul 1 2019
Reviewed the code and tested — everything is great!
Jun 30 2019
Tested to work as expected.
Jun 16 2019
Forgot to add the reference to this revision in the commit message, closed with Shortcuts to move tab
Jun 14 2019
New revision is also good - feel free to push to master.
Jun 9 2019
Removed the single tab check in favor of a comment, like proposed by @abika
Jun 2 2019
@gengisdave : A comment would be nice. Thanks.
May 29 2019
@abika : this is intentional to define that these two methods do nothing when the panel has just one tab, I can change them with a comment remarking this logic
May 25 2019
Looks good. Thanks for the improvement!
The new code works using Kubuntu 19.04. Other people can do their checks. Davide, using the same keys as Chromium, Firefox, Libreoffice Calc, etc. is a advantage. Thanks, Davide! (and Nikita :-) )
May 22 2019
May 21 2019
Tested to compile, install and work as expected.
May 5 2019
Thanks Nikita! Changes applied and pushed into maste.
- fixup! FileSystem: Fix using creation time from KIO as changed time (ctime)
Apr 27 2019
Thanks for the fix and refactoring, Alex! Compiles and works as expected. Please check my inline comments.
Apr 22 2019
Apr 15 2019
Thank you, Yuri and Alex!
Apr 13 2019
After rethinking this, I agree with you, Nikita. We should not impose the burden of supporting an outdated Qt version on ourself.
Apr 10 2019
Apr 8 2019
QOverload is only available in Qt >= 5.7, and Qt 5.9 is the earliest supported version.
See also https://bugs.kde.org/show_bug.cgi?id=405212 .
I proposed this change in the discussion of D19623 and there were no objections for a month.