This thing bugs me for a while, and now I finally have a chance to fix it. I think it's a regression from previous versions because I remember my frustration when it was introduced. According to the related bug, it should be before v2.4.0-beta1, but I don't have any really old versions installed. Toni, you mentioned an old VM with an old Krusader on it — can you check, please?

Thank you all! For my part, using Kubuntu 18.04: my performed tests went alright; some files (inside an iso file) that could not be seen, now can be seen correctly. Other people can do their checks.

Added more people explicitly - guys, what's your opinion on this subject and do you know if the behavior is changed intentionally or not?

Note: The tag "Krusader" was added to the present differential revision so that it's seen now at least in https://phabricator.kde.org/project/view/79/ and https://phabricator.kde.org/tag/krusader/ , and consequently more people may review this proposal.

Nice! There's more information in https://phabricator.kde.org/D13572

Was it changed for a reason?

I confirm that what Nikita tried doesn't work. Thanks, Nikita!

In D13499#277695, @asensi wrote:

I think the current behavior is useful as is, i.e. keep the search active unless the dir is changed. Let's discuss more and
consider implementing an option to keep current behavior.

Mmm... Krusader's behavior was that, after quicksearching a file, when pressing Return (or Enter), the search bar was hidden (like Total Commander or Double Commander) but after Krusader 2.4.0-beta3 the behavior was changed.

In D13497#277928, @abika wrote:

Deletion (== physical deletion OR moveToTrash) should be possible inside the virtual directories the normal way with the Delete key, F11, etc.. This has always been like that (or as far as i know Krusader), I only refactored the code.

Explanation, as this is my code:
The files()->isRoot() condition is intended. Virtual deletion is only possible when the current directory is the root of vfs:// containing virtual directories. Deletion (== physical deletion OR moveToTrash) should be possible inside the virtual directories the normal way with the Delete key, F11, etc.. This has always been like that (or as far as i know Krusader), I only refactored the code.

Also, using Krusader 2.4.0-beta3, when "files fed to list box" are deleted... they are physically deleted.

> Removal of items from virtual lists is not a very handful feature after all...

I think the current behavior is useful as is, i.e. keep the search active unless the dir is changed. Let's discuss more and
consider implementing an option to keep current behavior.

Thanks for testing, Toni!

I think the current behavior is useful as is, i.e. keep the search active unless the dir is changed. Let's discuss more and consider implementing an option to keep current behavior.
Also, why have you decided to apply only to Search mode? Following the logic regarding Total Commander, it uses Filter mode for its quicksearch. In addition, for Select + F8/Del it might be useful to hide the bar, as there is nothing remain to select, but I'm not sure if it's good in terms of consistency.

In D13497#277482, @yurchor wrote:

I might be wrong but I thought the idea was to remove physical files as well.
Removal of items from virtual lists is not a very handful feature after all...
Can somebody comment on this? Thanks in advance.

the physical files remained.

Many thanks, Nikita! For my part, my performed tests (using Kubuntu 18.04) went alright.

Hi Martin,

Please push this.

I tried to break as less things as possible. I have a little knowledge of i18n but I think that merging the text will require a new strings translation; from my point of view, translations magically appear when I compile. I can put a comment in the final commit to let others to know that it can be refactored.

If you need icons let me know

Hi Martin,
yes, I wanted to work on it and did already some refactoring a year ago but never published it. Now I did a fresh rebase and pushed it to synchronizer/rework. Unfortunately I stopped in the middle of the work and the current state is unfinished and not working.

Alex, I remember You wanted to do that. So if You still want, feel free to work on it :). If not, I'm going to dive in.

Thanks Davide and Toni.

Thanks! Davide's commit is available for viewing at https://commits.kde.org/krusader/eb60c734b940063f61064c5bcd25ae448b8aa610

Thank you for your interest, Safa. Patches are welcome :-)

For my part, my performed tests went also OK!

Just one minor suggestion: rename "Ugly message dialog on Compare by Content error" with "Fixed ugly message dialog on Compare by Content error" so others will know you haven't introduced anything ugly :)

For my part, my performed tests went alright!

Great, it works as expected. Thanks Davide!
BTW, I didn't know about this nice little feature. It is convenient.

Just one minor suggestion: rename "Ugly message dialog on Compare by Content error" with "Fixed ugly message dialog on Compare by Content error" so others will know you haven't introduced anything ugly :)

Thanks Davide. I'm fine with any of error and sorry.

Works as expected. Thanks! :)

I like this change, thanks Davide! I think ::sorry dialog is even better for this scenario but that's a matter of taste :).

Thanks!

• Fixed changelog links

Ben asked to not add the project to reviewers - adding active people manually.

I accept the proposal. Thanks, Yuri and Nikita!

I agree, too. Thanks, Yuri!

In D12753#259899, @yurchor wrote:

I meant that I just remove the generated index.docbook, not the translation POs. No harm to the translation. Just deactivate it on docs.kde.org and in the Krusader tarballs. Anybody who wants to update the translation can do this from the current point, then use the usual translation scripting to re-generate index.docbook.

I'll update this doc after the v2.7 release among some other things I found or will find.

In D12753#259895, @nmel wrote:

In D12753#259890, @yurchor wrote:

On the other hand, the current Brazilian Portuguese docs are old and cannot be fixed easily in situ, we can exclude it from translation (I can remove it from Subversion) if you need cleanness of the compilation process.

I checked the status of the pt_br docs by comparing with source doc change history in git. It appears they are about 2 years old (pre-2.5.0 time). They are outdated indeed. IMO, they should be dropped as unsupported and outdated otherwise the doc will hide new features and changes we put there. What others think?

Removing from SVN sounds a bit harsh. What if someone would like to pick the translation up? Can we just tag it as incomplete so that it won't be downloaded by the tarball script? BTW, I checked that if I just remove krusader-2.7.0/po/pt_BR/docs, the app compiles safely without the translation. Should we go this way? Yuri, please advise.

In D12753#259890, @yurchor wrote:

On the other hand, the current Brazilian Portuguese docs are old and cannot be fixed easily in situ, we can exclude it from translation (I can remove it from Subversion) if you need cleanness of the compilation process.

In D12753#259885, @nmel wrote:

Yuri, I've built a tarball for testing purposes yesterday. It compiles ok, however there are some localization warnings like

I/O warning : failed to load external entity "/usr/share/kf5/kdoctools/customization/xsl/pt-BR.xml"
No "pt_br" localization of "footer-doc-comment" exists; using "en".
No "pt_br" localization of "footer-doc-feedback" exists; using "en".
No "pt_br" localization of "footer-doc-teamname" exists; using "en".

The full output is here.
The tarball is here, sha1 f4c74c9b905ca576dbd74bfee1a9ba921f8affdb.

Can you check if it's easy to fix?

Yuri, I've built a tarball for testing purposes yesterday. It compiles ok, however there are some localization warnings like

Thanks for checking, guys!

In D12753#259663, @asensi wrote:

Check if anything else should be updated.

Thanks, Nikita! Maybe Yuri wants to change

doc-extras/ChangeLog

Except the doc changelog mentioned by Toni I haven't found any obvious missing pieces. Thanks Nikita!

Check if anything else should be updated.

The commit is available for viewing at https://commits.kde.org/websites/krusader-org/3d5726caeedc4fd544751202eb9e0f5930cfb218

Indeed. Maybe something like "Updated descriptions, author and thanks lists". This is what you did, isn't it?

In D12644#257086, @asensi wrote:

Some changes (proposed by Nikita Melnichenko) were made:

Could you please rephrase?

I've rephrased it, now it's longer but that doesn't matter a lot :-)

Thanks Toni for updating the website! I agree with the current state of this diff.

Some changes (proposed by Nikita Melnichenko) were made:

Closed because of https://commits.kde.org/krusader/6e9de699d94414dd58d0ffe1aec3dc142705eb1b

Ok!

Thanks for the updates, Toni!

Thanks for addressing my comments. :)

A reference to KDE Plasma 4 was changed.

Some specifics were removed, in order to improve e.g. the maintainability.

Awesome! Thanks Toni.

Thanks, Toni! :)

Two texts were changed to save time to some readers.

Two pages were created, and information was moved to those pages.