- Change string context
Feed Advanced Search
May 15 2020
May 15 2020
iasensio updated the diff for D29764: [kcm/kwinrules] Fix size properties not being stored.
apol added a comment to D29407: ScreenshotEffect: Use Service Property to authorize screenshot without confirmation.
Patch looks good to me overall.
broulik updated the test plan for D29775: [kcmkwin/kwinrules] Create RulesModel on demand.
apol updated the diff for D27788: Implement EGL_KHR_partial_update and EGL_EXT_swap_buffers_with_damage.
Do not allocate a full QRegion on every paint.
broulik requested review of D29775: [kcmkwin/kwinrules] Create RulesModel on demand.
iasensio added inline comments to D29764: [kcm/kwinrules] Fix size properties not being stored.
zzag added inline comments to D27788: Implement EGL_KHR_partial_update and EGL_EXT_swap_buffers_with_damage.
apol updated the diff for D27788: Implement EGL_KHR_partial_update and EGL_EXT_swap_buffers_with_damage.
Make sure the rects are always in the right coordinate space and properly scaled
ognarb updated the diff for D29772: Don't compare string with empty string.
Found another one
iasensio added inline comments to D29772: Don't compare string with empty string.
ognarb updated the diff for D29772: Don't compare string with empty string.
- reflect comment
broulik added inline comments to D29772: Don't compare string with empty string.
ognarb planned changes to D29772: Don't compare string with empty string.
broulik added inline comments to D29772: Don't compare string with empty string.
ognarb requested review of D29772: Don't compare string with empty string.
meven added a reviewer for D29407: ScreenshotEffect: Use Service Property to authorize screenshot without confirmation: zzag.
yurchor added inline comments to D29764: [kcm/kwinrules] Fix size properties not being stored.
zzag requested changes to D27788: Implement EGL_KHR_partial_update and EGL_EXT_swap_buffers_with_damage.
May 14 2020
May 14 2020
apol added a comment to D27788: Implement EGL_KHR_partial_update and EGL_EXT_swap_buffers_with_damage.
pinebook pro with 2x
apol updated the diff for D27788: Implement EGL_KHR_partial_update and EGL_EXT_swap_buffers_with_damage.
Address scaling
iasensio requested review of D29764: [kcm/kwinrules] Fix size properties not being stored.
apol requested review of D29763: Properly include private Qt5 targets.
apol updated the diff for D29684: Improve opengl debug messages.
As suggested by zzag
ngraham triaged T13158: Define a reference appearance and help users have a consistent experience of on-screen object sizes as Normal priority.
zzag added inline comments to D29684: Improve opengl debug messages.
zzag added inline comments to D29684: Improve opengl debug messages.
apol updated the diff for D29684: Improve opengl debug messages.
we were landing on \0 so we never reached \n
apol requested review of D29759: wayland_server: Improve debug message, reduce duplicates.
apol requested review of D29758: Fix TestXdgShellClient::testDesktopFileName.
apol added a comment to D29751: KWIN_DISABLE_SHORTCUTS: allow disabling registering kwin shortcuts.
An example is flatpak apps don't run because they can't find the portals dbus service which doesn't restart because it's running in the actual dbus instance.
ngraham requested review of D29755: Improve partial maximization strings.
I don't do it because it's harder to set up the IDE to have a wrapper. I'll address it in KDevelop.
zzag added a comment to D29751: KWIN_DISABLE_SHORTCUTS: allow disabling registering kwin shortcuts.
I don't have issues with keyboard shortcuts. Do you run kwin as dbus-run-session kwin_wayland?
davidedmundson added a comment to D29751: KWIN_DISABLE_SHORTCUTS: allow disabling registering kwin shortcuts.
Do you have a situation where you run nested but specifically don't want to run a new dbus-session?
apol requested review of D29751: KWIN_DISABLE_SHORTCUTS: allow disabling registering kwin shortcuts.
zzag added a comment to D29728: Fix org.telegram.desktop identification.
This change breaks an autotest
zzag added a comment to D29728: Fix org.telegram.desktop identification.
@apol Shouldn't we also backport this patch to Plasma/5.18?
zzag added a comment to D29728: Fix org.telegram.desktop identification.
Thank you for the fix.
davidedmundson added a comment to D29736: Revert "Improve partial maximization strings".
Note that the message freeze is today.
Heh, I also assume it used name, but judging from options.cpp that's very very clearly not the case. Sorry for not noticing.
zzag added a comment to D29736: Revert "Improve partial maximization strings".
bshah added a comment to D29736: Revert "Improve partial maximization strings".
Hm maybe writing kconf_update script could be nicer?
zzag updated the diff for D27861: [wayland] Rework xdg-shell implementation.
Update.
zzag added inline comments to D29736: Revert "Improve partial maximization strings".
broulik added inline comments to D29736: Revert "Improve partial maximization strings".
zzag added a comment to D29736: Revert "Improve partial maximization strings".
Note that the message freeze is today.
zzag requested review of D29736: Revert "Improve partial maximization strings".
zzag added inline comments to D29729: Improve partial maximization strings.
May 13 2020
May 13 2020
ngraham added inline comments to D29671: [kcmkwin/kwinoptions] Use text to describe maximize button actions.
ngraham requested review of D29729: Improve partial maximization strings.
apol requested review of D29728: Fix org.telegram.desktop identification.
meven added a comment to D29407: ScreenshotEffect: Use Service Property to authorize screenshot without confirmation.
I guess it is for 5.20.
meven updated the diff for D29702: Autotests: Add a test when relaunching a maximized cliend with BorderlessMaximizedWindows.
Review feedback
zzag added inline comments to D29702: Autotests: Add a test when relaunching a maximized cliend with BorderlessMaximizedWindows.
zzag added inline comments to D29702: Autotests: Add a test when relaunching a maximized cliend with BorderlessMaximizedWindows.
zzag added a comment to D29705: Correctly align natural layout in present windows.
Hmm, so we effectively deal with two coordinate spaces... rect / scale will map rect from the "area" coordinate space to the "bounds" coordinate space. rect * scale will map rect from the "bounds" coordinate space to "area" coordinate space.
meven updated the diff for D29702: Autotests: Add a test when relaunching a maximized cliend with BorderlessMaximizedWindows.
Improve test
The change is sound but the code looks terrible.
davidedmundson updated the diff for D29705: Correctly align natural layout in present windows.
whitespace
davidedmundson added a comment to D29705: Correctly align natural layout in present windows.
Arguably this line could be refactored, but it's already confusing enough to explain, so I tried to keep the diff simple.
davidedmundson requested review of D29705: Correctly align natural layout in present windows.
zzag added a comment to D29685: Grant keyboard focus to popups on popup.
It won't work since popup grabs form a "stack." When a popup is dismissed, the keyboard focus has to move to the parent popup.
zzag updated the diff for D27861: [wayland] Rework xdg-shell implementation.
Some refactoring.
May 12 2020
May 12 2020
zzag added inline comments to D29684: Improve opengl debug messages.
zzag added inline comments to D29684: Improve opengl debug messages.
apol added a comment to D29684: Improve opengl debug messages.
I'm expecting QDebug would handle it, I don't see why opengl would be giving us an empty debug message though.
victorr added a comment to D29413: [kcmkwin/kwinrules] Fix about data and translations.
Now added i18nd.
victorr added a comment to D29413: [kcmkwin/kwinrules] Fix about data and translations.
This commit is much better.
https://cgit.kde.org/kwin.git/commit/?id=65f611f7008c3f94febb2f202257a6bb50e2c38c
As I wrote earlier, only minor problems remain if configured through the window title.
See D29685.
cblack requested review of D29685: Grant keyboard focus to popups on popup.
zzag added inline comments to D29684: Improve opengl debug messages.