Differential D29702

Autotests: Add a test when relaunching a maximized cliend with BorderlessMaximizedWindows
ClosedPublic
Actions

Authored by meven on May 13 2020, 10:54 AM.

Details

Reviewers
zzag
davidedmundson
Group Reviewers
KWin
Commits
R108:c483e209feb1: Autotests: Add a test when relaunching a maximized cliend with…
Test Plan

Test pass

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.May 13 2020, 10:54 AM
Restricted Application added a project: KWin. · View Herald TranscriptMay 13 2020, 10:54 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
meven requested review of this revision.May 13 2020, 10:54 AM
zzag requested changes to this revision.May 13 2020, 11:11 AM
zzag added inline comments.
autotests/integration/maximize_test.cpp
228–230

We also need to create zxdg_toplevel_decoration_v1 and tell the compositor that we prefer server-side decorations.

244

We need to ack the configure event.

shellSurface->ackConfigure(configureRequestedSpy.last().at(2).value<quint32>());
246–247

Please check the geometry and the maximized state.

249

Use QVERIFY

This revision now requires changes to proceed.May 13 2020, 11:11 AM
meven updated this revision to Diff 82733.May 13 2020, 1:13 PM
meven marked 4 inline comments as done.

Improve test

zzag added inline comments.May 13 2020, 1:40 PM
autotests/integration/maximize_test.cpp
216

nitpick: Don't capitalize "less"

259

It's probably better to check the position as well.

QCOMPARE(client->frameGeometry(), QRect(0, 0, 1280, 1024));

meven updated this revision to Diff 82739.May 13 2020, 1:58 PM
meven marked 2 inline comments as done.

Review feedback

zzag accepted this revision.May 13 2020, 2:00 PM
This revision is now accepted and ready to land.May 13 2020, 2:00 PM
Closed by commit R108:c483e209feb1: Autotests: Add a test when relaunching a maximized cliend with… (authored by meven). · Explain WhyMay 13 2020, 2:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 82749

View Options

autotests/integration/maximize_test.cpp

Loading...