- User Since
- Dec 14 2016, 3:12 PM (185 w, 2 d)
Wed, Jun 17
I hope it's okay to just add it here as a comment:
Tobias Witt <firstname.lastname@example.org>
Sat, Jun 6
thanks for reviewing!
Hi, is there anybody who can help review?
May 30 2020
@ognarb thanks! It did not work out of the box, but it helped me make it run (I'm on arch linux and had to change the kirigami version to 2.4 and remove the usage of ImageColors to make it run)
Recently I got into the source code of Gwenview. I was missing a crop tool that allows arbitrary rotations. While a rough implementation in Gwenview was quite easy, I never solved all problems to also retain the old behavior, which is why I not yet committed it. However, after getting a deeper look into the codebase of Gwenview, I agree that several things could be refactored or rewritten, although I still like the application itself. If someone could review/help, I would spent some time on polish or adding some new features.
Personally, I am not a fan of mixing mobile and desktop applications as it is difficult to implement a good usability that works with touch, mouse and keyboard at the same time. A prominent example might be Adobe Lightroom which still fails to have a unified user interfaces that works for mobile and desktop devices.
However I the mookups look cool and also very much like the name Koko for an image application. Unfortunately I never worked with QML and I was not even able to start it (error message: module "org.kde.koko" is not installed :/ ). According to the git log there were nearly no new features added within the last two years, so I am not sure if replacing Gwenview would help to gain activity.
May 24 2020
Dec 21 2019
Dec 14 2016
Thanks for the fast fixes. The toolbar position and the drop action are working just fine. You're right about the statusbar, it is not based on QAction but on QWidgets. Therefor one would need to rewrite JobMenuAction into a JobMenuWidget. But since the toolbar position is at the buttom, it will work for me anyway.
Thanks for the great work and the new features!
I noticed a minor issue with the toolbar. Since I don't use toolbars very often, I tried to move the Job toolbar to the bottom of the window, but after I restarted Krusader it was always at the top again. I noticed the same behavior with the Main toolbar, so it might be due to KXMLGuiWindow.
Maybe it is even possible to add the progress bar and the play/pause button to the status bar like in KMail for those who do not use toolbars?
Another misbehavior I noticed is, when I drag a file to another panel using the shift (or an other) modifier, the file will be copied instead of moved. Since I had the same issue before the branch was merged to the master branch, I guess it is not related to the rework of vfs.