Fix undefined behavior by calling on almost destroyed object
ClosedPublic
Actions

Authored by sandsmark on Mar 27 2020, 1:51 PM.

Details

Reviewers

ngraham

Group Reviewers

Gwenview

Commits

Summary

Because mView is in the process of being destroyed we shouldn't try to touch it too much. Warning from ubsan:

runtime error: member call on address 0x606000118e80 which does not point to an object of type 'QAbstractScrollArea'

Test Plan

ubsan doesn't complain anymore, things work.

Repository

R260 Gwenview

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

sandsmark requested review of this revision.Mar 27 2020, 1:51 PM

sandsmark created this revision.

This revision is now accepted and ready to land.Apr 14 2020, 3:26 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			lib/thumbnailview/previewitemdelegate.cpp (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	78646			Mar 27 2020, 1:48 PM	★	★
Diff 2	80547	24e8811	R260:2f48c62670954b7e743f1fa264f32124775256c3	Apr 19 2020, 2:43 PM	★	★