BUG: 401154
Details
Details
- Reviewers
ngraham - Group Reviewers
Gwenview VDG - Commits
- R260:b76047f54134: Make using monitor color profile optional
Diff Detail
Diff Detail
- Repository
- R260 Gwenview
- Branch
- global_color-management_bugfix
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 26999 Build 27017: arc lint + arc unit
| app/advancedconfigpage.ui | ||
|---|---|---|
| 293 | Typically we phrase checkbox text in the affirmative (e.g. "Use monitor color correction profile"; or even "Respect monitor color correction profile") and then this would be checked by default. Also ideally this checkbox would have an explanatory label below it like the rendering intent radio buttons to. Not being very familiar with color correction, I have no idea what this checkbox does based on its current label. | |
Comment Actions
- Add better description for color correction setting
English is not my native but I hope the description si clearer now.
So, the idea is the user can choose if they want Gwenview to apply monitor and image color profiles, or only profile from image.
It probably can't be decided by Gwenview, because system-wide color correction might be applied by external software which can make monitor profile applied twice. On the other hand, if there's no system-wide color correction, but monitor profile is set in X11, then applying both gives correct results.
Also, this is my first time collaborating in any FOSS project and especially with KDE there's a lot of new things to watch out for, so kinda expect that I might do something wrong and don't hesitate to point it out.
Comment Actions
Just a few more changes required:
| app/advancedconfigpage.ui | ||
|---|---|---|
| 265 | you'll want to make this text small to match the other help text in the view. To do that, set the name property to something unique (e.g. applyProfileInImageFileHelpLabel and then add a line like so in configDialog.cpp: mAdvancedConfigPage.applyProfileInImageFileHelpLabel->setFont(QFontDatabase::systemFont(QFontDatabase::SmallestReadableFont)); | |
| app/generalconfigpage.ui | ||
| 10 ↗ | (On Diff #80394) | unrelated; revert changes to this file |
| app/imageviewconfigpage.ui | ||
| 10 ↗ | (On Diff #80394) | unrelated; revert changes to this file |