Feed Advanced Search

Fri, Nov 15

ngraham requested changes to D25111: Implement KMessageWidget to report import errors..

Thanks again for the patch!

Fri, Nov 15, 5:53 PM · Gwenview

Fri, Nov 8

ngraham added a comment to D25111: Implement KMessageWidget to report import errors..

Nice, will review soon.

Fri, Nov 8, 9:52 PM · Gwenview
bdevries requested review of D25224: Solve a bug which can happen with multiple files with the same name..
Fri, Nov 8, 9:44 PM · Gwenview
bdevries added inline comments to D24875: Importer: convert all file operations to allow remote URLs..
Fri, Nov 8, 9:17 PM · Gwenview
bdevries updated the diff for D24875: Importer: convert all file operations to allow remote URLs..

A few additional changes based on Nate's comments.

Fri, Nov 8, 9:16 PM · Gwenview
ngraham added a comment to D24875: Importer: convert all file operations to allow remote URLs..

Nice work. Just a few inline comments:

Fri, Nov 8, 4:09 PM · Gwenview
ngraham closed D25005: Fix image loading performance.
Fri, Nov 8, 3:03 PM · Gwenview
ngraham accepted D25005: Fix image loading performance.

Nice work.

Fri, Nov 8, 3:01 PM · Gwenview
hoffmannrobert added inline comments to D25005: Fix image loading performance.
Fri, Nov 8, 2:14 PM · Gwenview
hoffmannrobert updated the diff for D25005: Fix image loading performance.
  • Move connect to constructor
Fri, Nov 8, 2:11 PM · Gwenview
tommo added a comment to D25005: Fix image loading performance.

I've tested it and it works fine for me, thanks. One minor issue is noted below.

Fri, Nov 8, 1:30 PM · Gwenview

Tue, Nov 5

hoffmannrobert updated the summary of D25005: Fix image loading performance.
Tue, Nov 5, 8:57 AM · Gwenview

Mon, Nov 4

tommo added a comment to D25005: Fix image loading performance.

Ok. I would like to test this, will need a few days though.

Mon, Nov 4, 3:44 PM · Gwenview
hoffmannrobert updated the diff for D25005: Fix image loading performance.
  • Remove unnecessary include
Mon, Nov 4, 2:52 PM · Gwenview
hoffmannrobert added a comment to D25005: Fix image loading performance.

Thanks, I moved the reload() and added a signal readyForDirListerStart() to DocumentFactory, which is emitted when the document is loaded or failed. In ContextManager::setUrlToSelect() this signal is connected to the dirlister start.

Mon, Nov 4, 2:35 PM · Gwenview
hoffmannrobert updated the diff for D25005: Fix image loading performance.
  • Move reload(), add DocumentFactory::readyForDirListerStart()
Mon, Nov 4, 2:31 PM · Gwenview

Sun, Nov 3

ngraham added a reviewer for D25112: Allow users to disable bird view: Gwenview.
Sun, Nov 3, 2:51 PM · Gwenview
juchatycapelle added a comment to D25112: Allow users to disable bird view.

Thanks for the patch! The functionality seems to work fine. However it appears to cause a layout repression in the settings view

Sun, Nov 3, 9:23 AM · Gwenview

Sat, Nov 2

ngraham added a comment to D25112: Allow users to disable bird view.

Maybe it could be an option in the View menu? This seems like something people may want to toggle on and off with a keyboard shortcut (remembering the state from previous instances) rather than opening the settings dialog to enable/disable.

Sat, Nov 2, 8:45 PM · Gwenview
ndavis added a comment to D25112: Allow users to disable bird view.

I'm not necessarily opposed to this, but Gwenview's Image View settings page is already quite cluttered with options. I wonder if there is a better way to toggle this on or off. Perhaps the checkbox could be located in the toolbar below the image view, or in a new overflow menu button we could add on the right side of that toolbar.

Alternatively, if living in the Image View page makes the most sense, we should probably condense the view by replacing some or all of those multi-item radio buttons with comboboxes, which will save a lot of space.

Thoughts, VDG folks?

Sat, Nov 2, 8:36 PM · Gwenview
ngraham requested changes to D25112: Allow users to disable bird view.

Thanks for the patch! The functionality seems to work fine. However it appears to cause a layout repression in the settings view:

Sat, Nov 2, 7:56 PM · Gwenview
tommo added a comment to D25005: Fix image loading performance.

The same determination is done in LoadingDocumentImpl::init().

Sat, Nov 2, 10:57 AM · Gwenview
juchatycapelle requested review of D25112: Allow users to disable bird view.
Sat, Nov 2, 7:06 AM · Gwenview

Fri, Nov 1

bdevries requested review of D25111: Implement KMessageWidget to report import errors..
Fri, Nov 1, 10:50 PM · Gwenview

Thu, Oct 31

ngraham closed D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..
Thu, Oct 31, 8:31 PM · Gwenview
bdevries added a comment to D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..

No, nothing bad will happen. The importer will try to create a subfolder if needed. If it somehow doesn't succeed, it will result in a FileUtils::RenameFailed.
In that case the file will simply be skipped altogether. It will remain untouched on the source device, and it will also not be deleted if the user tells the importer to delete the imported files. Deleting is only done for successfully imported files.
I'm already working on the other patch. Luckily, it seems like it might be relatively simple to implement some basic UI warnings for failed items.

Thu, Oct 31, 6:58 PM · Gwenview
ngraham accepted D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..

All right no problem, we can do this in another patch.

Thu, Oct 31, 6:47 PM · Gwenview
bdevries added a comment to D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..

For traceability's sake, I would separate the proper error handling into a separate patch/commit.
It's completely missing at the moment, so it seems strange to mix it in with a "new feature".

Thu, Oct 31, 3:41 PM · Gwenview
ngraham added a comment to D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..

Register as FileUtils::RenameFailed if the subfolder cannot be created.

If the subfolder cannot be created, it will immediately register
as FileUtils::RenameFailed and no attempt to actually rename the
file will be made.
The FileUtils::RenameFailed handle can then later on be used to
warn the user about which files failed to import. (This is
currently not properly implemented.)

Thu, Oct 31, 3:34 PM · Gwenview

Wed, Oct 30

bdevries updated the diff for D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..

Register as FileUtils::RenameFailed if the subfolder cannot be created.

Wed, Oct 30, 3:33 PM · Gwenview
hoffmannrobert added a comment to D25005: Fix image loading performance.

The connects at ContextManager::setUrlToSelect() only work with the if (UrlUtils::urlIsFastLocalFile()) determination.

Wed, Oct 30, 11:52 AM · Gwenview
bdevries added a comment to D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..

You're absolutely right that there needs to be a GUI warning/report of some kind. However, the current importer does not have the infrastructure to handle this: it does nothing with failed imports (of any kind) except print a warning message to stdout. See e.g. the FIXME/warning on lines 208 and 255.

Wed, Oct 30, 10:40 AM · Gwenview

Tue, Oct 29

ngraham added a comment to D25005: Fix image loading performance.

That looks better, thanks. Not sure if it's the best place for the connect, but I'll leave that to Nate.

Another nit-pick from my side: In my opinion that if (UrlUtils::urlIsFastLocalFile()) should be removed. IIRC, Floopy devices, CDs and USB1.1 drives are considered to be "FastLocal". So, the else branch should become the only implementation... would also make testing simpler and better reproducible.

Tue, Oct 29, 4:54 PM · Gwenview
ngraham added inline comments to D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..
Tue, Oct 29, 4:52 PM · Gwenview
ngraham updated the summary of D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..
Tue, Oct 29, 4:50 PM · Gwenview
ngraham added a reviewer for D25005: Fix image loading performance: Gwenview.
Tue, Oct 29, 4:02 PM · Gwenview
tommo added a comment to D25005: Fix image loading performance.

That looks better, thanks. Not sure if it's the best place for the connect, but I'll leave that to Nate.

Tue, Oct 29, 3:18 PM · Gwenview
hoffmannrobert added a comment to D25005: Fix image loading performance.

You are right, I changed it to use the signals from the document loaded (or not).

Tue, Oct 29, 11:54 AM · Gwenview
hoffmannrobert updated the diff for D25005: Fix image loading performance.
  • Start dirlister on document signals
Tue, Oct 29, 11:51 AM · Gwenview

Mon, Oct 28

bdevries added a comment to D24881: After import, change default action to "keep" instead of "delete"..

I'll certainly consider it.
Let's see if I can find the time. :-)

Mon, Oct 28, 9:58 PM · Gwenview
ngraham closed D24881: After import, change default action to "keep" instead of "delete"..
Mon, Oct 28, 9:51 PM · Gwenview
ngraham added a comment to D24881: After import, change default action to "keep" instead of "delete"..

PS: Taking a step back, there are other ways of handling this. Other existing photo importers (across OSes) use different UI approaches. I've seen a few that handle this as part of the settings, offering a choice: "always keep", "always delete", "always ask". Others offer a checkbox "delete after import" on the photo import selection dialog.

That makes sense to me!

Mon, Oct 28, 9:49 PM · Gwenview
ngraham accepted D24881: After import, change default action to "keep" instead of "delete"..
Mon, Oct 28, 9:48 PM · Gwenview
ngraham updated the summary of D24881: After import, change default action to "keep" instead of "delete"..
Mon, Oct 28, 9:44 PM · Gwenview
bdevries added a reviewer for D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater).: Gwenview.
Mon, Oct 28, 8:43 PM · Gwenview
bdevries requested review of D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..
Mon, Oct 28, 8:40 PM · Gwenview
bdevries updated the diff for D24881: After import, change default action to "keep" instead of "delete"..

Swap keep and delete buttons. This makes keep the default action.

Mon, Oct 28, 8:24 PM · Gwenview
tommo added a comment to D25005: Fix image loading performance.

make sure that an url passed on the command line is loaded and shown before the possibly long running dirlister

Mon, Oct 28, 2:49 PM · Gwenview
hoffmannrobert requested review of D25005: Fix image loading performance.
Mon, Oct 28, 1:44 PM · Gwenview

Sun, Oct 27

ngraham closed D24872: Replace mkdtemp by QTemporaryDir.
Sun, Oct 27, 11:51 PM · Gwenview
ngraham accepted D24872: Replace mkdtemp by QTemporaryDir.

Thanks!

Sun, Oct 27, 11:50 PM · Gwenview
ngraham added a comment to D24881: After import, change default action to "keep" instead of "delete"..

Having said that, it could make sense to just swap the button around, but then I would say the two options clash with the original intent of the dialog box: "keep" would map to "yes" and "delete" would map to "no".

Sun, Oct 27, 11:48 PM · Gwenview

Thu, Oct 24

bdevries set the repository for D24875: Importer: convert all file operations to allow remote URLs. to R260 Gwenview.
Thu, Oct 24, 8:31 PM · Gwenview
bdevries updated the diff for D24875: Importer: convert all file operations to allow remote URLs..

Add unit tests and solve bug when mulitiple files of same name exist.

Thu, Oct 24, 8:28 PM · Gwenview
bdevries updated the diff for D24875: Importer: convert all file operations to allow remote URLs..

Use QScopedPointer for QIODevice pointers

Thu, Oct 24, 2:47 PM · Gwenview
bdevries added a comment to D24881: After import, change default action to "keep" instead of "delete"..

The purpose of this dialog box is to ask the user what should be done with the original files on the source device that the photos were imported from. I.e. deleting them on the source device, e.g. the camera or smartphone. Only the photos that were imported successfully are then deleted from the source device (so not the ones that failed or were not selected to be imported).
BTW, the dialog box pops up after the import itself has been done.

Thu, Oct 24, 9:28 AM · Gwenview

Wed, Oct 23

ngraham added a comment to D24881: After import, change default action to "keep" instead of "delete"..

While this fixes the bug, I'm not quite sure it's the best way. Switching to KMessageBox::Dangerous seems inaccurate because even though there is indeed a dangerous action here, the dialog itself isn't about a dangerous action.

Wed, Oct 23, 3:23 PM · Gwenview
ngraham closed D24874: Fix temporary path in importer test unit.
Wed, Oct 23, 3:15 PM · Gwenview
bdevries added a reviewer for D24881: After import, change default action to "keep" instead of "delete".: Gwenview.
Wed, Oct 23, 8:50 AM · Gwenview
bdevries requested review of D24881: After import, change default action to "keep" instead of "delete"..
Wed, Oct 23, 8:48 AM · Gwenview
tommo added a comment to D24874: Fix temporary path in importer test unit.

Don't worry, Nate will apply it.

Wed, Oct 23, 7:30 AM · Gwenview
bdevries added a comment to D24874: Fix temporary path in importer test unit.

Since this is my first ever contribution to KDE: is there anything that I still need to do on my side? Or will this commit be applied without further intervention from me?

Wed, Oct 23, 6:58 AM · Gwenview

Tue, Oct 22

bdevries abandoned D24876: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..
Tue, Oct 22, 9:43 PM · Gwenview
bdevries requested review of D24876: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..
Tue, Oct 22, 9:43 PM · Gwenview
ngraham added a comment to D24874: Fix temporary path in importer test unit.

Sounds lovely, please go ahead!

Tue, Oct 22, 8:54 PM · Gwenview
bdevries added a comment to D24874: Fix temporary path in importer test unit.

Sure, my "git" email address is devriesb@gmail.com .

Tue, Oct 22, 8:52 PM · Gwenview
bdevries added a dependency for D24875: Importer: convert all file operations to allow remote URLs.: D24872: Replace mkdtemp by QTemporaryDir.
Tue, Oct 22, 8:48 PM · Gwenview
bdevries added a dependent revision for D24872: Replace mkdtemp by QTemporaryDir: D24875: Importer: convert all file operations to allow remote URLs..
Tue, Oct 22, 8:48 PM · Gwenview
bdevries requested review of D24875: Importer: convert all file operations to allow remote URLs..
Tue, Oct 22, 8:47 PM · Gwenview
ngraham accepted D24874: Fix temporary path in importer test unit.

Thanks! Can you provide your email address so I can commit this patch with correct attribution?

Tue, Oct 22, 8:38 PM · Gwenview
bdevries requested review of D24874: Fix temporary path in importer test unit.
Tue, Oct 22, 8:33 PM · Gwenview
bdevries requested review of D24872: Replace mkdtemp by QTemporaryDir.
Tue, Oct 22, 8:26 PM · Gwenview

Fri, Oct 18

aprcela added a comment to D24622: Proper numbering on first image in folder when using Fullscreen mode.

Searching and debugging and I just can't find the reason why.
So currently the counter works fine when the first image of a folder is opened and THEN one goes into fullscreen. But if one goes directly into fullscreen with the first image loaded, than it sets the counter to 0.

Fri, Oct 18, 10:44 PM · Gwenview
aprcela updated the diff for D24622: Proper numbering on first image in folder when using Fullscreen mode.

Removed comment that was used for the timer

Fri, Oct 18, 10:38 PM · Gwenview

Oct 16 2019

ngraham added a comment to D24622: Proper numbering on first image in folder when using Fullscreen mode.

Go ahead, take your time. :)

Oct 16 2019, 5:52 PM · Gwenview
aprcela added a comment to D24622: Proper numbering on first image in folder when using Fullscreen mode.

Did you mean to remove the timer in this patch?

Oct 16 2019, 5:48 PM · Gwenview
aprcela updated the diff for D24622: Proper numbering on first image in folder when using Fullscreen mode.

Remove timer. Use simple method call instead.

Oct 16 2019, 5:46 PM · Gwenview
ngraham added a comment to D24622: Proper numbering on first image in folder when using Fullscreen mode.

Did you mean to remove the timer in this patch?

Oct 16 2019, 5:22 PM · Gwenview
aprcela added a comment to D24622: Proper numbering on first image in folder when using Fullscreen mode.

Reverted the timer to 0.
Now it works when switching to fullscreen. Next step: make the counter work properly when -f for fullscreen is used.

Oct 16 2019, 10:57 AM · Gwenview
aprcela updated the diff for D24622: Proper numbering on first image in folder when using Fullscreen mode.

Revert timer and add additional updateDocumentCountLabel call

Oct 16 2019, 10:55 AM · Gwenview

Oct 15 2019

aprcela added a comment to D24622: Proper numbering on first image in folder when using Fullscreen mode.

And if updating the current index takes longer than 250 msec it would fail again, wouldn't it?

Probably, I can't get to that case where it's so slow. But I am aware that it can happen.

Oct 15 2019, 8:17 PM · Gwenview

Oct 14 2019

tommo added a comment to D24622: Proper numbering on first image in folder when using Fullscreen mode.

And if updating the current index takes longer than 250 msec it would fail again, wouldn't it?

Oct 14 2019, 4:31 PM · Gwenview

Oct 13 2019

apol added a comment to D24576: Don't link directly against Purpose for sharing.

I don't really understand. What Purpose dependency actually bothers you?

Oct 13 2019, 11:00 PM · Gwenview
aprcela requested review of D24622: Proper numbering on first image in folder when using Fullscreen mode.
Oct 13 2019, 10:38 PM · Gwenview
aprcela added a watcher for Gwenview: aprcela.
Oct 13 2019, 9:45 PM
davidedmundson added a comment to D17732: Respect animation settings.

Something like this I think should work:

Oct 13 2019, 2:32 AM · Gwenview
ngraham added reviewers for D24576: Don't link directly against Purpose for sharing: nicolasfella, apol.

This results in the purpose functionality disappearing even though I have Purpose installed.

Oct 13 2019, 2:23 AM · Gwenview
ngraham added a comment to D17732: Respect animation settings.

Please feel free to send a Plasma patch!

That was the plan, but I don't have a dev environment for plasma set up, and submitting patches that don't even compile is a bit embarrassing. :-)

But fixing that should fix animations in other Qt apps with custom widgets as well.

Oct 13 2019, 2:08 AM · Gwenview

Oct 12 2019

tommo added a comment to D24521: [RFC] Remove JpegContent class, replace with "Exiv2Content".

Oh, I didn't know about that, thx for the hint. Will see how it can be integrated.

Oct 12 2019, 1:00 PM · Gwenview

Oct 11 2019

sandsmark added a comment to D17732: Respect animation settings.

Please feel free to send a Plasma patch!

Oct 11 2019, 9:44 PM · Gwenview
sandsmark added a comment to D24521: [RFC] Remove JpegContent class, replace with "Exiv2Content".

Any reason not to use kexiv2?

Oct 11 2019, 9:42 PM · Gwenview
sandsmark updated the diff for D24576: Don't link directly against Purpose for sharing.
Oct 11 2019, 9:38 PM · Gwenview
sandsmark requested review of D24576: Don't link directly against Purpose for sharing.
Oct 11 2019, 9:34 PM · Gwenview
ngraham added a comment to D17732: Respect animation settings.

Please feel free to send a Plasma patch!

Oct 11 2019, 8:01 PM · Gwenview
sandsmark added a comment to D17732: Respect animation settings.

Something like this I think should work:

Oct 11 2019, 7:39 PM · Gwenview
sandsmark added a comment to D17732: Respect animation settings.

In fact we now have a shiny new global animation slider in the General Behavior KCM. If you change the patch to make Gwenview respect that setting, I'll be happy with it.

Do you know what that adjusts? If it adjusts the normal Qt animation hints/properties like QStyle::SH_Widget_Animation_Duration this patch Should Just Work™.

Oct 11 2019, 7:29 PM · Gwenview
sandsmark added a comment to D17732: Respect animation settings.

In fact we now have a shiny new global animation slider in the General Behavior KCM. If you change the patch to make Gwenview respect that setting, I'll be happy with it.

Oct 11 2019, 7:12 PM · Gwenview
sandsmark closed D24364: Fix crash with animations disabled.

Already fixed with another approach in master.

Oct 11 2019, 7:10 PM · Gwenview

Oct 9 2019

ngraham updated subscribers of D24521: [RFC] Remove JpegContent class, replace with "Exiv2Content".

Wow, a very ambitious change.

Oct 9 2019, 3:48 PM · Gwenview
tommo requested review of D24521: [RFC] Remove JpegContent class, replace with "Exiv2Content".
Oct 9 2019, 2:47 PM · Gwenview