Tracked with https://bugs.kde.org/show_bug.cgi?id=408551; no need for this to be open as well.

Marco has decided to take this over at https://invent.kde.org/graphics/gwenview/-/merge_requests/78

Not worth it.

And it's merged. :)

In D29886#676950, @ngraham wrote:

Thanks! However we are using GitLab now. Any chance you could close this and re-submit it as a merge request at https://invent.kde.org/graphics/gwenview/-/merge_requests/?

Thanks! However we are using GitLab now. Any chance you could close this and re-submit it as a merge request at https://invent.kde.org/graphics/gwenview/-/merge_requests/?

Cool, I'll close this now, and you can close D24521 once it's been migrated to Gitlab! :)

Ok guys, thanks for the feedback! I'll get my hands on again.

Hello tommo,
thanks for your work! I went through the change set and I didn't found a lot of things to improve. I never worked with exif, so I cannot say if it's good, but I could test it once it's on gitlab (I might also check if I get the same errors on unit tests). Besides, I'd suggest to split the change into two different patchsets, one for replacing JpegContent and another one for displaying the exif thumbnail.

In KDE, we have a saying: "those who do, decide."

I'd made two proposals for the new logo. What one of them I'll should submit as a merge request?

Looks great! Feel free to submit a merge request to the breeze-icons repo!

Updated license and metadata in file.

It's not a derivative. The icon was made from scratch. Circle-icons-eye.svg was taken as inspiration only.

Please note that the license that you base your work on is GPL while breeze icons is LGPL

Done in //invent.kde.org/graphics/gwenview/commit/9f9c9f45b605b11c2f3e22d3f9ff6eed77330bcd, sorry about that.

kf5 version is still not bumped.

Moved to https://invent.kde.org/graphics/gwenview/-/merge_requests/10

I hope it's okay to just add it here as a comment:
Tobias Witt <kde@amtare.eu>

Thanks! Can you provide an email address so we can land this with correct git authorship information?

thanks for reviewing!

Hi, is there anybody who can help review?

All good now, sorry for the wait.

Sorry to bother, what's the status of this review?

• make help text smaller
• stop editing unnecessary files

Just a few more changes required:

So sorry I missed your update to this patch! I will re-review.

Great job with this patch! May it be the first of many. :)

In D28480#650422, @ngraham wrote:

Right here in a comment. This will get a lot better with the GitLab migration in a few weeks. :)

In D28345#648241, @ngraham wrote:

Sorry for missing this.

• Add better description for color correction setting

In D28480#650304, @aichingm wrote:

In D28480#648568, @ngraham wrote:

Also, could you provide an email address we could use to land this with correct git authorship information?

I'm new to the phabricator workflow, where would i provide that information?

In D28480#648568, @ngraham wrote:

Also, could you provide an email address we could use to land this with correct git authorship information?

I'm new to the phabricator workflow, where would i provide that information?

Thanks for your patience here. I've had the same use case in the past and this is pretty much how I would implement it too. I just have one insignificant comment that could be addressed (see below).

Yup.

Sorry for missing this.

Whoops.

Again, fairly trivial, I hope.

This should be a fairly trivial and straightforward fix, fwiw. And without this and the other patches I can't really run gwenview with ubsan and asan.

And FWIW, after https://phabricator.kde.org/D28373 landed animations are smooth where they used to bother me, so this isn't really that important for me personally anymore. But being able to turn off animations (without cluttering the gwenview settings more) is nice anyways.

In D17732#638116, @davidedmundson wrote:

+        KSharedConfig::Ptr config = KSharedConfig::openConfig(QStringLiteral("kdeglobals"));

Just KSharedConfig::openConfig()

it'll include kdeglobals wihtout a reparse

In D24576#638063, @ngraham wrote:

I can still reproduce.

I have purpose installed from git master (like everything else KDE). The CMake log for Gwenview no longer even mentions Purpose at all. Console output says:

Now deleting the state in the destructor

Looks sane enough. Feel free to open a diff on Breeze and just tag Breeze as the reviewer. We'll take a look!

Stable branch

Land on the stable branch please!

Yikes. Much safer. Please also remove the "Be careful:" warning text for this option on the config dialog's advanced page, as it no longer applies.

I'm okay with having it off by default.

I can still reproduce.

In D17732#546317, @davidedmundson wrote:

Something like this I think should work:

It'd work, but I'd be reject it.

Breeze should be reading the global setting in kdeglobals, not the other way round.
Having KCMs write the same value in a quadrillion places doesn't scale and ends up being a mess.

But yes, making breeze / oxygen follow it is part of the plan for that patch.

You merge the stable branch to master, I guess, so I don't need to push it to master separately?

In D24576#546313, @ngraham wrote:

This results in the purpose functionality disappearing even though I have Purpose installed.

In D24576#546716, @apol wrote:

I don't really understand. What Purpose dependency actually bothers you?

It's just QtBase, KF5::ConfigCore and KF5::CoreAddons.

Commit to the stable branch please! (release/20.04)