Feed Advanced Search

Mon, Apr 8

volkov closed D20251: Drop unnecessary PaintUtils::containingRect().
Mon, Apr 8, 5:12 PM · Gwenview
volkov updated subscribers of D20251: Drop unnecessary PaintUtils::containingRect().

Well, actually, it was caught by @hetzenecker: https://phabricator.kde.org/D7581?id=22415#change-vIXPDUvyb3sZ

Mon, Apr 8, 5:12 PM · Gwenview
ngraham accepted D20251: Drop unnecessary PaintUtils::containingRect().

Nice catch!

Mon, Apr 8, 1:33 PM · Gwenview
volkov added a comment to D7581: HiDPI Support for Gwenview.

You are welcome!
I started to implement highdpi support from scratch, but then I found this change and it was a huge help!

Mon, Apr 8, 12:54 PM · Gwenview
volkov updated the diff for D20251: Drop unnecessary PaintUtils::containingRect().

re-target to master

Mon, Apr 8, 11:22 AM · Gwenview

Sun, Apr 7

hetzenecker added a comment to D7581: HiDPI Support for Gwenview.

Wow, it's so great to see this finally merged.
@volkov - a huge thank you that you took over this patch and for all the work you put in to finally resolve this.

Sun, Apr 7, 9:36 PM · Gwenview
ngraham closed D20267: Add HiDPI support for thumbnails.
Sun, Apr 7, 2:09 PM · Gwenview
ngraham accepted D20267: Add HiDPI support for thumbnails.
Sun, Apr 7, 2:01 PM · Gwenview

Sat, Apr 6

volkov updated the diff for D20267: Add HiDPI support for thumbnails.

small fixes

Sat, Apr 6, 9:34 AM · Gwenview

Fri, Apr 5

ngraham accepted D20267: Add HiDPI support for thumbnails.

Thanks, this looks perfect now.

Fri, Apr 5, 8:34 PM · Gwenview
ngraham updated the summary of D20267: Add HiDPI support for thumbnails.
Fri, Apr 5, 8:28 PM · Gwenview
volkov updated the diff for D20267: Add HiDPI support for thumbnails.

fixed

Fri, Apr 5, 6:59 PM · Gwenview
ngraham added a comment to D20267: Add HiDPI support for thumbnails.

Thanks for the patch!

Fri, Apr 5, 3:36 PM · Gwenview
volkov added a reviewer for D20267: Add HiDPI support for thumbnails: Gwenview.
Fri, Apr 5, 1:47 PM · Gwenview
volkov requested review of D20267: Add HiDPI support for thumbnails.
Fri, Apr 5, 1:46 PM · Gwenview

Thu, Apr 4

volkov added a reviewer for D20251: Drop unnecessary PaintUtils::containingRect(): Gwenview.
Thu, Apr 4, 3:13 PM · Gwenview
volkov requested review of D20251: Drop unnecessary PaintUtils::containingRect().
Thu, Apr 4, 3:12 PM · Gwenview
volkov closed D7581: HiDPI Support for Gwenview.
Thu, Apr 4, 2:41 PM · Gwenview
ngraham added a comment to D7581: HiDPI Support for Gwenview.

@volkov Go for it!

Thu, Apr 4, 1:32 PM · Gwenview
ngraham accepted D7581: HiDPI Support for Gwenview.
Thu, Apr 4, 1:16 PM · Gwenview
ngraham added a reviewer for D7581: HiDPI Support for Gwenview: Gwenview.
Thu, Apr 4, 1:16 PM · Gwenview
ngraham accepted D7581: HiDPI Support for Gwenview.
Thu, Apr 4, 1:15 PM · Gwenview
volkov updated the diff for D7581: HiDPI Support for Gwenview.

add a comment about turning off opacity effect

Thu, Apr 4, 12:11 PM · Gwenview

Wed, Apr 3

ngraham added a comment to D7581: HiDPI Support for Gwenview.

A surprisingly clean diff. Very nice.

Wed, Apr 3, 8:51 PM · Gwenview
volkov added a comment to D7581: HiDPI Support for Gwenview.

D9078 should fix thumbnails.

Wed, Apr 3, 4:11 PM · Gwenview
ngraham added a comment to D7581: HiDPI Support for Gwenview.

Nice to see this. It's definitely better than nothing, but HiDPI support for the thumbnails would be nice too. :)

Wed, Apr 3, 3:45 PM · Gwenview
volkov updated the diff for D7581: HiDPI Support for Gwenview.

turn off opacity effect for highdpi with Qt < 5.12.4

Wed, Apr 3, 3:26 PM · Gwenview
volkov added inline comments to D7581: HiDPI Support for Gwenview.
Wed, Apr 3, 11:16 AM · Gwenview

Tue, Apr 2

davidedmundson added inline comments to D7581: HiDPI Support for Gwenview.
Tue, Apr 2, 5:35 PM · Gwenview
volkov added a comment to D7581: HiDPI Support for Gwenview.

Currently there is a bug in Qt which makes QGraphicsOpacityEffect not working: https://codereview.qt-project.org/#/c/257946/

Tue, Apr 2, 5:06 PM · Gwenview
volkov updated the diff for D7581: HiDPI Support for Gwenview.

rebase + refactoring

Tue, Apr 2, 5:02 PM · Gwenview

Sat, Mar 23

aacid closed D19993: Fix -Wreturn-type warning for jpeg version check.
Sat, Mar 23, 5:05 PM · Gwenview
aacid accepted D19993: Fix -Wreturn-type warning for jpeg version check.

i'll land it in a minute

Sat, Mar 23, 5:03 PM · Gwenview
i.Dark_Templar requested review of D19993: Fix -Wreturn-type warning for jpeg version check.
Sat, Mar 23, 12:13 PM · Gwenview

Mar 16 2019

ngraham added a comment to D13901: Touch support for Gwenview.

No worries, and thanks for the attempt! Once they're in, that'll really help other QWidgets-based KDE apps.

Mar 16 2019, 8:52 PM · Gwenview
steffenh added a comment to D13901: Touch support for Gwenview.

I started to transfer the gestures to the framework, but I cannot promise anything.

Mar 16 2019, 5:41 PM · Gwenview
ngraham added a comment to D13901: Touch support for Gwenview.

I imagine by adding what's here into the framework first, and then later raising the Gwenview frameworks dependency high enough and using them from there framework.

Mar 16 2019, 4:18 PM · Gwenview
sander added a comment to D13901: Touch support for Gwenview.

Thanks for the patch. How is the gesture code going to get into KWidgetAddons now?

Mar 16 2019, 2:44 PM · Gwenview
ngraham closed D13901: Touch support for Gwenview.
Mar 16 2019, 10:52 AM · Gwenview
ngraham accepted D13901: Touch support for Gwenview.

Thanks so much for your patience on this. I think it's ready to land now!

Mar 16 2019, 10:51 AM · Gwenview

Mar 10 2019

steffenh updated the diff for D13901: Touch support for Gwenview.

Move the gestureEvent(QGestureEvent* event) and event(QEvent* event) functions from documentview.cpp and thumbnailview.cpp to the Touch class.
I think this is now ready to land.

Mar 10 2019, 8:46 AM · Gwenview

Mar 9 2019

ngraham added a comment to D13901: Touch support for Gwenview.

Hi @ngraham

+1 to adding gesture recognizers to KWidgetsAddons

I agree. @steffenh, any chance you'd be interested in that? Then, we could use these very nice gestures in Okular and Dolphin too. Since you've already done the hard work of de-duplicating the code and putting it into helper files, hopefully that shouldn't be too much effort, right?

https://cgit.kde.org/kwidgetsaddons.git

I was thinking over this in the last days, but I'm not sure my coding is up to the task. Perhaps after I have finished this patch I can try it.
But with this idea in the background, I'm beginning to complete remove the event and gestureEvent function in dokumentview.cpp and thumbnailview.cpp, and use the Signal / Slot mechanics from Qt .

Mar 9 2019, 4:18 PM · Gwenview
steffenh added a comment to D13901: Touch support for Gwenview.

+1 to adding gesture recognizers to KWidgetsAddons

I agree. @steffenh, any chance you'd be interested in that? Then, we could use these very nice gestures in Okular and Dolphin too. Since you've already done the hard work of de-duplicating the code and putting it into helper files, hopefully that shouldn't be too much effort, right?

https://cgit.kde.org/kwidgetsaddons.git

Mar 9 2019, 7:46 AM · Gwenview

Mar 3 2019

ngraham added a comment to D13901: Touch support for Gwenview.

+1 to adding gesture recognizers to KWidgetsAddons

Mar 3 2019, 9:24 PM · Gwenview
volkov added a comment to D13901: Touch support for Gwenview.

+1 to adding gesture recognizers to KWidgetsAddons

Mar 3 2019, 8:56 PM · Gwenview
steffenh updated the diff for D13901: Touch support for Gwenview.
  • move some of the duplicate code in documentview and thumbnailview to functions in touch and touch_helper
  • fix some typos
  • fix copyright
Mar 3 2019, 5:22 PM · Gwenview

Mar 2 2019

sandsmark added a comment to D17732: Respect animation settings.

As for the discussion above, I don't see how plasma-integration is relevant. It does control QStyleHints, but you're not using any of that.
Everything you use here comes from the QStyle which is all from Breeze.

Mar 2 2019, 7:40 PM · Gwenview

Feb 27 2019

ngraham added inline comments to D13901: Touch support for Gwenview.
Feb 27 2019, 2:18 PM · Gwenview
steffenh added inline comments to D13901: Touch support for Gwenview.
Feb 27 2019, 1:17 PM · Gwenview

Feb 24 2019

ngraham added a comment to D13901: Touch support for Gwenview.

Thanks, that makes sense. However, it might also make sense to add generic support for all of this into Qt itself, or at least into a KDE Framework (KWidgetsAddons maybe?). There are lots of other QWidgets-based KDE apps that could benefit from this stuff too! Dolphin and Okular immediately come to mind.

Feb 24 2019, 4:20 PM · Gwenview
steffenh added a comment to D13901: Touch support for Gwenview.

From a high level perspective, I share @rkflx's concern with the amount of duplicate code. ThumbnailView::viewportEvent() is almost entirely duplicate code from DocumentView::event(), for example. Can we refactor this into re-usable functions in touch or touch_helper or something?

I will have a look at this, perhaps I can move same code around.

Feb 24 2019, 7:12 AM · Gwenview

Feb 22 2019

ngraham closed D14583: [MainWindow] Navigate through mouse forward/back buttons.
Feb 22 2019, 4:41 PM · Gwenview
ngraham accepted D14583: [MainWindow] Navigate through mouse forward/back buttons.

Thanks, this works great now!

Feb 22 2019, 4:39 PM · Gwenview
anthonyfieroni updated the diff for D14583: [MainWindow] Navigate through mouse forward/back buttons.

Test now, i can't reproduce behavior mentioned above.

Feb 22 2019, 5:55 AM · Gwenview

Feb 21 2019

ngraham added a comment to D14583: [MainWindow] Navigate through mouse forward/back buttons.

If someone steal events it's not problem of the patch, similar patch as D15612 should be applied for that view.

Feb 21 2019, 9:58 PM · Gwenview
ngraham accepted D13901: Touch support for Gwenview.

Thanks @steffenh. I went back and re-tested everything and it all works *flawlessly* for me. Very impressive work. I really hope we can get it in for KDE Applications 19.04. I'll start on the code review:

Feb 21 2019, 7:35 PM · Gwenview
steffenh updated the diff for D13901: Touch support for Gwenview.

rebase

Feb 21 2019, 9:01 AM · Gwenview

Feb 20 2019

ngraham closed D19169: Compile tests files with enabled exceptions, required for exiv2 0.27.
Feb 20 2019, 4:22 PM · Gwenview
ngraham added a comment to D19169: Compile tests files with enabled exceptions, required for exiv2 0.27.

Oh no, you didn't do anything wrong at all. It's a Phabricator bug that your authorship information gets discarded when if you use git format-patch (Phab wants everyone to use arc; see https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist).

Feb 20 2019, 4:20 PM · Gwenview
tgurr added a comment to D19169: Compile tests files with enabled exceptions, required for exiv2 0.27.

Oh dear, sorry maybe I did something wrong uploading the git format patch. Timo Gurr <timo.gurr@gmail.com>.

Feb 20 2019, 12:01 PM · Gwenview
ngraham accepted D19169: Compile tests files with enabled exceptions, required for exiv2 0.27.

Thanks. Can you please provide your real name and email address so I can land your patch with correct authorship information?

Feb 20 2019, 3:56 AM · Gwenview

Feb 19 2019

tgurr requested review of D19169: Compile tests files with enabled exceptions, required for exiv2 0.27.
Feb 19 2019, 8:05 PM · Gwenview
ngraham closed D19121: Allow Gwenview to be able to open .kra (Krita) files.
Feb 19 2019, 3:40 PM · Gwenview
ngraham added a comment to D19121: Allow Gwenview to be able to open .kra (Krita) files.

Sweet, will add the dep in another patch.

Feb 19 2019, 3:33 PM · Gwenview
sitter accepted D19121: Allow Gwenview to be able to open .kra (Krita) files.

FTR: kra support comes from kimageformats plugins to qimage. so do other already listed mimetypes though - it's fine.

Feb 19 2019, 2:51 PM · Gwenview

Feb 18 2019

ngraham updated the diff for D19121: Allow Gwenview to be able to open .kra (Krita) files.

Rebase on current master

Feb 18 2019, 8:50 PM · Gwenview
volkov closed D19122: Set the same image mime types in all desktop files.
Feb 18 2019, 8:22 PM · Gwenview
ngraham accepted D19122: Set the same image mime types in all desktop files.

Clever! Works great.

Feb 18 2019, 5:32 PM · Gwenview
volkov added a comment to D18852: Add mime types for raw image formats to desktop file.

D19122

Feb 18 2019, 5:23 PM · Gwenview
volkov added a reviewer for D19122: Set the same image mime types in all desktop files: Gwenview.
Feb 18 2019, 5:23 PM · Gwenview
volkov requested review of D19122: Set the same image mime types in all desktop files.
Feb 18 2019, 5:23 PM · Gwenview
ngraham added a comment to D18852: Add mime types for raw image formats to desktop file.

Just noticed this: should similar support be added into gvpart.desktop too?

Feb 18 2019, 4:28 PM · Gwenview
ngraham updated the summary of D19121: Allow Gwenview to be able to open .kra (Krita) files.
Feb 18 2019, 4:20 PM · Gwenview
ngraham updated the test plan for D19121: Allow Gwenview to be able to open .kra (Krita) files.
Feb 18 2019, 4:00 PM · Gwenview
ngraham requested review of D19121: Allow Gwenview to be able to open .kra (Krita) files.
Feb 18 2019, 3:59 PM · Gwenview
volkov closed D18852: Add mime types for raw image formats to desktop file.
Feb 18 2019, 2:58 PM · Gwenview
ngraham accepted D18852: Add mime types for raw image formats to desktop file.
Feb 18 2019, 2:43 PM · Gwenview
volkov added a comment to D18852: Add mime types for raw image formats to desktop file.

ping

Feb 18 2019, 9:39 AM · Gwenview

Feb 13 2019

volkov updated the summary of D18852: Add mime types for raw image formats to desktop file.
Feb 13 2019, 2:46 PM · Gwenview

Feb 12 2019

volkov updated the diff for D18852: Add mime types for raw image formats to desktop file.

modify existing desktop file instead of installing a new one

Feb 12 2019, 5:30 PM · Gwenview

Feb 11 2019

ngraham added a comment to D13901: Touch support for Gwenview.

@steffenh thanks for your patience here, and I'm sorry this hasn't landed yet. Could you rebase it on current master please? I'll redouble my efforts to test and rustle up some code reviewers for you.

Feb 11 2019, 8:19 PM · Gwenview
volkov added a comment to D18852: Add mime types for raw image formats to desktop file.

Wouldn't it be better to add mime types to org.kde.gwenview.desktop during the build?
https://lxr.kde.org/ doesn't respond, so I can't find an example for now.

Feb 11 2019, 3:09 PM · Gwenview
ngraham requested changes to D18852: Add mime types for raw image formats to desktop file.
Feb 11 2019, 2:52 PM · Gwenview
ngraham added a comment to D18852: Add mime types for raw image formats to desktop file.

And the added gwenviewApplication_raw.desktop contains translations because it is just a modified copy of org.kde.gwenview.desktop.

Feb 11 2019, 2:51 PM · Gwenview
volkov added a comment to D18852: Add mime types for raw image formats to desktop file.

Gwenview supports these formats only when it is built with KDcraw.
I used the approach from okular: when okular is built with support for a set of formats, then a separate desktop file is installed for them.
And the added gwenviewApplication_raw.desktop contains translations because it is just a modified copy of org.kde.gwenview.desktop.

Feb 11 2019, 10:52 AM · Gwenview

Feb 9 2019

ngraham added a comment to D18852: Add mime types for raw image formats to desktop file.

Does Gwenview actually support all these file formats? If so, why can't we add their mimetypes to the pre-existing desktop file?

Feb 9 2019, 2:08 PM · Gwenview
pino added a comment to D18852: Add mime types for raw image formats to desktop file.

Please do not add the translations manually, as they are handled by scripty automatically.

Feb 9 2019, 2:06 PM · Gwenview
volkov added a reviewer for D18852: Add mime types for raw image formats to desktop file: Gwenview.
Feb 9 2019, 1:55 PM · Gwenview

Feb 8 2019

volkov requested review of D18852: Add mime types for raw image formats to desktop file.
Feb 8 2019, 2:55 PM · Gwenview

Feb 4 2019

shubham closed D18403: Create shortcut to focus navigator bar.
Feb 4 2019, 3:52 PM · Gwenview
ngraham accepted D18403: Create shortcut to focus navigator bar.
Feb 4 2019, 3:50 PM · Gwenview
shubham updated the diff for D18403: Create shortcut to focus navigator bar.

Use CTRL + SHIFT + R

Feb 4 2019, 3:25 PM · Gwenview
ngraham added a comment to D18403: Create shortcut to focus navigator bar.

No, I meant change the "rotate left" shortcut to ctrl++r.

Feb 4 2019, 3:19 PM · Gwenview
shubham updated the diff for D18403: Create shortcut to focus navigator bar.

Change rotate left action's default shortcut to CTRL + SHIFT + L

Feb 4 2019, 3:12 PM · Gwenview
ngraham added a comment to D18403: Create shortcut to focus navigator bar.

Nice can confirm that it works now. Perhaps we should change the "rotate left" shortcut to ctrl++r?

Feb 4 2019, 3:04 PM · Gwenview

Feb 2 2019

shubham added a comment to D18403: Create shortcut to focus navigator bar.

This version now works as expected, but now CTRL + L shortcut for replaceLocation action is an ambiguous shortcut with rotate left action. Please give me some suggestions, whether to change this shortcut or rotate left shortcut.

Feb 2 2019, 7:31 AM · Gwenview
shubham updated the diff for D18403: Create shortcut to focus navigator bar.

Fix connect error

Feb 2 2019, 7:28 AM · Gwenview
shubham retitled D18403: Create shortcut to focus navigator bar from Shortcut to focus navigator bar to Create shortcut to focus navigator bar.
Feb 2 2019, 7:03 AM · Gwenview
shubham updated the diff for D18403: Create shortcut to focus navigator bar.

Use mUrlNavigator

Feb 2 2019, 7:02 AM · Gwenview
shubham added a comment to D18403: Create shortcut to focus navigator bar.

@ngraham thanks for reply, btw can you also reply to my inline comment at 394, I think thats perfectly valid connect syntax, still error is seen.

Feb 2 2019, 5:28 AM · Gwenview