Feed Advanced Search

Mon, Jun 10

ngraham added a comment to D21468: [WIP/RFC] Use Purpose for sharing.

Friendly ping!

Mon, Jun 10, 8:50 PM · Gwenview

Sun, Jun 9

aacid added a comment to D16109: Get rid of QMetaObject::invokeMethod() with 'const char *member' arg.

Honestly i'd prefer if we wait for 5.10 and then use QMetaObject::invokeMethod instead of QTimer::singleShot.

Sun, Jun 9, 10:39 PM · Gwenview

Mon, Jun 3

ngraham added inline comments to D21406: Rename DeleteThumbnailCacheOnExit -> LowResourceUsageMode.
Mon, Jun 3, 3:41 PM · Gwenview

Sun, Jun 2

ngraham closed D21398: Correctly crop Sony's embedded thumbnails.
Sun, Jun 2, 9:23 PM · Gwenview
ngraham accepted D21398: Correctly crop Sony's embedded thumbnails.

Thanks!

Sun, Jun 2, 9:21 PM · Gwenview
tommo added inline comments to D21406: Rename DeleteThumbnailCacheOnExit -> LowResourceUsageMode.
Sun, Jun 2, 5:51 AM · Gwenview

Sat, Jun 1

ngraham added inline comments to D21406: Rename DeleteThumbnailCacheOnExit -> LowResourceUsageMode.
Sat, Jun 1, 10:08 PM · Gwenview
tommo added a comment to D21406: Rename DeleteThumbnailCacheOnExit -> LowResourceUsageMode.

Need to postpone this until end of June.

Sat, Jun 1, 11:46 AM · Gwenview
tommo updated the diff for D21398: Correctly crop Sony's embedded thumbnails.

Constness.

Sat, Jun 1, 11:44 AM · Gwenview

Tue, May 28

ngraham requested changes to D21468: [WIP/RFC] Use Purpose for sharing.

Spectacle also supports both. We could probably do the same here in the meantime. I'm fine with replacing the current toolbar button with this though; it's much more useful, and Kipi still gets its own menu. Please also add the new action's to the file menu, context menu, and Operations panel. That way it's still accessible for people who don't want it in the toolbar.

Tue, May 28, 9:15 PM · Gwenview
nicolasfella requested review of D21468: [WIP/RFC] Use Purpose for sharing.
Tue, May 28, 8:28 PM · Gwenview

Sun, May 26

ngraham added a dependency for D21407: Disable smoothing thumbnails in LowResourceUsageMode: D21406: Rename DeleteThumbnailCacheOnExit -> LowResourceUsageMode.
Sun, May 26, 3:55 PM · Gwenview
ngraham added a dependent revision for D21406: Rename DeleteThumbnailCacheOnExit -> LowResourceUsageMode: D21407: Disable smoothing thumbnails in LowResourceUsageMode.
Sun, May 26, 3:55 PM · Gwenview
ngraham requested changes to D21406: Rename DeleteThumbnailCacheOnExit -> LowResourceUsageMode.

By renaming the config name in gwenviewconfig.kcfg, you'll reset existing users' preferences. Whenever you want to rename a key in a config file, you need to ship a kconfig update script to update existing users' config files. Look at the contents of the kconf_update folder in the source tree for an example of an existing one. And here's the documentation: https://techbase.kde.org/Development/Tools/Using_kconf_update

Sun, May 26, 3:53 PM · Gwenview
ngraham added a comment to D21398: Correctly crop Sony's embedded thumbnails.

All of these new variables can be const

Sun, May 26, 3:43 PM · Gwenview

Sat, May 25

tommo added a comment to D21407: Disable smoothing thumbnails in LowResourceUsageMode.

...also a blurred thumbnail suggests that the image is defocused.

Sat, May 25, 3:39 PM · Gwenview
tommo updated the diff for D21406: Rename DeleteThumbnailCacheOnExit -> LowResourceUsageMode.
Sat, May 25, 3:37 PM · Gwenview
tommo updated the summary of D21406: Rename DeleteThumbnailCacheOnExit -> LowResourceUsageMode.
Sat, May 25, 3:36 PM · Gwenview
tommo requested review of D21407: Disable smoothing thumbnails in LowResourceUsageMode.
Sat, May 25, 3:36 PM · Gwenview
tommo requested review of D21406: Rename DeleteThumbnailCacheOnExit -> LowResourceUsageMode.
Sat, May 25, 3:34 PM · Gwenview
tommo added a comment to D21398: Correctly crop Sony's embedded thumbnails.

E.g.:

Sat, May 25, 12:49 PM · Gwenview
tommo requested review of D21398: Correctly crop Sony's embedded thumbnails.
Sat, May 25, 12:38 PM · Gwenview
tommo added a comment to D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.

I haven't checked which folder Gwenview actually tries to delete, but the thumbnails are stored in ~/.cache/thumbnails instead of ~/.thumbnails.

Sat, May 25, 3:32 AM · Documentation, Gwenview

Fri, May 24

cfeck added a comment to D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.

Regarding astyle, see https://cgit.kde.org/kde-dev-scripts.git/commit/?id=e93a28b3eb153695e8edb7ae259243b7b409a29d

Fri, May 24, 5:00 PM · Documentation, Gwenview
cfeck added inline comments to D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.
Fri, May 24, 4:55 PM · Documentation, Gwenview
ngraham closed D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.
Fri, May 24, 4:37 PM · Documentation, Gwenview
ngraham accepted D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.
Fri, May 24, 4:36 PM · Documentation, Gwenview
ngraham closed D21284: Accelerate thumnailgenerator when loading RAW files.
Fri, May 24, 3:52 PM · Gwenview
ngraham accepted D21284: Accelerate thumnailgenerator when loading RAW files.
Fri, May 24, 3:51 PM · Gwenview
ngraham closed D21285: Remove redundant QImage::loadFromData().
Fri, May 24, 3:47 PM · Gwenview
ngraham accepted D21285: Remove redundant QImage::loadFromData().
Fri, May 24, 3:46 PM · Gwenview
ngraham closed D21337: Do not re-use previously generated thumbnails in case of error.
Fri, May 24, 3:44 PM · Gwenview
tommo updated the diff for D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.

You guys really have to setup clang-format or astyle to automate those whitespace formatting issues, IMO.

Fri, May 24, 3:28 PM · Documentation, Gwenview
ngraham added a comment to D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.

Thanks, just one last little thing...

Fri, May 24, 3:07 PM · Documentation, Gwenview
ngraham retitled D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small from Use the embedded thumbnail for preview even if it's too small to Optionally use images' embedded thumbnails for greater performance, even if they're too small.
Fri, May 24, 3:04 PM · Documentation, Gwenview
tommo updated the diff for D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.

Fix unit test.

Fri, May 24, 8:45 AM · Documentation, Gwenview
tommo updated the diff for D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.

Sry, I missed that.

Fri, May 24, 5:55 AM · Documentation, Gwenview
ngraham added a comment to D21285: Remove redundant QImage::loadFromData().

It's on my to-do list, I'll take a look tomorrow!

Fri, May 24, 4:52 AM · Gwenview
ngraham accepted D21337: Do not re-use previously generated thumbnails in case of error.
Fri, May 24, 4:52 AM · Gwenview

Thu, May 23

ngraham added a comment to D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.

Thanks. To account for this behavioral change, I think we need to adjust the UI strings in the settings window as well. Did my suggestion above make sense?

Thu, May 23, 7:20 PM · Documentation, Gwenview
ngraham closed D21329: Correctly crop embedded thumbs for Canon JPEGs.
Thu, May 23, 7:06 PM · Gwenview
ngraham accepted D21329: Correctly crop embedded thumbs for Canon JPEGs.

Ahh whatever, this is fine as-is then.

Thu, May 23, 7:02 PM · Gwenview
tommo updated the diff for D21329: Correctly crop embedded thumbs for Canon JPEGs.
Thu, May 23, 2:45 PM · Gwenview
tommo updated the diff for D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.

Sry, I should really enable Kate's spell checking.

Thu, May 23, 6:58 AM · Documentation, Gwenview
tommo updated the summary of D21284: Accelerate thumnailgenerator when loading RAW files.
Thu, May 23, 6:49 AM · Gwenview
yurchor added a comment to D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.

Thanks in advance for fixing this minor typo.

Thu, May 23, 6:46 AM · Documentation, Gwenview
tommo updated subscribers of D21285: Remove redundant QImage::loadFromData().

@ngraham Missed?

Thu, May 23, 6:32 AM · Gwenview
tommo updated subscribers of D21284: Accelerate thumnailgenerator when loading RAW files.

@ngraham Missed?

Thu, May 23, 6:32 AM · Gwenview
tommo updated the diff for D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.

Docs updated. Need to apply https://phabricator.kde.org/D21329 first, to avoid conflict.

Thu, May 23, 6:30 AM · Documentation, Gwenview
tommo updated the diff for D21337: Do not re-use previously generated thumbnails in case of error.
Thu, May 23, 4:53 AM · Gwenview
tommo added inline comments to D21329: Correctly crop embedded thumbs for Canon JPEGs.
Thu, May 23, 4:49 AM · Gwenview

Wed, May 22

ngraham requested changes to D21337: Do not re-use previously generated thumbnails in case of error.

Perfect, thanks. Works fine and seems like an appropriate solution. Please fix a typo in the comment and then this is good to go!

Wed, May 22, 5:16 PM · Gwenview
ngraham added inline comments to D21329: Correctly crop embedded thumbs for Canon JPEGs.
Wed, May 22, 5:10 PM · Gwenview
ngraham added a comment to D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.

Counter-proposal: Only generate high resolution thumbs if the user cares to not throw them away when closing gwenview, that is when deleteThumbnailCacheOnExit() is set to false. If set to true, always use the embedded thumbnail regardless of its size.

Wed, May 22, 5:07 PM · Documentation, Gwenview
tommo added a comment to D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.

I really can't get used to high quality thumbnails. The problem with your approach is that it puts (IMO unnecessary) load on memory bus and CPU: First we would crawl through all files in the directory to quickly display the embedded thumbnail and in a second run we open and decode picture by picture just for generating nice high quality thumbs. This reminds me of https://bugs.kde.org/show_bug.cgi?id=331435

Wed, May 22, 4:48 PM · Documentation, Gwenview
tommo added inline comments to D21329: Correctly crop embedded thumbs for Canon JPEGs.
Wed, May 22, 4:36 PM · Gwenview
tommo added a comment to D21337: Do not re-use previously generated thumbnails in case of error.

I just followed the steps to repeat described in the bug, i.e. create an empty file: touch test.jpg

Wed, May 22, 4:29 PM · Gwenview
ngraham added a comment to D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.

I think blurry is better than pixellated.

Wed, May 22, 4:27 PM · Documentation, Gwenview
ngraham closed D21292: Remove orphaned member.
Wed, May 22, 3:31 PM · Gwenview
ngraham accepted D21292: Remove orphaned member.

Nice catch!

Wed, May 22, 3:29 PM · Gwenview
ngraham added inline comments to D21329: Correctly crop embedded thumbs for Canon JPEGs.
Wed, May 22, 3:26 PM · Gwenview
ngraham added a comment to D21337: Do not re-use previously generated thumbnails in case of error.

Thanks, this makes sense. Is there an easy way to force thumbnail generation to fail for an image to test this?

Wed, May 22, 3:24 PM · Gwenview
ngraham closed D21333: Update copyright year to 2019.
Wed, May 22, 1:15 PM · Gwenview
ngraham accepted D21333: Update copyright year to 2019.
Wed, May 22, 1:15 PM · Gwenview
tommo added a watcher for Gwenview: tommo.
Wed, May 22, 11:55 AM
tommo updated the summary of D21337: Do not re-use previously generated thumbnails in case of error.
Wed, May 22, 11:52 AM · Gwenview
tommo requested review of D21337: Do not re-use previously generated thumbnails in case of error.
Wed, May 22, 11:43 AM · Gwenview
tommo requested review of D21333: Update copyright year to 2019.
Wed, May 22, 10:39 AM · Gwenview
tommo added a comment to D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.

P.S.: The unit test fails expectedly. However, I'd first like to get some feedback before fixing it.

Wed, May 22, 10:00 AM · Documentation, Gwenview
tommo set the repository for D21292: Remove orphaned member to R260 Gwenview.
Wed, May 22, 6:45 AM · Gwenview
tommo added inline comments to D21329: Correctly crop embedded thumbs for Canon JPEGs.
Wed, May 22, 5:49 AM · Gwenview
tommo added a comment to D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.

Attached is a screenshot demonstrating this suggestion. Even at 512px big thumbs, the embedded thumbnail (160x120) is big enough to get a rough idea of what's on the picture: A landscape, an animal, maybe which one? (not sure if you can tell the difference between a horse and a donkey, but IMO this isn't the purpose of a thumbnail preview anyway.)

Wed, May 22, 5:36 AM · Documentation, Gwenview
tommo requested review of D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.
Wed, May 22, 5:20 AM · Documentation, Gwenview
ngraham added inline comments to D21329: Correctly crop embedded thumbs for Canon JPEGs.
Wed, May 22, 4:53 AM · Gwenview
tommo updated the summary of D21329: Correctly crop embedded thumbs for Canon JPEGs.
Wed, May 22, 3:56 AM · Gwenview
tommo added a comment to D21329: Correctly crop embedded thumbs for Canon JPEGs.

Example Canon thumbnail attached:

Wed, May 22, 3:50 AM · Gwenview
tommo requested review of D21329: Correctly crop embedded thumbs for Canon JPEGs.
Wed, May 22, 3:49 AM · Gwenview

Tue, May 21

ngraham added a comment to D21260: Accelerate thumnailgenerator when loading JpegContent.

My bad, sorry. I should have done a closer code review. Fixed with 3a5cd96bfc92741e6fb6285b516934ffb76ae56f.

Tue, May 21, 6:31 PM · Gwenview
cfeck added a comment to D21260: Accelerate thumnailgenerator when loading JpegContent.

There are still code styling issues, but too late...

Tue, May 21, 5:38 PM · Gwenview
ngraham closed D21260: Accelerate thumnailgenerator when loading JpegContent.
Tue, May 21, 5:35 PM · Gwenview
ngraham accepted D21260: Accelerate thumnailgenerator when loading JpegContent.

Thanks very much!

Tue, May 21, 5:34 PM · Gwenview
tommo updated the diff for D21260: Accelerate thumnailgenerator when loading JpegContent.

Unit test fixed. Unfortunately I can't avoid QFile::readAll() entirely. When the same file is saved as the one already open through mem-mapping, we are in trouble when writing to that file: "It is unspecified whether modifications made to the file made after the mapping is created will be visible through the mapped memory." Apparently this might be the case and causes strange behavior when working with the input data later on. And I can't simply unmap the input data, as it may be needed for transformation. Thus postpone QFile::readAll() to JpegContent::save(). At least it speeds up the thumbnail generator.

Tue, May 21, 4:34 PM · Gwenview

Mon, May 20

ngraham requested changes to D21260: Accelerate thumnailgenerator when loading JpegContent.

Thanks very much! However this patch makes the jpegcontenttest crash. Looks like it needs some adjustment to account for your changes.

Mon, May 20, 7:25 PM · Gwenview

May 19 2019

tommo updated the diff for D21292: Remove orphaned member.
May 19 2019, 3:42 PM · Gwenview
tommo requested review of D21292: Remove orphaned member.
May 19 2019, 2:32 PM · Gwenview
tommo requested review of D21285: Remove redundant QImage::loadFromData().
May 19 2019, 9:40 AM · Gwenview
tommo updated the summary of D21284: Accelerate thumnailgenerator when loading RAW files.
May 19 2019, 8:36 AM · Gwenview
tommo updated the summary of D21284: Accelerate thumnailgenerator when loading RAW files.
May 19 2019, 8:33 AM · Gwenview
tommo updated the summary of D21284: Accelerate thumnailgenerator when loading RAW files.
May 19 2019, 8:33 AM · Gwenview
tommo requested review of D21284: Accelerate thumnailgenerator when loading RAW files.
May 19 2019, 8:32 AM · Gwenview
tommo updated the diff for D21260: Accelerate thumnailgenerator when loading JpegContent.

Typo.

May 19 2019, 3:58 AM · Gwenview
tommo updated the diff for D21260: Accelerate thumnailgenerator when loading JpegContent.

Use private mapping and handle nullptr.

May 19 2019, 3:49 AM · Gwenview

May 18 2019

cfeck added a comment to D21260: Accelerate thumnailgenerator when loading JpegContent.

Also, please use MapPrivate.

May 18 2019, 9:32 AM · Gwenview
cfeck added a comment to D21260: Accelerate thumnailgenerator when loading JpegContent.

Please handle possible nullptr result of QFile::map().

May 18 2019, 9:30 AM · Gwenview

May 17 2019

tommo requested review of D21260: Accelerate thumnailgenerator when loading JpegContent.
May 17 2019, 5:42 PM · Gwenview

May 16 2019

cfeck abandoned D4728: [Gwenview] Use url.fileName() to determine MIME type of remote URLs.
May 16 2019, 10:53 PM · Gwenview

May 15 2019

asturmlechner closed D21148: Fix build with exiv2-0.27.1.
May 15 2019, 8:40 PM · Gwenview
ngraham accepted D21148: Fix build with exiv2-0.27.1.
May 15 2019, 8:32 PM · Gwenview
ngraham closed D21161: Fix incomplete EXIF data for RAW files.
May 15 2019, 8:29 PM · Gwenview
ngraham added a comment to D21163: Ensure the loading indicator is actually displayed.

Please feel free to submit more patches. Most of us get by with arc, which is really quite nice once you get used to it, though I can understand how it would be annoying to install if you're only wanting to submit a few patches here or there.

May 15 2019, 8:26 PM · Gwenview