Feed Advanced Search

Thu, Jan 9

ngraham closed D26527: Fix divide-by-zero crash.
Thu, Jan 9, 5:09 PM · Gwenview
tommo added a comment to D26527: Fix divide-by-zero crash.

LGTM, thx!

Thu, Jan 9, 4:21 PM · Gwenview
ngraham added a reviewer for D26527: Fix divide-by-zero crash: tommo.
Thu, Jan 9, 3:29 PM · Gwenview
ngraham updated the diff for D26527: Fix divide-by-zero crash.

Also check prevWidth

Thu, Jan 9, 3:29 PM · Gwenview
ngraham added a comment to D26527: Fix divide-by-zero crash.

Good call!

Thu, Jan 9, 3:27 PM · Gwenview
tommo added a comment to D26527: Fix divide-by-zero crash.

Oh, good spot. I haven't considered malformed zero-size thumbnails, indeed.
In this case, you should also check for prevWidth > 0, otherwise scale
would become zero and we would have another div-by-zero.

Thu, Jan 9, 6:48 AM · Gwenview

Wed, Jan 8

ngraham closed D26507: Prevent drag & drop if left mouse button isn't pressed.
Wed, Jan 8, 6:24 PM · Gwenview
ngraham added a comment to D26507: Prevent drag & drop if left mouse button isn't pressed.

Thanks, that worked. I'm landing your patch now. Nice job, may it be the first of many!

Wed, Jan 8, 6:23 PM · Gwenview
tasossahanidis added a comment to D26507: Prevent drag & drop if left mouse button isn't pressed.

I was trying to avoid it, mostly due to possible spambot reasons, so I tried arc. If it still doesn't work, then I will post a comment with it. I'll be sure to use arc next time from the beginning. Apologies again.

Wed, Jan 8, 5:04 PM · Gwenview
tasossahanidis updated the diff for D26507: Prevent drag & drop if left mouse button isn't pressed.

Use arc to submit the patch

Wed, Jan 8, 5:02 PM · Gwenview
ngraham added a comment to D26507: Prevent drag & drop if left mouse button isn't pressed.

Just mention it in a comment here. For silly reasons, Phabricator disregards authorship in patches submitted using the web interface. It really wants you to use its arc command-line tool.

Wed, Jan 8, 4:51 PM · Gwenview
tasossahanidis added a comment to D26507: Prevent drag & drop if left mouse button isn't pressed.

Thanks for the patch! Works for me. Can you provide your email address so we can land it with correct authorship information?

Wed, Jan 8, 4:47 PM · Gwenview
tasossahanidis updated the diff for D26507: Prevent drag & drop if left mouse button isn't pressed.

Use git format-patch to hopefully add author information

Wed, Jan 8, 4:33 PM · Gwenview
ngraham added inline comments to D21398: Correctly crop Sony's embedded thumbnails.
Wed, Jan 8, 4:24 PM · Gwenview
ngraham updated the summary of D26527: Fix divide-by-zero crash.
Wed, Jan 8, 4:24 PM · Gwenview
ngraham requested review of D26527: Fix divide-by-zero crash.
Wed, Jan 8, 4:23 PM · Gwenview
ngraham accepted D26507: Prevent drag & drop if left mouse button isn't pressed.

Thanks for the patch! Works for me. Can you provide your email address so we can land it with correct authorship information?

Wed, Jan 8, 4:12 PM · Gwenview

Tue, Jan 7

tasossahanidis requested review of D26507: Prevent drag & drop if left mouse button isn't pressed.
Tue, Jan 7, 9:53 PM · Gwenview

Sun, Jan 5

dfaure abandoned D26348: Install the gwenview part into kf5/parts.

Dupe of D26349, not sure what happened

Sun, Jan 5, 7:16 PM · Gwenview

Sat, Jan 4

dfaure closed D26349: Install the gwenview part into kf5/parts, embed JSON metadata.
Sat, Jan 4, 9:58 AM · Gwenview
ngraham accepted D26349: Install the gwenview part into kf5/parts, embed JSON metadata.
Sat, Jan 4, 2:23 AM · Gwenview

Fri, Jan 3

dfaure updated the diff for D26349: Install the gwenview part into kf5/parts, embed JSON metadata.

rebase onto separated cleanup commit

Fri, Jan 3, 9:37 PM · Gwenview
ngraham added a comment to D26349: Install the gwenview part into kf5/parts, embed JSON metadata.

+1 to everything @kossebau said, then shipit

Fri, Jan 3, 6:34 AM · Gwenview

Thu, Jan 2

kossebau added a comment to D26349: Install the gwenview part into kf5/parts, embed JSON metadata.

Have not tested. Looks good code-wise, is what I would have done.

Thu, Jan 2, 8:10 PM · Gwenview

Wed, Jan 1

dfaure updated the diff for D26349: Install the gwenview part into kf5/parts, embed JSON metadata.

Also needs JSON metadata

Wed, Jan 1, 7:54 PM · Gwenview
dfaure requested review of D26349: Install the gwenview part into kf5/parts, embed JSON metadata.
Wed, Jan 1, 6:49 PM · Gwenview
dfaure requested review of D26348: Install the gwenview part into kf5/parts.
Wed, Jan 1, 6:47 PM · Gwenview

Fri, Dec 27

abcdjdj added a comment to D26230: Add button to toggle sidebar in fullscreen mode.

Very nice change, and very nice first patch! I love it when something like this is simple.

Fri, Dec 27, 6:03 AM · Gwenview

Thu, Dec 26

ngraham added a comment to D26230: Add button to toggle sidebar in fullscreen mode.

May it be the first of many. :)

Thu, Dec 26, 4:03 PM · Gwenview
ngraham closed D26230: Add button to toggle sidebar in fullscreen mode.
Thu, Dec 26, 4:03 PM · Gwenview
ngraham updated the summary of D26230: Add button to toggle sidebar in fullscreen mode.
Thu, Dec 26, 3:18 PM · Gwenview
ngraham accepted D26230: Add button to toggle sidebar in fullscreen mode.

Very nice change, and very nice first patch! I love it when something like this is simple.

Thu, Dec 26, 3:18 PM · Gwenview

Dec 26 2019

abcdjdj added a reviewer for D26230: Add button to toggle sidebar in fullscreen mode: ngraham.
Dec 26 2019, 10:39 AM · Gwenview
abcdjdj requested review of D26230: Add button to toggle sidebar in fullscreen mode.
Dec 26 2019, 9:59 AM · Gwenview

Dec 21 2019

twitt added a watcher for Gwenview: twitt.
Dec 21 2019, 9:47 PM
cfeck added inline comments to D21398: Correctly crop Sony's embedded thumbnails.
Dec 21 2019, 8:29 AM · Gwenview

Dec 3 2019

bdevries added a comment to D25111: Implement KMessageWidget to report import errors..

No problem.
I will follow up, as promised, with a patch to refactor the internationalization of the info/warning/error messages.

Dec 3 2019, 10:27 PM · Gwenview
nicolasfella closed D25693: Port away from deprecated DesktopIcon.
Dec 3 2019, 7:24 PM · Gwenview
nicolasfella updated the diff for D25693: Port away from deprecated DesktopIcon.
  • Use single arg fucntion
Dec 3 2019, 7:24 PM · Gwenview
ngraham requested changes to D25112: Allow users to disable bird view.

Thanks, looking better! When you edit app/gwenviewui.rc, you need to bump the version number that's at the top of the file. In addition, I added some inline comments that need to be addressed:

Dec 3 2019, 6:56 PM · Gwenview
ngraham closed D24875: Importer: convert all file operations to allow remote URLs.
Dec 3 2019, 6:43 PM · Gwenview
ngraham accepted D24875: Importer: convert all file operations to allow remote URLs.
Dec 3 2019, 6:37 PM · Gwenview
ngraham retitled D24875: Importer: convert all file operations to allow remote URLs from Importer: convert all file operations to allow remote URLs. to Importer: convert all file operations to allow remote URLs.
Dec 3 2019, 6:34 PM · Gwenview
ngraham closed D25224: Solve a bug which can happen with multiple files with the same name.
Dec 3 2019, 6:33 PM · Gwenview
ngraham retitled D25224: Solve a bug which can happen with multiple files with the same name from Solve a bug which can happen with multiple files with the same name. to Solve a bug which can happen with multiple files with the same name.
Dec 3 2019, 6:33 PM · Gwenview
ngraham accepted D25224: Solve a bug which can happen with multiple files with the same name.

Yep, makes sense, thanks!

Dec 3 2019, 6:26 PM · Gwenview
ngraham closed D25111: Implement KMessageWidget to report import errors..
Dec 3 2019, 6:22 PM · Gwenview
ngraham accepted D25111: Implement KMessageWidget to report import errors..

Yep, thanks. Sorry this patch has dragged on for so long. I'm landing it today!

Dec 3 2019, 6:22 PM · Gwenview
vkrause accepted D25693: Port away from deprecated DesktopIcon.
Dec 3 2019, 8:02 AM · Gwenview

Dec 2 2019

nicolasfella added a task to D25693: Port away from deprecated DesktopIcon: T11654: Deprecate SmallIcon/DesktopIcon/BarIcon/UserIcon/MainBarIcon and KDE::icon in favor of KIconLoader or QIcon API.
Dec 2 2019, 8:33 PM · Gwenview
nicolasfella requested review of D25693: Port away from deprecated DesktopIcon.
Dec 2 2019, 8:32 PM · Gwenview
nicolasfella closed D25675: Remove ContextBarButton.
Dec 2 2019, 11:41 AM · Gwenview
ngraham accepted D25675: Remove ContextBarButton.
Dec 2 2019, 3:09 AM · Gwenview
nicolasfella requested review of D25675: Remove ContextBarButton.
Dec 2 2019, 12:54 AM · Gwenview

Nov 23 2019

nicolasfella closed D25464: Remove unused include.
Nov 23 2019, 5:31 PM · Gwenview
cullmann accepted D25464: Remove unused include.
Nov 23 2019, 4:19 PM · Gwenview
juchatycapelle updated the diff for D25112: Allow users to disable bird view.

I took a little bit longer. I moved the option in the View menu. I still use the configuration to make the changes persistent.
The ViewMainPage class is in charge of handling the signals from the menu. It was necessary to do the initial handling on a top level view so that changes can be handled at any time, lower level views are not guaranted to be loaded.

Nov 23 2019, 5:44 AM · Gwenview

Nov 22 2019

bdevries added a comment to D25111: Implement KMessageWidget to report import errors..

Yes, sounds good.
The current patch is quite aligned with what the existing code is doing, so no modification should be required. This patch could then be used as-is.

Nov 22 2019, 9:25 PM · Gwenview
ngraham added inline comments to D25111: Implement KMessageWidget to report import errors..
Nov 22 2019, 6:14 PM · Gwenview
nicolasfella requested review of D25464: Remove unused include.
Nov 22 2019, 3:03 PM · Gwenview
bdevries added inline comments to D25111: Implement KMessageWidget to report import errors..
Nov 22 2019, 2:58 PM · Gwenview
bdevries updated the diff for D25111: Implement KMessageWidget to report import errors..

Internationalize strings.

Nov 22 2019, 2:48 PM · Gwenview

Nov 15 2019

ngraham requested changes to D25111: Implement KMessageWidget to report import errors..

Thanks again for the patch!

Nov 15 2019, 5:53 PM · Gwenview

Nov 8 2019

ngraham added a comment to D25111: Implement KMessageWidget to report import errors..

Nice, will review soon.

Nov 8 2019, 9:52 PM · Gwenview
bdevries requested review of D25224: Solve a bug which can happen with multiple files with the same name.
Nov 8 2019, 9:44 PM · Gwenview
bdevries added inline comments to D24875: Importer: convert all file operations to allow remote URLs.
Nov 8 2019, 9:17 PM · Gwenview
bdevries updated the diff for D24875: Importer: convert all file operations to allow remote URLs.

A few additional changes based on Nate's comments.

Nov 8 2019, 9:16 PM · Gwenview
ngraham added a comment to D24875: Importer: convert all file operations to allow remote URLs.

Nice work. Just a few inline comments:

Nov 8 2019, 4:09 PM · Gwenview
ngraham closed D25005: Fix image loading performance.
Nov 8 2019, 3:03 PM · Gwenview
ngraham accepted D25005: Fix image loading performance.

Nice work.

Nov 8 2019, 3:01 PM · Gwenview
hoffmannrobert added inline comments to D25005: Fix image loading performance.
Nov 8 2019, 2:14 PM · Gwenview
hoffmannrobert updated the diff for D25005: Fix image loading performance.
  • Move connect to constructor
Nov 8 2019, 2:11 PM · Gwenview
tommo added a comment to D25005: Fix image loading performance.

I've tested it and it works fine for me, thanks. One minor issue is noted below.

Nov 8 2019, 1:30 PM · Gwenview

Nov 5 2019

hoffmannrobert updated the summary of D25005: Fix image loading performance.
Nov 5 2019, 8:57 AM · Gwenview

Nov 4 2019

tommo added a comment to D25005: Fix image loading performance.

Ok. I would like to test this, will need a few days though.

Nov 4 2019, 3:44 PM · Gwenview
hoffmannrobert updated the diff for D25005: Fix image loading performance.
  • Remove unnecessary include
Nov 4 2019, 2:52 PM · Gwenview
hoffmannrobert added a comment to D25005: Fix image loading performance.

Thanks, I moved the reload() and added a signal readyForDirListerStart() to DocumentFactory, which is emitted when the document is loaded or failed. In ContextManager::setUrlToSelect() this signal is connected to the dirlister start.

Nov 4 2019, 2:35 PM · Gwenview
hoffmannrobert updated the diff for D25005: Fix image loading performance.
  • Move reload(), add DocumentFactory::readyForDirListerStart()
Nov 4 2019, 2:31 PM · Gwenview

Nov 3 2019

ngraham added a reviewer for D25112: Allow users to disable bird view: Gwenview.
Nov 3 2019, 2:51 PM · Gwenview
juchatycapelle added a comment to D25112: Allow users to disable bird view.

Thanks for the patch! The functionality seems to work fine. However it appears to cause a layout repression in the settings view

Nov 3 2019, 9:23 AM · Gwenview

Nov 2 2019

ngraham added a comment to D25112: Allow users to disable bird view.

Maybe it could be an option in the View menu? This seems like something people may want to toggle on and off with a keyboard shortcut (remembering the state from previous instances) rather than opening the settings dialog to enable/disable.

Nov 2 2019, 8:45 PM · Gwenview
ndavis added a comment to D25112: Allow users to disable bird view.

I'm not necessarily opposed to this, but Gwenview's Image View settings page is already quite cluttered with options. I wonder if there is a better way to toggle this on or off. Perhaps the checkbox could be located in the toolbar below the image view, or in a new overflow menu button we could add on the right side of that toolbar.

Alternatively, if living in the Image View page makes the most sense, we should probably condense the view by replacing some or all of those multi-item radio buttons with comboboxes, which will save a lot of space.

Thoughts, VDG folks?

Nov 2 2019, 8:36 PM · Gwenview
ngraham requested changes to D25112: Allow users to disable bird view.

Thanks for the patch! The functionality seems to work fine. However it appears to cause a layout repression in the settings view:

Nov 2 2019, 7:56 PM · Gwenview
tommo added a comment to D25005: Fix image loading performance.

The same determination is done in LoadingDocumentImpl::init().

Nov 2 2019, 10:57 AM · Gwenview
juchatycapelle requested review of D25112: Allow users to disable bird view.
Nov 2 2019, 7:06 AM · Gwenview

Nov 1 2019

bdevries requested review of D25111: Implement KMessageWidget to report import errors..
Nov 1 2019, 10:50 PM · Gwenview

Oct 31 2019

ngraham closed D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..
Oct 31 2019, 8:31 PM · Gwenview
bdevries added a comment to D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..

No, nothing bad will happen. The importer will try to create a subfolder if needed. If it somehow doesn't succeed, it will result in a FileUtils::RenameFailed.
In that case the file will simply be skipped altogether. It will remain untouched on the source device, and it will also not be deleted if the user tells the importer to delete the imported files. Deleting is only done for successfully imported files.
I'm already working on the other patch. Luckily, it seems like it might be relatively simple to implement some basic UI warnings for failed items.

Oct 31 2019, 6:58 PM · Gwenview
ngraham accepted D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..

All right no problem, we can do this in another patch.

Oct 31 2019, 6:47 PM · Gwenview
bdevries added a comment to D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..

For traceability's sake, I would separate the proper error handling into a separate patch/commit.
It's completely missing at the moment, so it seems strange to mix it in with a "new feature".

Oct 31 2019, 3:41 PM · Gwenview
ngraham added a comment to D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..

Register as FileUtils::RenameFailed if the subfolder cannot be created.

If the subfolder cannot be created, it will immediately register
as FileUtils::RenameFailed and no attempt to actually rename the
file will be made.
The FileUtils::RenameFailed handle can then later on be used to
warn the user about which files failed to import. (This is
currently not properly implemented.)

Oct 31 2019, 3:34 PM · Gwenview

Oct 30 2019

bdevries updated the diff for D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..

Register as FileUtils::RenameFailed if the subfolder cannot be created.

Oct 30 2019, 3:33 PM · Gwenview
hoffmannrobert added a comment to D25005: Fix image loading performance.

The connects at ContextManager::setUrlToSelect() only work with the if (UrlUtils::urlIsFastLocalFile()) determination.

Oct 30 2019, 11:52 AM · Gwenview
bdevries added a comment to D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..

You're absolutely right that there needs to be a GUI warning/report of some kind. However, the current importer does not have the infrastructure to handle this: it does nothing with failed imports (of any kind) except print a warning message to stdout. See e.g. the FIXME/warning on lines 208 and 255.

Oct 30 2019, 10:40 AM · Gwenview

Oct 29 2019

ngraham added a comment to D25005: Fix image loading performance.

That looks better, thanks. Not sure if it's the best place for the connect, but I'll leave that to Nate.

Another nit-pick from my side: In my opinion that if (UrlUtils::urlIsFastLocalFile()) should be removed. IIRC, Floopy devices, CDs and USB1.1 drives are considered to be "FastLocal". So, the else branch should become the only implementation... would also make testing simpler and better reproducible.

Oct 29 2019, 4:54 PM · Gwenview
ngraham added inline comments to D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..
Oct 29 2019, 4:52 PM · Gwenview
ngraham updated the summary of D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..
Oct 29 2019, 4:50 PM · Gwenview
ngraham added a reviewer for D25005: Fix image loading performance: Gwenview.
Oct 29 2019, 4:02 PM · Gwenview
tommo added a comment to D25005: Fix image loading performance.

That looks better, thanks. Not sure if it's the best place for the connect, but I'll leave that to Nate.

Oct 29 2019, 3:18 PM · Gwenview
hoffmannrobert added a comment to D25005: Fix image loading performance.

You are right, I changed it to use the signals from the document loaded (or not).

Oct 29 2019, 11:54 AM · Gwenview