Tracked with https://bugs.kde.org/show_bug.cgi?id=408551; no need for this to be open as well.

Marco has decided to take this over at https://invent.kde.org/graphics/gwenview/-/merge_requests/78

Not worth it.

And it's merged. :)

In D29886#676950, @ngraham wrote:

Thanks! However we are using GitLab now. Any chance you could close this and re-submit it as a merge request at https://invent.kde.org/graphics/gwenview/-/merge_requests/?

Thanks! However we are using GitLab now. Any chance you could close this and re-submit it as a merge request at https://invent.kde.org/graphics/gwenview/-/merge_requests/?

Cool, I'll close this now, and you can close D24521 once it's been migrated to Gitlab! :)

Ok guys, thanks for the feedback! I'll get my hands on again.

Hello tommo,
thanks for your work! I went through the change set and I didn't found a lot of things to improve. I never worked with exif, so I cannot say if it's good, but I could test it once it's on gitlab (I might also check if I get the same errors on unit tests). Besides, I'd suggest to split the change into two different patchsets, one for replacing JpegContent and another one for displaying the exif thumbnail.

In KDE, we have a saying: "those who do, decide."

I'd made two proposals for the new logo. What one of them I'll should submit as a merge request?

Looks great! Feel free to submit a merge request to the breeze-icons repo!

Updated license and metadata in file.

It's not a derivative. The icon was made from scratch. Circle-icons-eye.svg was taken as inspiration only.

Please note that the license that you base your work on is GPL while breeze icons is LGPL

Done in //invent.kde.org/graphics/gwenview/commit/9f9c9f45b605b11c2f3e22d3f9ff6eed77330bcd, sorry about that.

kf5 version is still not bumped.

Moved to https://invent.kde.org/graphics/gwenview/-/merge_requests/10

I hope it's okay to just add it here as a comment:
Tobias Witt <kde@amtare.eu>

Thanks! Can you provide an email address so we can land this with correct git authorship information?

thanks for reviewing!

Hi, is there anybody who can help review?

All good now, sorry for the wait.

Sorry to bother, what's the status of this review?

• make help text smaller
• stop editing unnecessary files

Just a few more changes required:

So sorry I missed your update to this patch! I will re-review.

Great job with this patch! May it be the first of many. :)

In D28480#650422, @ngraham wrote:

Right here in a comment. This will get a lot better with the GitLab migration in a few weeks. :)

In D28345#648241, @ngraham wrote:

Sorry for missing this.