GwenviewProject
ActivePublic

Details

Description

Gwenview is KDE's simple yet powerful image viewer.

Quick links to Bugzilla tickets:

Recent Activity

Fri, Nov 15

ngraham requested changes to D25111: Implement KMessageWidget to report import errors..

Thanks again for the patch!

Fri, Nov 15, 5:53 PM · Gwenview

Fri, Nov 8

ngraham added a comment to D25111: Implement KMessageWidget to report import errors..

Nice, will review soon.

Fri, Nov 8, 9:52 PM · Gwenview
bdevries requested review of D25224: Solve a bug which can happen with multiple files with the same name..
Fri, Nov 8, 9:44 PM · Gwenview
bdevries added inline comments to D24875: Importer: convert all file operations to allow remote URLs..
Fri, Nov 8, 9:17 PM · Gwenview
bdevries updated the diff for D24875: Importer: convert all file operations to allow remote URLs..

A few additional changes based on Nate's comments.

Fri, Nov 8, 9:16 PM · Gwenview
ngraham added a comment to D24875: Importer: convert all file operations to allow remote URLs..

Nice work. Just a few inline comments:

Fri, Nov 8, 4:09 PM · Gwenview
ngraham closed D25005: Fix image loading performance.
Fri, Nov 8, 3:03 PM · Gwenview
ngraham accepted D25005: Fix image loading performance.

Nice work.

Fri, Nov 8, 3:01 PM · Gwenview
hoffmannrobert added inline comments to D25005: Fix image loading performance.
Fri, Nov 8, 2:14 PM · Gwenview
hoffmannrobert updated the diff for D25005: Fix image loading performance.
  • Move connect to constructor
Fri, Nov 8, 2:11 PM · Gwenview
tommo added a comment to D25005: Fix image loading performance.

I've tested it and it works fine for me, thanks. One minor issue is noted below.

Fri, Nov 8, 1:30 PM · Gwenview

Tue, Nov 5

hoffmannrobert updated the summary of D25005: Fix image loading performance.
Tue, Nov 5, 8:57 AM · Gwenview

Mon, Nov 4

tommo added a comment to D25005: Fix image loading performance.

Ok. I would like to test this, will need a few days though.

Mon, Nov 4, 3:44 PM · Gwenview
hoffmannrobert updated the diff for D25005: Fix image loading performance.
  • Remove unnecessary include
Mon, Nov 4, 2:52 PM · Gwenview
hoffmannrobert added a comment to D25005: Fix image loading performance.

Thanks, I moved the reload() and added a signal readyForDirListerStart() to DocumentFactory, which is emitted when the document is loaded or failed. In ContextManager::setUrlToSelect() this signal is connected to the dirlister start.

Mon, Nov 4, 2:35 PM · Gwenview
hoffmannrobert updated the diff for D25005: Fix image loading performance.
  • Move reload(), add DocumentFactory::readyForDirListerStart()
Mon, Nov 4, 2:31 PM · Gwenview

Sun, Nov 3

ngraham added a reviewer for D25112: Allow users to disable bird view: Gwenview.
Sun, Nov 3, 2:51 PM · Gwenview
juchatycapelle added a comment to D25112: Allow users to disable bird view.

Thanks for the patch! The functionality seems to work fine. However it appears to cause a layout repression in the settings view

Sun, Nov 3, 9:23 AM · Gwenview

Sat, Nov 2

ngraham added a comment to D25112: Allow users to disable bird view.

Maybe it could be an option in the View menu? This seems like something people may want to toggle on and off with a keyboard shortcut (remembering the state from previous instances) rather than opening the settings dialog to enable/disable.

Sat, Nov 2, 8:45 PM · Gwenview
ndavis added a comment to D25112: Allow users to disable bird view.

I'm not necessarily opposed to this, but Gwenview's Image View settings page is already quite cluttered with options. I wonder if there is a better way to toggle this on or off. Perhaps the checkbox could be located in the toolbar below the image view, or in a new overflow menu button we could add on the right side of that toolbar.

Alternatively, if living in the Image View page makes the most sense, we should probably condense the view by replacing some or all of those multi-item radio buttons with comboboxes, which will save a lot of space.

Thoughts, VDG folks?

Sat, Nov 2, 8:36 PM · Gwenview
ngraham requested changes to D25112: Allow users to disable bird view.

Thanks for the patch! The functionality seems to work fine. However it appears to cause a layout repression in the settings view:

Sat, Nov 2, 7:56 PM · Gwenview
tommo added a comment to D25005: Fix image loading performance.

The same determination is done in LoadingDocumentImpl::init().

Sat, Nov 2, 10:57 AM · Gwenview
juchatycapelle requested review of D25112: Allow users to disable bird view.
Sat, Nov 2, 7:06 AM · Gwenview

Fri, Nov 1

bdevries requested review of D25111: Implement KMessageWidget to report import errors..
Fri, Nov 1, 10:50 PM · Gwenview

Thu, Oct 31

ngraham closed D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..
Thu, Oct 31, 8:31 PM · Gwenview
bdevries added a comment to D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..

No, nothing bad will happen. The importer will try to create a subfolder if needed. If it somehow doesn't succeed, it will result in a FileUtils::RenameFailed.
In that case the file will simply be skipped altogether. It will remain untouched on the source device, and it will also not be deleted if the user tells the importer to delete the imported files. Deleting is only done for successfully imported files.
I'm already working on the other patch. Luckily, it seems like it might be relatively simple to implement some basic UI warnings for failed items.

Thu, Oct 31, 6:58 PM · Gwenview
ngraham accepted D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..

All right no problem, we can do this in another patch.

Thu, Oct 31, 6:47 PM · Gwenview
bdevries added a comment to D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..

For traceability's sake, I would separate the proper error handling into a separate patch/commit.
It's completely missing at the moment, so it seems strange to mix it in with a "new feature".

Thu, Oct 31, 3:41 PM · Gwenview
ngraham added a comment to D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..

Register as FileUtils::RenameFailed if the subfolder cannot be created.

If the subfolder cannot be created, it will immediately register
as FileUtils::RenameFailed and no attempt to actually rename the
file will be made.
The FileUtils::RenameFailed handle can then later on be used to
warn the user about which files failed to import. (This is
currently not properly implemented.)

Thu, Oct 31, 3:34 PM · Gwenview

Wed, Oct 30

bdevries updated the diff for D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..

Register as FileUtils::RenameFailed if the subfolder cannot be created.

Wed, Oct 30, 3:33 PM · Gwenview
hoffmannrobert added a comment to D25005: Fix image loading performance.

The connects at ContextManager::setUrlToSelect() only work with the if (UrlUtils::urlIsFastLocalFile()) determination.

Wed, Oct 30, 11:52 AM · Gwenview
bdevries added a comment to D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..

You're absolutely right that there needs to be a GUI warning/report of some kind. However, the current importer does not have the infrastructure to handle this: it does nothing with failed imports (of any kind) except print a warning message to stdout. See e.g. the FIXME/warning on lines 208 and 255.

Wed, Oct 30, 10:40 AM · Gwenview

Tue, Oct 29

ngraham added a comment to D25005: Fix image loading performance.

That looks better, thanks. Not sure if it's the best place for the connect, but I'll leave that to Nate.

Another nit-pick from my side: In my opinion that if (UrlUtils::urlIsFastLocalFile()) should be removed. IIRC, Floopy devices, CDs and USB1.1 drives are considered to be "FastLocal". So, the else branch should become the only implementation... would also make testing simpler and better reproducible.

Tue, Oct 29, 4:54 PM · Gwenview
ngraham added inline comments to D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..
Tue, Oct 29, 4:52 PM · Gwenview
ngraham updated the summary of D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..
Tue, Oct 29, 4:50 PM · Gwenview
ngraham added a reviewer for D25005: Fix image loading performance: Gwenview.
Tue, Oct 29, 4:02 PM · Gwenview
tommo added a comment to D25005: Fix image loading performance.

That looks better, thanks. Not sure if it's the best place for the connect, but I'll leave that to Nate.

Tue, Oct 29, 3:18 PM · Gwenview
hoffmannrobert added a comment to D25005: Fix image loading performance.

You are right, I changed it to use the signals from the document loaded (or not).

Tue, Oct 29, 11:54 AM · Gwenview
hoffmannrobert updated the diff for D25005: Fix image loading performance.
  • Start dirlister on document signals
Tue, Oct 29, 11:51 AM · Gwenview

Mon, Oct 28

bdevries added a comment to D24881: After import, change default action to "keep" instead of "delete"..

I'll certainly consider it.
Let's see if I can find the time. :-)

Mon, Oct 28, 9:58 PM · Gwenview
ngraham closed D24881: After import, change default action to "keep" instead of "delete"..
Mon, Oct 28, 9:51 PM · Gwenview
ngraham added a comment to D24881: After import, change default action to "keep" instead of "delete"..

PS: Taking a step back, there are other ways of handling this. Other existing photo importers (across OSes) use different UI approaches. I've seen a few that handle this as part of the settings, offering a choice: "always keep", "always delete", "always ask". Others offer a checkbox "delete after import" on the photo import selection dialog.

That makes sense to me!

Mon, Oct 28, 9:49 PM · Gwenview
ngraham accepted D24881: After import, change default action to "keep" instead of "delete"..
Mon, Oct 28, 9:48 PM · Gwenview
ngraham updated the summary of D24881: After import, change default action to "keep" instead of "delete"..
Mon, Oct 28, 9:44 PM · Gwenview
bdevries added a reviewer for D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater).: Gwenview.
Mon, Oct 28, 8:43 PM · Gwenview
bdevries requested review of D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..
Mon, Oct 28, 8:40 PM · Gwenview
bdevries updated the diff for D24881: After import, change default action to "keep" instead of "delete"..

Swap keep and delete buttons. This makes keep the default action.

Mon, Oct 28, 8:24 PM · Gwenview
tommo added a comment to D25005: Fix image loading performance.

make sure that an url passed on the command line is loaded and shown before the possibly long running dirlister

Mon, Oct 28, 2:49 PM · Gwenview
hoffmannrobert requested review of D25005: Fix image loading performance.
Mon, Oct 28, 1:44 PM · Gwenview

Sun, Oct 27

ngraham closed D24872: Replace mkdtemp by QTemporaryDir.
Sun, Oct 27, 11:51 PM · Gwenview