GwenviewProject
ActivePublic

Details

Description

Gwenview is KDE's simple yet powerful image viewer.

Quick links to Bugzilla tickets:

Recent Activity

Thu, Jan 9

ngraham closed D26527: Fix divide-by-zero crash.
Thu, Jan 9, 5:09 PM · Gwenview
tommo added a comment to D26527: Fix divide-by-zero crash.

LGTM, thx!

Thu, Jan 9, 4:21 PM · Gwenview
ngraham added a reviewer for D26527: Fix divide-by-zero crash: tommo.
Thu, Jan 9, 3:29 PM · Gwenview
ngraham updated the diff for D26527: Fix divide-by-zero crash.

Also check prevWidth

Thu, Jan 9, 3:29 PM · Gwenview
ngraham added a comment to D26527: Fix divide-by-zero crash.

Good call!

Thu, Jan 9, 3:27 PM · Gwenview
tommo added a comment to D26527: Fix divide-by-zero crash.

Oh, good spot. I haven't considered malformed zero-size thumbnails, indeed.
In this case, you should also check for prevWidth > 0, otherwise scale
would become zero and we would have another div-by-zero.

Thu, Jan 9, 6:48 AM · Gwenview

Wed, Jan 8

ngraham closed D26507: Prevent drag & drop if left mouse button isn't pressed.
Wed, Jan 8, 6:24 PM · Gwenview
ngraham added a comment to D26507: Prevent drag & drop if left mouse button isn't pressed.

Thanks, that worked. I'm landing your patch now. Nice job, may it be the first of many!

Wed, Jan 8, 6:23 PM · Gwenview
tasossahanidis added a comment to D26507: Prevent drag & drop if left mouse button isn't pressed.

I was trying to avoid it, mostly due to possible spambot reasons, so I tried arc. If it still doesn't work, then I will post a comment with it. I'll be sure to use arc next time from the beginning. Apologies again.

Wed, Jan 8, 5:04 PM · Gwenview
tasossahanidis updated the diff for D26507: Prevent drag & drop if left mouse button isn't pressed.

Use arc to submit the patch

Wed, Jan 8, 5:02 PM · Gwenview
ngraham added a comment to D26507: Prevent drag & drop if left mouse button isn't pressed.

Just mention it in a comment here. For silly reasons, Phabricator disregards authorship in patches submitted using the web interface. It really wants you to use its arc command-line tool.

Wed, Jan 8, 4:51 PM · Gwenview
tasossahanidis added a comment to D26507: Prevent drag & drop if left mouse button isn't pressed.

Thanks for the patch! Works for me. Can you provide your email address so we can land it with correct authorship information?

Wed, Jan 8, 4:47 PM · Gwenview
tasossahanidis updated the diff for D26507: Prevent drag & drop if left mouse button isn't pressed.

Use git format-patch to hopefully add author information

Wed, Jan 8, 4:33 PM · Gwenview
ngraham added inline comments to D21398: Correctly crop Sony's embedded thumbnails.
Wed, Jan 8, 4:24 PM · Gwenview
ngraham updated the summary of D26527: Fix divide-by-zero crash.
Wed, Jan 8, 4:24 PM · Gwenview
ngraham requested review of D26527: Fix divide-by-zero crash.
Wed, Jan 8, 4:23 PM · Gwenview
ngraham accepted D26507: Prevent drag & drop if left mouse button isn't pressed.

Thanks for the patch! Works for me. Can you provide your email address so we can land it with correct authorship information?

Wed, Jan 8, 4:12 PM · Gwenview

Tue, Jan 7

tasossahanidis requested review of D26507: Prevent drag & drop if left mouse button isn't pressed.
Tue, Jan 7, 9:53 PM · Gwenview

Sun, Jan 5

dfaure abandoned D26348: Install the gwenview part into kf5/parts.

Dupe of D26349, not sure what happened

Sun, Jan 5, 7:16 PM · Gwenview

Sat, Jan 4

dfaure closed D26349: Install the gwenview part into kf5/parts, embed JSON metadata.
Sat, Jan 4, 9:58 AM · Gwenview
ngraham accepted D26349: Install the gwenview part into kf5/parts, embed JSON metadata.
Sat, Jan 4, 2:23 AM · Gwenview

Fri, Jan 3

dfaure updated the diff for D26349: Install the gwenview part into kf5/parts, embed JSON metadata.

rebase onto separated cleanup commit

Fri, Jan 3, 9:37 PM · Gwenview
ngraham added a comment to D26349: Install the gwenview part into kf5/parts, embed JSON metadata.

+1 to everything @kossebau said, then shipit

Fri, Jan 3, 6:34 AM · Gwenview

Thu, Jan 2

kossebau added a comment to D26349: Install the gwenview part into kf5/parts, embed JSON metadata.

Have not tested. Looks good code-wise, is what I would have done.

Thu, Jan 2, 8:10 PM · Gwenview

Wed, Jan 1

dfaure updated the diff for D26349: Install the gwenview part into kf5/parts, embed JSON metadata.

Also needs JSON metadata

Wed, Jan 1, 7:54 PM · Gwenview
dfaure requested review of D26349: Install the gwenview part into kf5/parts, embed JSON metadata.
Wed, Jan 1, 6:49 PM · Gwenview
dfaure requested review of D26348: Install the gwenview part into kf5/parts.
Wed, Jan 1, 6:47 PM · Gwenview

Fri, Dec 27

abcdjdj added a comment to D26230: Add button to toggle sidebar in fullscreen mode.

Very nice change, and very nice first patch! I love it when something like this is simple.

Fri, Dec 27, 6:03 AM · Gwenview

Thu, Dec 26

ngraham added a comment to D26230: Add button to toggle sidebar in fullscreen mode.

May it be the first of many. :)

Thu, Dec 26, 4:03 PM · Gwenview
ngraham closed D26230: Add button to toggle sidebar in fullscreen mode.
Thu, Dec 26, 4:03 PM · Gwenview
ngraham updated the summary of D26230: Add button to toggle sidebar in fullscreen mode.
Thu, Dec 26, 3:18 PM · Gwenview
ngraham accepted D26230: Add button to toggle sidebar in fullscreen mode.

Very nice change, and very nice first patch! I love it when something like this is simple.

Thu, Dec 26, 3:18 PM · Gwenview

Dec 26 2019

abcdjdj added a reviewer for D26230: Add button to toggle sidebar in fullscreen mode: ngraham.
Dec 26 2019, 10:39 AM · Gwenview
abcdjdj requested review of D26230: Add button to toggle sidebar in fullscreen mode.
Dec 26 2019, 9:59 AM · Gwenview

Dec 21 2019

twitt added a watcher for Gwenview: twitt.
Dec 21 2019, 9:47 PM
cfeck added inline comments to D21398: Correctly crop Sony's embedded thumbnails.
Dec 21 2019, 8:29 AM · Gwenview

Dec 3 2019

bdevries added a comment to D25111: Implement KMessageWidget to report import errors..

No problem.
I will follow up, as promised, with a patch to refactor the internationalization of the info/warning/error messages.

Dec 3 2019, 10:27 PM · Gwenview
nicolasfella closed D25693: Port away from deprecated DesktopIcon.
Dec 3 2019, 7:24 PM · Gwenview
nicolasfella updated the diff for D25693: Port away from deprecated DesktopIcon.
  • Use single arg fucntion
Dec 3 2019, 7:24 PM · Gwenview
ngraham requested changes to D25112: Allow users to disable bird view.

Thanks, looking better! When you edit app/gwenviewui.rc, you need to bump the version number that's at the top of the file. In addition, I added some inline comments that need to be addressed:

Dec 3 2019, 6:56 PM · Gwenview
ngraham closed D24875: Importer: convert all file operations to allow remote URLs.
Dec 3 2019, 6:43 PM · Gwenview
ngraham accepted D24875: Importer: convert all file operations to allow remote URLs.
Dec 3 2019, 6:37 PM · Gwenview
ngraham retitled D24875: Importer: convert all file operations to allow remote URLs from Importer: convert all file operations to allow remote URLs. to Importer: convert all file operations to allow remote URLs.
Dec 3 2019, 6:34 PM · Gwenview
ngraham closed D25224: Solve a bug which can happen with multiple files with the same name.
Dec 3 2019, 6:33 PM · Gwenview
ngraham retitled D25224: Solve a bug which can happen with multiple files with the same name from Solve a bug which can happen with multiple files with the same name. to Solve a bug which can happen with multiple files with the same name.
Dec 3 2019, 6:33 PM · Gwenview
ngraham accepted D25224: Solve a bug which can happen with multiple files with the same name.

Yep, makes sense, thanks!

Dec 3 2019, 6:26 PM · Gwenview
ngraham closed D25111: Implement KMessageWidget to report import errors..
Dec 3 2019, 6:22 PM · Gwenview
ngraham accepted D25111: Implement KMessageWidget to report import errors..

Yep, thanks. Sorry this patch has dragged on for so long. I'm landing it today!

Dec 3 2019, 6:22 PM · Gwenview
vkrause accepted D25693: Port away from deprecated DesktopIcon.
Dec 3 2019, 8:02 AM · Gwenview

Dec 2 2019

nicolasfella added a task to D25693: Port away from deprecated DesktopIcon: T11654: Deprecate SmallIcon/DesktopIcon/BarIcon/UserIcon/MainBarIcon and KDE::icon in favor of KIconLoader or QIcon API.
Dec 2 2019, 8:33 PM · Gwenview