Profile shortcuts switch profile instead of opening new tab
Needs ReviewPublic

Authored by thsurrel on Wed, Dec 5, 10:08 PM.

Details

Reviewers
hindenburg
tcanabrava
Group Reviewers
Konsole
Summary

This is a proposal to modify the profile shortcuts behaviour:
instead of opening a new tab with the corresponding profile
they now switch the profile of the current terminal display.

FEATURE: 319926

Diff Detail

Repository
R319 Konsole
Branch
arc_profileshortcuts (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5949
Build 5967: arc lint + arc unit
thsurrel created this revision.Wed, Dec 5, 10:08 PM
Restricted Application added a project: Konsole. · View Herald TranscriptWed, Dec 5, 10:08 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
thsurrel requested review of this revision.Wed, Dec 5, 10:08 PM

I don't really know how to test this in the embedded terminal in Kate for example. Could someone provide some guidance ?

I don't really know how to test this in the embedded terminal in Kate for example. Could someone provide some guidance ?

You can try to use the demo_konsolepart in src/tests/demo_konsolepart/ - or try to copy the home built konsolepart.so to a location the other apps will find them. (Depending on OS/distro exampe: /usr/lib/x86_64-linux-gnu/qt5/plugins/). If you have your distros konsole/konsolepart installed, it might cause issues.

I don't think I agree that using a profile shortcut should switch the current tab to that profile. What would be rationale for this change?

I don't think I agree that using a profile shortcut should switch the current tab to that profile. What would be rationale for this change?

I would say "Expectations", when I go to the profile I expect it to switch the currently focused terminal to that profile, if the button was labelled "new terminal with profile" then I would be against that change. I belive both variants could coexist.

thsurrel added a comment.EditedThu, Dec 13, 12:54 PM

Two other things:

  • there is already a shortcut to open a new tab (Ctrl-Shift-t), but nothing to change the profile of the current terminal. With this patch you can do everything from the keyboard.
  • as suggested in FEATURE: 319926, some users (me included) would like to be able to quickly switch temporarily to another profile and back.

I would say "Expectations", when I go to the profile I expect it to switch the currently focused terminal to that profile,

+1

OK, I never really use switch unless I'm testing something - I'll look at the code