Add a "Session Switcher" via Ctrl + Tab
Needs ReviewPublic

Authored by tcanabrava on Thu, Jan 10, 1:07 PM.


Group Reviewers

Press Ctrl + Tab and a session switcher will appear showing every
tab that you have, you can navigate with buttons, close via
focus out, esq key or selecting an index.

Diff Detail

R319 Konsole
No Linters Available
No Unit Test Coverage
Build Status
Buildable 6907
Build 6925: arc lint + arc unit
tcanabrava created this revision.Thu, Jan 10, 1:07 PM
Restricted Application added a project: Konsole. · View Herald TranscriptThu, Jan 10, 1:07 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
tcanabrava requested review of this revision.Thu, Jan 10, 1:07 PM
tcanabrava updated this revision to Diff 49152.Thu, Jan 10, 1:10 PM
  • Add missing files
lucasew added inline comments.

What you think about change the previous context hotkey to shift instead of meta. Some well known software like browsers use this shortcut and I think it will be more natural and intuitive.

thsurrel added a subscriber: thsurrel.EditedFri, Jan 11, 9:34 AM

What about merging this with the lastUsedView feature ?
Pressing Ctrl-Tab would open show the switcher ordered according to tabHistory. The tabs would be switched "live" while iterating through the list. The switcher would close when releasing the Ctrl key.
What do you think ?

I like the idea. I'll send a followup review with that.

Actually, I belive that if I do this change, it will conflict with our
other branch. *maybe* this should stay as is for now, untill we merge
the splits rewrite.

Agreed, the code around the lastUsedView has changed quite a bit in the terminatorStyleTabs branch, let's not duplicate the work. Except if terminatorStyleTabs is not ready for 19.04 ...

Yeah, +1 for focusing on one big change at a time for sanity. :)