[Device Notifier] Disable the possibility to unmount the root partition

Authored by thsurrel on Dec 7 2018, 12:36 PM.

Diff Detail

R120 Plasma Workspace
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
thsurrel created this revision.Dec 7 2018, 12:36 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 7 2018, 12:36 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
thsurrel requested review of this revision.Dec 7 2018, 12:36 PM
thsurrel edited the test plan for this revision. (Show Details)Dec 7 2018, 12:36 PM

I'm not very happy with all this root and home special casing all over the place (e.g. Places panel now also has something like this, etc)

thsurrel added a comment.EditedDec 7 2018, 1:14 PM

Can you develop why ? Is it because of the added code ?
From a usability point of view, does it not make sense to disable something that is not possible ?

ngraham added a subscriber: ngraham.Dec 7 2018, 2:48 PM

My root and home partitions don't appear in the devices notifier (they're on an internal NVMe SSD). How do you get in this state?

You need to configure the plasmoid and select to show "All devices". It's showing removable devices only by default (which sounds pretty sane!).

Ah, I see! Lol it never even occurred to me to try to configure the plasmoid.

Given that, I think this patch makes sense. No point in allowing people to do invalid things. Should we also give the same treatment to the partition that ~ lives on, if it's different?

abetts added a subscriber: abetts.Dec 7 2018, 3:22 PM

If this patch deals with the UI, is it possible to align the eject button to the middle using the progress bar as the center?

I made another patch that fixes the alignment D17420

davidedmundson accepted this revision.Jan 8 2019, 7:34 PM
This revision is now accepted and ready to land.Jan 8 2019, 7:34 PM

Thanks for this one too !
I forgot to mention this third patch: D16170 :)

ngraham accepted this revision.Jan 8 2019, 8:37 PM

Ship it!

This revision was automatically updated to reflect the committed changes.