[KPropertiesDialog] Show a filename for the / directory
Needs RevisionPublic
Actions

Authored by thsurrel on Oct 10 2018, 8:45 PM.

Details

Reviewers

Group Reviewers

Summary

The properties dialog was not showing anything in the window title
and in the file name label near the icon for the root folder.

Test Plan

Open the properties of the root folder

Repository

R241 KIO

Branch

arc_root (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 3742
Build 3760: arc lint + arc unit

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

thsurrel requested review of this revision.Oct 10 2018, 8:45 PM

Ping ! Anyone from Frameworks could review this ?

Whoops, missed this.

However, I'm afraid it doesn't work for me, unless I'm holding it wrong:

Looks like %1 isn't defined here.

This revision is now accepted and ready to land.Oct 29 2018, 9:59 PM

Er, whoops.

This revision now requires changes to proceed.Oct 29 2018, 9:59 PM

Is this still relevant - for me, the properties dialog has "Properties for /".

It is still missing the '/' for me, but I am on the latest releases, not on master right now.

			Path	Packages
M			src/widgets/kpropertiesdialog.cpp (5 lines)

Commit	Tree	Parents	Author	Summary	Date
f97a0e765987	1ee26bc24279	75a21cf6190e	Thomas Surrel	[KPropertiesDialog] Show a filename for the / directory (Show More…)	Oct 10 2018, 8:41 PM

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	43350	75a21cf		Oct 10 2018, 8:45 PM	★	★