Hi everyone,
I would like to carry on working on this patch, I keep compiling my own version of konsole just for it. This patch is very valuable in situations where I have to go through logs with _very_ similar lines (which happens quite too often for my job) and I need to keep precise track of where I am while navigating. As Nate pointed it, this is not so useful when scrolling one line at a time, but when using the half-page jump with Ctrl-PageUp/PageDown, it becomes essential to have a visual hint of what lines have come into view.

Sorry, I don't have much time for KDE lately unfortunately. As the author of this patch, I would have like to help ...

I tried several things, this full-size dimming was the option I liked best, but I am opened to other ideas of course.
VDG input will be usefull indeed.

Fix comments.
Thank you for the review!

Rebase

It is still missing the '/' for me, but I am on the latest releases, not on master right now.

Moved to TabbedViewContainer

Yeah, I was unsure because TabbedViewContainer::addView already had an 'index' parameter. I will move it there and remove that parameter.

Fixes as per Nate's comments.
Thanks for the review!

Anyone could have a look at this ? Thanks in advance.

It will go through all views, whether they are in a dedicated tab or in splits. This is what I would personally find the most useful.

No worries, the other patch is better actually.

I can land this myself.
Thank you again for all your help.

Ping
Does this seem better now, @hein ?

And I could guide you around the kernel except in the graphic area ...

Yeah, that would help if I had a laptop that has this behavior, but I couldn't find any.

I would love to see something like this getting in somehow, but as Nate described, we run into a problem with literally the first person that tested the patch. That sounds statistically bad.

Thank you so much for your patient reviews!

Fix code for groups and WinId-less tasks.

Use the WinIdList role

Hi @hein, could you help me finish this patch ? Can you have a look at my previous question ? Many thanks in advance.

Rebase

Remove the timer

Focus on load

Improvements as per @hein comments
Keep resizing if the task being closed with the middle button is
the last one in the task manager. That matches Firefox behavior.

In D17643#399932, @tcanabrava wrote:

I dimmed just a bit to reduce brightness, text is still really readable.
Can you test to see if you like? If not I’m open for suggestions.

I would vote against dimming. A common use case for having splitviews in a console is to monitor several terminals at the same time. You wouldn't want dimming to reduce the visibility in the other not-focused terminals in such a case.

Let's be as smart as Firefox!
Thanks for the review

Display the unmountAll button only when there are some MOUNTED devices.

There is a regression, I did not notice at first. By storing the connectedRemovables and not the mountedRemovables, the unmountAll button will appear even if nothing is mounted. That's not good.
I have to update a list in the onMountedChanged slot as I was doing before, or do you see a better way ?

Trying to improve based on broulik comments.
Thank you very much for the review!

A last minute review in case this can get into 5.15 ? Please :)

Agreed, the code around the lastUsedView has changed quite a bit in the terminatorStyleTabs branch, let's not duplicate the work. Except if terminatorStyleTabs is not ready for 19.04 ...

What about merging this with the lastUsedView feature ?
Pressing Ctrl-Tab would open show the switcher ordered according to tabHistory. The tabs would be switched "live" while iterating through the list. The switcher would close when releasing the Ctrl key.
What do you think ?

This patch has to be reworked to implement Nate's idea, I am not totally sure how that will work though. I will need to modify KIO for that as well.

Thanks for this one too !
I forgot to mention this third patch: D16170 :)

Thank you very much for taking a look. If you have a bit of time, I have two other patches about the device notifier that have been waiting for a while: D17402 and D16212.

Yes, I will have at least one other commit to push after this one. So I will wait.
In the meantime, I have updated the diff in phabricator the wrong way, and your work does not appear anymore. Can you revert what I did ? Sorry again.

Ok, not with arc diff --update, apparently. I am really sorry, can someone with better knowlege fix the mess I am making ?

Fix default focused terminalDisplay when switching tab

I made a correction that got commited in D18094.
How do you use arc so that it updates here instead ?

I'm on strike until my device notifier patches are reviewed ;)

This patch fixes a regression that appeared in this cycle, that would be good if someone could review it so that we don't ship it with 5.15.

One consequence of this work (which is great, all my thumbs up - that's about 2) is that the recently added feature allowing to switch between tabs in chronological order (with Ctrl-Tab) seems a bit outdated already.
What do you think of changing its behavior from being a 'tab history' to being a 'terminal history', hitting Ctrl-Tab would switch between terminals whether they are in different tabs or in different split views within the same tab ?

Sorry I did not have any time to test this, but I am really interested to see the result. I am back from my holidays now, I should be able to test tomorrow.

Fix requested by hindenburg
Thank you very much for the review

Create KUrlNavigator::isInsideCompressedPath
Use this function instead of comparing the url scheme with tar, zip, ...

Two other things:

• there is already a shortcut to open a new tab (Ctrl-Shift-t), but nothing to change the profile of the current terminal. With this patch you can do everything from the keyboard.
• as suggested in FEATURE: 319926, some users (me included) would like to be able to quickly switch temporarily to another profile and back.

Rebase

Neither helped... The problem may not be in plasma.

No more magic :(

I made another patch that fixes the alignment D17420

You need to configure the plasmoid and select to show "All devices". It's showing removable devices only by default (which sounds pretty sane!).

Can you develop why ? Is it because of the added code ?
From a usability point of view, does it not make sense to disable something that is not possible ?

Thanks for the tip, I will try to use gammaray.