[Device Notifier] Fix transition animation
ClosedPublic

Authored by thsurrel on Thu, Dec 6, 9:50 PM.

Details

Summary

In the specific case of having the device notifier opened
and inserting a device that has been configured to be
automatically mounted, the transition animation could be
interrupted resulting in the opacity being wrong.

Test Plan

In the setup discribed in the summary, you should never
see something like the attached screenshot where the list
of action opacity is not 1.

See http://doc.qt.io/qt-5/qml-qtquick-viewtransition.html#handling-interrupted-animations
for more information.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
thsurrel created this revision.Thu, Dec 6, 9:50 PM
Restricted Application added a project: Plasma. · View Herald TranscriptThu, Dec 6, 9:50 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
thsurrel requested review of this revision.Thu, Dec 6, 9:50 PM
thsurrel edited the test plan for this revision. (Show Details)Thu, Dec 6, 9:51 PM
ngraham accepted this revision.Fri, Dec 7, 12:36 AM
ngraham added a subscriber: ngraham.

Nice catch! This works and looks good to me, but let's make sure the Plasma folks agree. :)

This revision is now accepted and ready to land.Fri, Dec 7, 12:36 AM
davidedmundson added inline comments.
applets/devicenotifier/package/contents/ui/DeviceItem.qml
197

alwaysRunToEnd : true

Is this Bug 379759?

thsurrel added inline comments.Fri, Dec 7, 11:38 AM
applets/devicenotifier/package/contents/ui/DeviceItem.qml
197

That does not work by itself.

davidedmundson accepted this revision.Fri, Dec 7, 12:06 PM

Is this Bug 379759?

I don't think so, but I will have a look at that one too.

If any of you guys can have a look at my other device notifier patches, that would be really nice!
D16170
D16212
D17127

This revision was automatically updated to reflect the committed changes.