[Device Notifier] Restore busy indicator

Authored by thsurrel on Oct 12 2018, 9:23 PM.



This patch fixes two issues:

  • the 'state' of the device now propagates correctly, that makes the busy indicator be displayed again, device emblems are also updated correctly
  • there is no more delay between the moment when the device is actually mounted and the moment the device notifier says it is. The worst case used to be 5 seconds.

BUG: 354321
BUG: 399986

Diff Detail

R120 Plasma Workspace
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
thsurrel created this revision.Oct 12 2018, 9:23 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 12 2018, 9:23 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
thsurrel requested review of this revision.Oct 12 2018, 9:23 PM

The bad news with this patch is that I don't understand it fully.
Why were we doing polling before ? Why was it breaking the 'state' propagation ? What does it change not to do it anymore (performance hit ? something else ?) ?

ngraham added a subscriber: ngraham.

I have no understanding of this code, but am adding some reviewers who do. :)

thsurrel edited the summary of this revision. (Show Details)Oct 15 2018, 7:29 PM

FWIW, I can confirm that https://bugs.kde.org/show_bug.cgi?id=399986 is fixed with this.

thsurrel edited the summary of this revision. (Show Details)Oct 19 2018, 12:50 PM
cfeck added a subscriber: cfeck.Nov 8 2018, 8:40 PM

What is the status of this patch?

It is awaiting a review.
As I said in an older comment, I don't know if there are some drawbacks to not do polling, but i have been using this patch for a while and it works well.

Ping !
Anyone could have a look at this patch ?

mart added a subscriber: mart.Nov 23 2018, 2:13 PM

Most of the solidevice engine should not relay on polling..
after a quick glance at its code: can you test if the free space bar is still updating correctly after copying big files from and to?

thsurrel updated this revision to Diff 46093.Nov 23 2018, 9:53 PM

Update the storage size every 5 seconds
Thank you for catching this one @mart !

ngraham accepted this revision.Jan 8 2019, 11:45 PM

Thanks, this works great.

This revision is now accepted and ready to land.Jan 8 2019, 11:45 PM
davidedmundson accepted this revision.Jan 9 2019, 2:48 AM
This revision was automatically updated to reflect the committed changes.