Add the possibility to give focus to the KPluginSelector search field
AbandonedPublic

Authored by thsurrel on Nov 15 2018, 9:30 PM.

Details

Reviewers
None
Group Reviewers
Frameworks
Plasma

Diff Detail

Repository
R295 KCMUtils
Branch
arc_focussearch (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8805
Build 8823: arc lint + arc unit
thsurrel created this revision.Nov 15 2018, 9:30 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 15 2018, 9:30 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
thsurrel requested review of this revision.Nov 15 2018, 9:30 PM

Why does this need a timer?

Simply calling setFocus() was not working (I used this in D16914). My understanding is that the widget containing this has to be completely built before trying to set the focus, adding the timer ensures that. Correct me if this is wrong.

Sounds like you know more than I do at this point. :) Let's see if this approach makes sense to @cfeck or @broulik.

Correct me if this is wrong.

It shouldn't be needed, no.

This is a workaround for something, potentially another widget pulling focus on startup.

gammaray can be a fantastic tool in diagnosing this sort of thing.

Thanks for the tip, I will try to use gammaray.

Any update on this?

I'm on strike until my device notifier patches are reviewed ;)

More seriously, I did not have the time to look into gammaray. I will as soon as I can, but don't hesitate to tell me if you want to take over this patch.

thsurrel updated this revision to Diff 50295.Jan 25 2019, 9:18 PM

Remove the timer

thsurrel abandoned this revision.Mar 26 2019, 2:33 PM

Oh gosh I completely forgot about this, sorry. :(

No worries, the other patch is better actually.