progwolff (Julian Wolff)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Feb 11 2017, 12:58 PM (95 w, 6 d)
Availability
Available

Recent Activity

Aug 26 2018

progwolff requested review of D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized..
Aug 26 2018, 4:53 PM · Plasma
progwolff added a comment to D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized..

I installed a fresh Neon (dev unstable), removed the preinstalled files from /etc/fonts, copied your files to /etc/fonts and applied this patch.
Still cannot reproduce your issue.

Aug 26 2018, 1:14 PM · Plasma

Aug 12 2018

progwolff added a comment to D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized..

I still cannot reproduce your issue. Any idea what I could try?

Aug 12 2018, 12:24 PM · Plasma

Aug 8 2018

progwolff added a comment to T7927: Fonts “easy mode”.
  • Current kcm / new kcm's advanced tab
Aug 8 2018, 5:32 PM · VDG, Plasma: KCM Redesign

Aug 3 2018

progwolff planned changes to D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized..

With this latest version, the issue I mentioned earlier persists for me. I did briefly get sub-pixel rendering again to work by switching the hinting style to Full, but then after switching back to something else and then back to Full again, it no longer worked and I was back to no sub-pixel rendering again. Feels kinda buggy.

Aug 3 2018, 6:12 AM · Plasma

Aug 2 2018

progwolff added a comment to T7927: Fonts “easy mode”.

Either way, we first need to implement tabs with a decent look&feel in Kirigami (resolve bugs 394295 and 394296) .

Aug 2 2018, 7:45 PM · VDG, Plasma: KCM Redesign
progwolff updated the diff for D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized..
  • fix writing config temporarily (previews) with missing local config entries
Aug 2 2018, 6:23 PM · Plasma
progwolff added a comment to T7927: Fonts “easy mode”.

So we keep the separator line in the advanced mode and drop the tabs from D12849#263660 ?

Aug 2 2018, 4:26 PM · VDG, Plasma: KCM Redesign
progwolff added a comment to T7927: Fonts “easy mode”.

We already discussed in D12849 if we should split the current layout into two tabs.
I like the idea of a simple mode and using tabs here seems like a good idea.
But we might want to have three tabs (Simple, Fonts fine-tuning, Rendering fine-tuning).

Aug 2 2018, 6:21 AM · VDG, Plasma: KCM Redesign

Jul 31 2018

progwolff added a comment to D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized..

could you give me all those files?

Jul 31 2018, 2:59 PM · Plasma
progwolff added a comment to D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized..

Works for me....

Jul 31 2018, 2:50 PM · Plasma
progwolff updated the diff for D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized..
  • fix previews
Jul 31 2018, 9:01 AM · Plasma
progwolff added a comment to D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized..

I am not sure about the case when neither global nor local configs exist for subpixel or hint.
On my system it seems like rgb subpixel rendering with slight hinting is used when no configs exist. But I cannot find any documentation on this.

Jul 31 2018, 8:57 AM · Plasma
progwolff updated the diff for D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized..
  • Merge branch 'master' of git://anongit.kde.org/plasma-desktop into arcpatch-D12925
  • Merge branch 'master' of git://anongit.kde.org/plasma-desktop into arcpatch-D12925
  • also drop vendor-default-option for subpixel and hint
Jul 31 2018, 8:54 AM · Plasma

Jul 30 2018

progwolff committed R119:b0c9b776be37: Merge remote-tracking branch 'origin/Plasma/5.13' (authored by progwolff).
Merge remote-tracking branch 'origin/Plasma/5.13'
Jul 30 2018, 5:55 PM
progwolff committed R119:79a4bbc36cee: Don't unintentionally change font rendering when rendering preview images (authored by progwolff).
Don't unintentionally change font rendering when rendering preview images
Jul 30 2018, 1:40 PM
progwolff closed D14480: Don't unintentionally change font rendering when rendering preview images.
Jul 30 2018, 1:40 PM · Plasma
progwolff removed a reviewer for D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.: rkflx.
Jul 30 2018, 11:43 AM · Plasma
progwolff added a dependency for D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.: D14480: Don't unintentionally change font rendering when rendering preview images.
Jul 30 2018, 11:42 AM · Plasma
progwolff added a dependent revision for D14480: Don't unintentionally change font rendering when rendering preview images: D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized..
Jul 30 2018, 11:42 AM · Plasma
progwolff requested review of D14480: Don't unintentionally change font rendering when rendering preview images.
Jul 30 2018, 11:40 AM · Plasma
progwolff updated the diff for D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized..
  • split changes to previewimageprovider.cpp to a separate commit
Jul 30 2018, 11:31 AM · Plasma
progwolff added a comment to D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized..

Big sorry for being away for so long. I had some things to do that took much more time than initally planned.
Many thanks to those who fixed the bugs I introduced or created workarounds...

Jul 30 2018, 9:20 AM · Plasma
progwolff updated the diff for D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized..

Rebase on master. Partial rewrite.

Jul 30 2018, 9:02 AM · Plasma

Jun 17 2018

progwolff planned changes to D13579: apply blur to windows using Konsole as KPart.
Jun 17 2018, 5:24 PM · Konsole
progwolff requested review of D13579: apply blur to windows using Konsole as KPart.
Jun 17 2018, 11:19 AM · Konsole

Jun 7 2018

progwolff added a comment to D12851: Change preview text background color to match with default combobox background color.

Sorry for the delay...
I planned to land this together with D12849 and D12925.

Jun 7 2018, 6:28 AM · Plasma

May 23 2018

progwolff accepted D13051: Fix Font KCM force font DPI checkbox.
May 23 2018, 9:18 AM · Plasma

May 17 2018

progwolff planned changes to D12849: Improve layout of fonts kcm.
May 17 2018, 11:54 AM · Plasma
progwolff planned changes to D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized..
May 17 2018, 11:53 AM · Plasma
progwolff added a comment to D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized..

I'll resume testing once this works a bit better. I'd say let's not rush this, and get it right for 5.14.

May 17 2018, 11:53 AM · Plasma
progwolff updated the diff for D12849: Improve layout of fonts kcm.
  • i18n
May 17 2018, 7:31 AM · Plasma
progwolff added a comment to D12849: Improve layout of fonts kcm.

Did not review the code, but I noticed some warnings in addition to those mentioned above:

share/kpackage/kcms/kcm_fonts/contents/ui/main.qml:230:25: QML Image: Invalid image provider: image://preview/0_0.png
…
share/kpackage/kcms/kcm_fonts/contents/ui/main.qml:273:17: QML SpinBox: Binding loop detected for property "value"

The first isn't critical and exists since the previews were introduced. I will try to fix this in a separate commit.
The second on doesn't show up for me...

May 17 2018, 7:19 AM · Plasma
progwolff updated the diff for D12849: Improve layout of fonts kcm.
  • title case for 'Choose a Font'
May 17 2018, 7:19 AM · Plasma

May 16 2018

progwolff updated the diff for D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized..
  • remove unintentionally committed debug lines
May 16 2018, 6:42 PM · Plasma
progwolff added a comment to D12849: Improve layout of fonts kcm.

That would be this one:

May 16 2018, 5:17 PM · Plasma
progwolff added a comment to D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized..
In D12925#263459, @mart wrote:

if it removes the vendor default option, how can i ask to not touch the global/local defaults in any way?

May 16 2018, 11:30 AM · Plasma
progwolff updated the diff for D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized..
  • Fix 'disabled from'
May 16 2018, 9:25 AM · Plasma
progwolff requested review of D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized..
May 16 2018, 9:16 AM · Plasma
progwolff added a comment to D12849: Improve layout of fonts kcm.

We were always told by VDG that tabs are bad and a 5 km vertically scrolling list is better no matter what. So be consistent, please.

May 16 2018, 7:34 AM · Plasma

May 15 2018

progwolff added a comment to D12849: Improve layout of fonts kcm.

From what I could find there is no TabView in QtQuickControls2 or Kirigami.
This is how it's done in Kirigami Gallery:

May 15 2018, 4:39 PM · Plasma
progwolff added a comment to D12849: Improve layout of fonts kcm.

@progwolff, what happened to the frame for the tabbed view?

Did it the wrong way. Is fixed now.

May 15 2018, 4:27 PM · Plasma
progwolff updated the diff for D12849: Improve layout of fonts kcm.
  • fix tabbar frame
May 15 2018, 4:23 PM · Plasma
progwolff added a comment to D12849: Improve layout of fonts kcm.

Using tabs there are some problems with Kirigami now:

May 15 2018, 2:24 PM · Plasma
progwolff updated the diff for D12849: Improve layout of fonts kcm.
  • fix button widths
May 15 2018, 2:20 PM · Plasma
progwolff updated the diff for D12849: Improve layout of fonts kcm.
  • use tabs
May 15 2018, 2:14 PM · Plasma
progwolff added a comment to D12849: Improve layout of fonts kcm.

May 15 2018, 2:12 PM · Plasma
progwolff added a comment to D12849: Improve layout of fonts kcm.

May 15 2018, 1:23 PM · Plasma
progwolff updated the diff for D12849: Improve layout of fonts kcm.
  • Use radio buttons. Use spacing instead of Separator. Simplify max(...).
May 15 2018, 1:21 PM · Plasma
progwolff added a comment to D12849: Improve layout of fonts kcm.

BTW, what's the difference between Vendor Default and the regular Defaults button? Either we provide an option to reset to the default for every single option separately, or for none at all.

Here "Vendor Default" means that no value is written to the user's ~/.config/fontconfig/fonts.conf. There might be a system wide config file though that has different settings.

But the same argument holds basically for any system-wide default setting? The only difference here is that normally defaults are provided via KConfigXT, while here it comes from fontconfig. Could we simply read the vendor default value, display it in the UI and finally if the user's choice is different, write it to the user's config?

May 15 2018, 12:37 PM · Plasma
progwolff added a comment to D12849: Improve layout of fonts kcm.
May 15 2018, 12:30 PM · Plasma
progwolff added a comment to D12849: Improve layout of fonts kcm.

How about joining the options instead?

May 15 2018, 9:12 AM · Plasma

May 14 2018

progwolff added a comment to D12849: Improve layout of fonts kcm.

You mean like this?

May 14 2018, 4:47 PM · Plasma
progwolff added a comment to D12849: Improve layout of fonts kcm.

We might want to take the opportunity to also center-align the titles, which it better-looking for these centered formlayout style UIs.

Section titles in form layouts are left-aligned. This would have to be changed in Kirigami. @mart, am I right?

May 14 2018, 8:25 AM · Plasma

May 13 2018

progwolff updated the test plan for D12851: Change preview text background color to match with default combobox background color.
May 13 2018, 11:25 AM · Plasma
progwolff requested review of D12851: Change preview text background color to match with default combobox background color.
May 13 2018, 11:25 AM · Plasma
progwolff updated the test plan for D12849: Improve layout of fonts kcm.
May 13 2018, 11:20 AM · Plasma
progwolff requested review of D12849: Improve layout of fonts kcm.
May 13 2018, 11:19 AM · Plasma

Apr 16 2018

progwolff abandoned D12220: [RFC] Beautify declaration navigation context by parsing doxygen commands.

Overall, imo, I really think we should instead fix clang upstream so that we can re-enable this feature as we got it through libclang. See also:

https://phabricator.kde.org/D8857
https://bugs.llvm.org/show_bug.cgi?id=35333

Apr 16 2018, 12:58 PM
progwolff added a comment to D12220: [RFC] Beautify declaration navigation context by parsing doxygen commands.

I'm very unsure about this. On one hand, this obviously looks better in your screenshots. On the other hand, what if we encounter comments that are formatted with some other syntax?

Do you have examples for comments in a different syntax? I only know javadoc, which is quite similar.
Maybe there is a way to add the proposed functionality to the clang backend instead. This way we could be sure that the comments we parse are always doxygen comments.

Apr 16 2018, 10:40 AM

Apr 15 2018

progwolff updated the diff for D12220: [RFC] Beautify declaration navigation context by parsing doxygen commands.
  • fix newline escape sequence
Apr 15 2018, 12:07 PM
progwolff updated the diff for D12220: [RFC] Beautify declaration navigation context by parsing doxygen commands.
  • fix @see
Apr 15 2018, 11:48 AM
progwolff added inline comments to D12220: [RFC] Beautify declaration navigation context by parsing doxygen commands.
Apr 15 2018, 11:48 AM
progwolff added a comment to D12220: [RFC] Beautify declaration navigation context by parsing doxygen commands.

This is great! Could you add \ref, \link and \endlink as well?

Apr 15 2018, 11:39 AM
progwolff updated the summary of D12220: [RFC] Beautify declaration navigation context by parsing doxygen commands.
Apr 15 2018, 11:03 AM
progwolff updated the diff for D12220: [RFC] Beautify declaration navigation context by parsing doxygen commands.
  • remove newline
Apr 15 2018, 11:02 AM
progwolff updated the test plan for D12220: [RFC] Beautify declaration navigation context by parsing doxygen commands.
Apr 15 2018, 11:01 AM
progwolff requested review of D12220: [RFC] Beautify declaration navigation context by parsing doxygen commands.
Apr 15 2018, 11:00 AM

Apr 9 2018

progwolff committed R169:6ac4e62002ae: checkable FormLayout items (authored by progwolff).
checkable FormLayout items
Apr 9 2018, 4:44 PM
progwolff closed D11289: checkable FormLayout items.
Apr 9 2018, 4:43 PM · Kirigami

Mar 30 2018

progwolff accepted D11768: Add Desktop and Downloads to the default list of Places.
Mar 30 2018, 8:36 AM · Frameworks

Mar 29 2018

progwolff added a comment to D11768: Add Desktop and Downloads to the default list of Places.

Still, that folder exists by default

Are you sure? It might be created by some weird startup script or something else. Also, a user can choose to change the location of the Desktop folder. Just wanting to make sure this change (which I'm totally in favor of, don't get me wrong) doesn't break or have unwanted side-effects.

Mar 29 2018, 2:20 PM · Frameworks

Mar 23 2018

progwolff updated the diff for D11064: add preview images to fonts kcm.
  • giant comments
Mar 23 2018, 3:09 PM · Plasma

Mar 19 2018

progwolff updated the diff for D11289: checkable FormLayout items.
  • split buddyComponent and checkableBuddyComponent
  • toggle checkbox on shortcut activated
Mar 19 2018, 5:50 PM · Kirigami
progwolff planned changes to D11289: checkable FormLayout items.
In D11289#229340, @mart wrote:

can you provide screenshots as well t see how does it look?

Mar 19 2018, 5:00 PM · Kirigami
progwolff updated the test plan for D11289: checkable FormLayout items.
Mar 19 2018, 4:57 PM · Kirigami

Mar 18 2018

progwolff added a comment to D10251: [RFC] Use mipmap filtering in window thumbnails.

I tested it with several running applications, including windows with different apect ratios and combined previews for multiple instances of the same application. Looks great in every case.

Mar 18 2018, 7:40 PM · Frameworks, Plasma

Mar 17 2018

progwolff added a comment to D10251: [RFC] Use mipmap filtering in window thumbnails.

Could you please rebase on current master?

Mar 17 2018, 3:54 PM · Frameworks, Plasma

Mar 15 2018

progwolff added a watcher for KUserFeedback: progwolff.
Mar 15 2018, 10:46 AM

Mar 14 2018

progwolff added a comment to D11308: Use the default Plasma wallpaper on the lock screen.

@hein might be right here.
If it's the single-click/double-click thing or this issue here: People who are happy with the status quo won't reach out to us.
Maybe we need to discuss at a different place if and how we can learn about the opinion of the majority of KDE/Plasma users, before we change things that are possibly only broken for few.

Mar 14 2018, 4:30 PM · Plasma
progwolff added a comment to D11316: Components for Cards.

There seems to be a problem with the overflow menu:

Mar 14 2018, 11:20 AM · Kirigami
progwolff added a comment to D11316: Components for Cards.

Marked some typos. Note that I am not a native speaker, so please re-check them.

Mar 14 2018, 11:01 AM · Kirigami

Mar 13 2018

progwolff updated the summary of D11289: checkable FormLayout items.
Mar 13 2018, 3:18 PM · Kirigami
progwolff updated the summary of D11289: checkable FormLayout items.
Mar 13 2018, 3:13 PM · Kirigami
progwolff requested review of D11289: checkable FormLayout items.
Mar 13 2018, 3:12 PM · Kirigami

Mar 12 2018

progwolff added a comment to D11064: add preview images to fonts kcm.

@davidedmundson ping?

Mar 12 2018, 9:38 AM · Plasma

Mar 11 2018

progwolff added a comment to T7927: Fonts “easy mode”.

I tried to unclutter the old kcm / new advanced mode a bit.
What do you think about this?

Mar 11 2018, 6:05 PM · VDG, Plasma: KCM Redesign
progwolff added a comment to D11180: Reverse tooltip colors for Breeze colorscheme.

I remember that the dark tooltips felt strange to me when I started using breeze.
Now that I am used to it, I actually prefer the dark tooltips because of their high contrast to the other GUI elements.

Mar 11 2018, 10:46 AM · Plasma, Breeze

Mar 10 2018

progwolff committed R875:d708fea839d8: Use selected text in searchToolBar (authored by progwolff).
Use selected text in searchToolBar
Mar 10 2018, 2:05 PM
progwolff closed D11210: Use selected text in searchToolBar.
Mar 10 2018, 2:05 PM
progwolff updated the diff for D11210: Use selected text in searchToolBar.
  • remove nullptr check, use const QString, style
Mar 10 2018, 2:04 PM
progwolff updated the diff for D11210: Use selected text in searchToolBar.
  • remove unnecessary semicolon
Mar 10 2018, 2:02 PM
progwolff updated the diff for D11210: Use selected text in searchToolBar.
  • Use QWebEnginePage::selectedText()
Mar 10 2018, 1:54 PM
progwolff requested review of D11210: Use selected text in searchToolBar.
Mar 10 2018, 1:44 PM

Mar 9 2018

progwolff committed R119:ac5c39292836: fix detecting changes in sub-pixel and hinting settings (authored by progwolff).
fix detecting changes in sub-pixel and hinting settings
Mar 9 2018, 2:21 PM
progwolff closed D11174: fix detecting changes in sub-pixel and hinting settings.
Mar 9 2018, 2:21 PM · Plasma
progwolff accepted D11118: Show a message if Konsole part is not installed.
  • Try to break it every way we can

Couldn't break it so far

Mar 9 2018, 10:31 AM
progwolff added a comment to D11118: Show a message if Konsole part is not installed.

I really like that install button. Maybe it could be added to KWidgetsAddons?
I see usecases in Okular for installing backends or in Telepathy for installing plugins.

Mar 9 2018, 10:04 AM
progwolff updated the summary of D11174: fix detecting changes in sub-pixel and hinting settings.
Mar 9 2018, 9:51 AM · Plasma
progwolff updated the summary of D11174: fix detecting changes in sub-pixel and hinting settings.
Mar 9 2018, 9:51 AM · Plasma