Fix Font KCM force font DPI checkbox
ClosedPublic

Authored by davidedmundson on May 23 2018, 1:26 AM.

Details

Summary

Fixes numerous issues:

  1. the default behaviour had changed. It should disable force font DPI,

not set it to 96

  1. disabling didn't work, we'd set the value to 0, which would update

the spinbox, which has a minimum which sets the value to 96 (we were
warned of this with a binding loop error)

  1. toggling the checkbox didn't enable the apply button

New code fixes that and is more declarative too.

BUG: 394180

Test Plan

Toggled, reset to defaults, restarted

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.May 23 2018, 1:26 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 23 2018, 1:26 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.May 23 2018, 1:26 AM
broulik added inline comments.
kcms/fonts/package/contents/ui/main.qml
223

when: dpiSpinbox.enabled?

davidedmundson added inline comments.May 23 2018, 9:08 AM
kcms/fonts/package/contents/ui/main.qml
223

I want to set it explicitly to 0 when we're not enabled.

Two Bindings with two when statements would work, but that seems more complex.

progwolff accepted this revision.May 23 2018, 9:18 AM
This revision is now accepted and ready to land.May 23 2018, 9:18 AM
broulik accepted this revision.May 23 2018, 9:20 AM
This revision was automatically updated to reflect the committed changes.