Differential D11210

Use selected text in searchToolBar
ClosedPublic
Actions

Authored by progwolff on Mar 10 2018, 1:44 PM.

Details

Reviewers
drosca
Group Reviewers
Falkon
Commits
R875:d708fea839d8: Use selected text in searchToolBar
Summary

With this patch, the currently selected text in a webpage is automatically inserted into the
searchToolBar when it is opened.
This matches the behaviour of the search tool bar in Kate.

Test Plan

Open a webpage. Select a single line of text. Press Ctrl+F. The selected text is inserted into the
searchToolBar.

Diff Detail

Repository
R875 Falkon
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
progwolff requested review of this revision.Mar 10 2018, 1:44 PM
progwolff created this revision.
drosca requested changes to this revision.Mar 10 2018, 1:49 PM
drosca added a subscriber: drosca.
drosca added inline comments.
src/lib/app/browserwindow.cpp
1157

There is QWebEnginePage::selectedText().

This revision now requires changes to proceed.Mar 10 2018, 1:49 PM
progwolff updated this revision to Diff 29157.Mar 10 2018, 1:54 PM
  • Use QWebEnginePage::selectedText()
progwolff marked an inline comment as done.Mar 10 2018, 2:00 PM
drosca accepted this revision.Mar 10 2018, 2:01 PM

Apart from those minor issues, looks good. Thanks.

src/lib/app/browserwindow.cpp
1157

page() will never be null.

1158

const

1162

else on the same line } else {

This revision is now accepted and ready to land.Mar 10 2018, 2:01 PM
progwolff updated this revision to Diff 29158.Mar 10 2018, 2:02 PM
  • remove unnecessary semicolon
progwolff updated this revision to Diff 29159.Mar 10 2018, 2:04 PM
progwolff marked 3 inline comments as done.
  • remove nullptr check, use const QString, style
Closed by commit R875:d708fea839d8: Use selected text in searchToolBar (authored by progwolff). · Explain WhyMar 10 2018, 2:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 29160

View Options

src/lib/app/browserwindow.cpp

Loading...
View Options

src/lib/webtab/searchtoolbar.h

Loading...
View Options

src/lib/webtab/searchtoolbar.cpp

Loading...
View Options

src/lib/webtab/webtab.h

Loading...
View Options

src/lib/webtab/webtab.cpp

Loading...