work around clang bug 35333: don't crash when switching git branches
ClosedPublic

Authored by brauch on Nov 16 2017, 10:36 PM.

Details

Reviewers
kfunk
mwolff
Group Reviewers
KDevelop
Summary

See https://bugs.llvm.org/show_bug.cgi?id=35333 for details and
explanation.

We need to do two things to work around this bug: disable -Wdocumentation,
and only use the plain text from the comments instead of the parsed
version.

Test Plan

Open a project in kdev, and while it's parsing run "git checkout A; sleep 1; git checkout B; sleep 1;" in a loop. Without this patch, it will crash after at most 10-15 iterations here.

Diff Detail

Repository
R32 KDevelop
Lint
Lint Skipped
Unit
Unit Tests Skipped
brauch created this revision.Nov 16 2017, 10:36 PM
Restricted Application added a subscriber: kdevelop-devel. ยท View Herald TranscriptNov 16 2017, 10:36 PM
kfunk accepted this revision.Nov 16 2017, 11:19 PM

Also fixes^Wworks-around https://bugs.kde.org/show_bug.cgi?id=358205 -- needs BUG: and FIXED-IN:

plugins/clang/duchain/builder.cpp
949

Just for symmetry: use < 100 here, too...

plugins/clang/duchain/parsesession.cpp
82

Please adhere to coding style :)

This revision is now accepted and ready to land.Nov 16 2017, 11:19 PM
brauch closed this revision.Nov 17 2017, 12:46 AM

Ok, REVIEW: doesn't close reviews ... submitted with a2712c8d969137 to 5.2. Thanks for the comments.