- User Since
- Jun 8 2018, 3:19 AM (95 w, 4 d)
Sep 13 2019
Nov 21 2018
Nov 20 2018
Fixed by D17037
Nov 11 2018
Sorry about that, I can take a look!
These are the units you're talking about right: https://hig.kde.org/layout/units.html?
Aug 6 2018
Aug 2 2018
@broulik thanks, will do!
@ngraham cool! So I should change the deps for KF 5.50 unless someone else disagrees?
@ngraham I wouldn't mind if you made that change, but I'll keep it like this for now.
Jul 17 2018
@ngraham they are highlighted when pressed, is that what you mean? or do you have an example?
Jul 13 2018
Use phone formatting closer to android dialer
Jul 12 2018
- Use full width characters for special dialpad chars
- Log qt output to stdout as well as log file
- Fix compiler warnings, remove some .moc files
Jul 11 2018
Rebase on master
Fix incorrect QML id
Remove pixel sizes for point and units and add libphonenumber requirement to cmakelists
Update mauikit again to support qt < 5.11
@ngraham this didn't make it into 5.48 but it did make it into the commit after that. Should I put 5.49 even though its not tagged yet?
Thanks @bcooksley ! I'll look into doing that
Jul 9 2018
Jul 8 2018
@dfaure you can land it its no problem. I'm also not in a rush to get it into 5.48 or anything (Bug 262837 is from 2011).
I have a few diffs in review, I think I'll apply for a dev account since I'd like to keep doing this stuff.
@dfaure I don't believe I have permission to edit the wiki, can I make a revision against it somehow? Nevermind, just had to make an account.
@bruns should I continue with this implementation and add dbs and such? And do the tests make sense?
Respond to @dfaure comments by adding tests and separating subseq func
Jul 7 2018
Jul 5 2018
@bshah I'd like to work on this! I just started with KDE dev, so I'm still going through a learning curve.
I'll update this comment with a specific task once I look through the app.
I'm going to start with the dialer UI, the diff is here: D13936
Jul 4 2018
Jul 3 2018
Jul 2 2018
Jun 28 2018
Yeah this was with cmake I'll try with qmake and let you know.
@bruns I added some tests and a class that implements the algorithm (without a db). Let me know what you think!
Jun 26 2018
@bruns decoupling makes sense, but eventually there will be a need for a db right?
And I will definitely make those test cases, but I may ask for some help on how they're done in baloo.
Jun 25 2018
@dfaure if a user was trying to find LibreOffice 6.0 Writer
Jun 23 2018
@aacid it's rebased, what else do I need to change? Thanks!
Use ES5 var instead of ES6 const
Jun 22 2018
Jun 14 2018
Rebasing onto latest master.
Jun 11 2018
Rebase back to v17.12.2
Rebased onto Applications/18.04