Discuss how to handle different icon sets
AbandonedPublic

Authored by michaeleden on Jul 3 2018, 6:41 AM.

Details

Reviewers
camiloh
Summary

It seems that Android uses the Luv icon set and desktop uses the system icon set. I'm using the breeze theme so there are no icons for 'Tracks' or 'Albums', however using only the Luv theme (which this diff implements) leaves out key icons like for 'Collections' or 'Youtube'. Screenshots are provided below:

I feel that vvave should either try using the system's icons and fall back to an internal icon set or never use the system's icons (for consistency). Either way code to formalize all the icons will probably have to be written and an icon set that covers all use cases will have to be picked. Vvave already uses 'Material Design Icons' so that seems like a natural pack to choose.

Which option do you think is best @camiloh ? Lmk & I'll update this diff.

Diff Detail

Repository
R899 Vvave Media Player
Branch
fix/luv-icons
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 574
Build 586: arc lint + arc unit
michaeleden requested review of this revision.Jul 3 2018, 6:41 AM
michaeleden created this revision.
michaeleden edited the summary of this revision. (Show Details)Jul 3 2018, 6:42 AM
michaeleden edited the summary of this revision. (Show Details)Jul 3 2018, 6:54 AM
michaeleden abandoned this revision.Sep 13 2019, 7:56 AM