rthomas (Ronnie Thomas)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
May 7 2017, 6:38 PM (359 w, 3 d)
Availability
Available

Recent Activity

Feb 6 2019

rthomas added a comment to D18689: plasma-nm Connection Icon not showing correct icon when using a bridge.

Hey Jan, please make this commit on my behalf as I don't have commit access right now and I'm not planning to apply for it any time soon.

Feb 6 2019, 2:45 PM · Plasma
rthomas updated the diff for D18689: plasma-nm Connection Icon not showing correct icon when using a bridge.

I've also moved isConnectionTypeVirtual() in uiutils.cpp. Forgot to do that!

Feb 6 2019, 12:16 AM · Plasma
rthomas updated the diff for D18689: plasma-nm Connection Icon not showing correct icon when using a bridge.

Moved isConnectionTypeVirtual() below isConnectionTypeSupported()

Feb 6 2019, 12:06 AM · Plasma

Feb 5 2019

rthomas updated the diff for D18689: plasma-nm Connection Icon not showing correct icon when using a bridge.

Shouldn't have removed the existing condition to check if the connection object is not valid. Added it back.

Feb 5 2019, 2:08 AM · Plasma
rthomas updated the diff for D18689: plasma-nm Connection Icon not showing correct icon when using a bridge.

Hey Jan,

Feb 5 2019, 1:12 AM · Plasma

Feb 3 2019

rthomas added a comment to D18689: plasma-nm Connection Icon not showing correct icon when using a bridge.

This doesn't seem to be a correct fix. We should be using icon for whatever connection is primary, not only when primary connection is wifi / ethernet / modem / bluetooth. If you check NM on dbus, what is the primary connection there? Is it the bridge one?

Feb 3 2019, 7:17 PM · Plasma
rthomas added a comment to D18689: plasma-nm Connection Icon not showing correct icon when using a bridge.

Correct fix would be to set icon for bridge connections in the last else branch at the end of setIcons() method, probably guarded with a condition whether the user has enabled virtual connections.

Feb 3 2019, 6:41 PM · Plasma
rthomas updated the diff for D18689: plasma-nm Connection Icon not showing correct icon when using a bridge.

Should have used '&&' in the if statement instead of '||'. We want to shift to the PrimaryConnection if the Device is not among Wifi, Ethernet, Modem and Bluetooth.

Feb 3 2019, 2:59 PM · Plasma

Feb 2 2019

rthomas requested review of D18689: plasma-nm Connection Icon not showing correct icon when using a bridge.
Feb 2 2019, 10:44 PM · Plasma

May 28 2017

rthomas added a comment to D5870: Match subsequences in application runner.

@aacid : I have assigned the Plasma-Workspace repo to this revision. Please commit this patch on my behalf. I think I'll hold on for a while before applying for commit access.

May 28 2017, 6:15 AM · Plasma
rthomas set the repository for D5870: Match subsequences in application runner to R120 Plasma Workspace.
May 28 2017, 6:11 AM · Plasma

May 25 2017

rthomas added a comment to D5870: Match subsequences in application runner.

No, I don't have commit access yet. Can I apply for a developer account now? I haven't done so until now.

May 25 2017, 7:07 AM · Plasma

May 24 2017

rthomas created D5963: Fix regex in convert-kurl.pl.
May 24 2017, 6:24 PM

May 20 2017

rthomas added a comment to D5870: Match subsequences in application runner.

Uh.. ping?

May 20 2017, 3:53 PM · Plasma

May 16 2017

rthomas updated the diff for D5870: Match subsequences in application runner.
  • Splitting the query using splitRef() instead of split()
  • Using QLatin1Char(' ') as the separator to split the query
May 16 2017, 3:57 PM · Plasma
rthomas added inline comments to D5870: Match subsequences in application runner.
May 16 2017, 3:34 PM · Plasma

May 15 2017

rthomas created D5870: Match subsequences in application runner.
May 15 2017, 4:28 PM · Plasma

May 8 2017

This is a test notification, sent at Mon, May 8, 10:38 PM.
May 8 2017, 5:08 PM
This is a test notification, sent at Mon, May 8, 10:38 PM.
May 8 2017, 5:08 PM
rthomas added a comment to D5770: Avoid showing wrong timezone suffix in krunner time.

I couldn't find a reasonable way to set the timezone from the returned country, so I think it's best to avoid it for now.

May 8 2017, 4:47 PM · Plasma
rthomas added reviewers for D5770: Avoid showing wrong timezone suffix in krunner time: davidedmundson, broulik.
May 8 2017, 3:07 PM · Plasma
rthomas created D5770: Avoid showing wrong timezone suffix in krunner time.
May 8 2017, 3:05 PM · Plasma