Improve dialer UI and format phone number

Authored by michaeleden on Jul 7 2018, 9:34 PM.



This makes the buttons more evenly spaced and formats the number as you type!


new (updated):

The plan is to bring the entire dialer page down to about half its current size to support searching through contacts as one dials a number.

Diff Detail

R20 Plasma Phone Components
No Linters Available
No Unit Test Coverage
Build Status
Buildable 818
Build 831: arc lint + arc unit
michaeleden requested review of this revision.Jul 7 2018, 9:34 PM
michaeleden created this revision.
michaeleden edited the summary of this revision. (Show Details)Jul 7 2018, 9:39 PM
michaeleden added reviewers: bshah, Plasma: Mobile.
michaeleden edited the summary of this revision. (Show Details)
bshah added a reviewer: mart.Jul 9 2018, 1:43 PM
mart added inline comments.Jul 10 2018, 7:50 PM

if you like to have it kirigami-friendly you should avoid pixel sizes anywhere, use point size for fonts, and Kirigami.Units.smallSpacing/largespacing for spacings

Remove pixel sizes for point and units and add libphonenumber requirement to cmakelists

  • Use full width characters for special dialpad chars
  • Log qt output to stdout as well as log file
  • Fix compiler warnings, remove some .moc files
michaeleden edited the summary of this revision. (Show Details)Jul 12 2018, 6:01 AM

Use phone formatting closer to android dialer

mart accepted this revision.Jul 17 2018, 2:57 PM
This revision is now accepted and ready to land.Jul 17 2018, 2:57 PM

Maybe out of scope here, but I'd really like to see borders around the number buttons. I've used software dialers where the numbers didn't look buttonlike, and they always felt slower and more awkward to use.

@ngraham they are highlighted when pressed, is that what you mean? or do you have an example?

I mean, they have an outline when not hovered. As in, they look like buttons. :)

michaeleden closed this revision.Aug 2 2018, 7:48 PM

@ngraham I wouldn't mind if you made that change, but I'll keep it like this for now.