Update Logtalk language syntax support
ClosedPublic

Authored by pmoura on Apr 13 2020, 2:59 PM.

Details

Summary

Adds support for new built-predicates and fixes escape sequences in quoted atoms

Test Plan

Tested manually by overriding the file bundled with the latest Kate macOS binary and the syntax highlight source test file from the Logtalk distribution.

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
pmoura created this revision.Apr 13 2020, 2:59 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptApr 13 2020, 2:59 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
pmoura requested review of this revision.Apr 13 2020, 2:59 PM
cullmann requested changes to this revision.Apr 15 2020, 6:16 PM
cullmann added a subscriber: cullmann.

Change looks reasonable, but could that testfile be added to our autotests directory? (or the file we have there extended)
The current auto test file is autotests/input/highlight.lgt I assume.

This revision now requires changes to proceed.Apr 15 2020, 6:16 PM

There is a more recent version of that file. How to proceed? By creating a new review request for that file with a diff? Or is there a way to associate it with this review request?

cullmann accepted this revision.Apr 25 2020, 11:59 AM

Ok, I see, there is an extra request for the new hl test file.
Then let's approve this one.

This revision is now accepted and ready to land.Apr 25 2020, 11:59 AM
This revision was automatically updated to reflect the committed changes.