Differential D26888

work around to fully support the windows backend
Needs ReviewPublic
Actions

Authored by brute4s99 on Jan 24 2020, 3:37 AM.

Details

Reviewers
vonreth
broulik
Group Reviewers
KDE Connect
Summary

really support the windows backend.

Diff Detail

Repository
R289 KNotifications
Branch
arcpatch-D26888
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25351
Build 25369: arc lint + arc unit
brute4s99 created this revision.Jan 24 2020, 3:37 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 24 2020, 3:37 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
brute4s99 requested review of this revision.Jan 24 2020, 3:37 AM
brute4s99 abandoned this revision.Jan 25 2020, 1:01 PM
brute4s99 added reviewers: vonreth, broulik, KDE Connect.
brute4s99 reclaimed this revision.Jan 27 2020, 6:47 AM

sorry. abandoned wrong diff

meven added a subscriber: meven.Jan 27 2020, 9:13 AM
meven added inline comments.
src/notifybysnore.cpp
164

no ; here

albertvaka added a subscriber: albertvaka.Feb 9 2020, 7:21 PM
albertvaka added inline comments.
src/notifybysnore.cpp
146–150

This could become:

if (id == -1) {
    id = 0
}
emit actionInvoked(id, actionNum);

To not duplicate the emit line. Still, it feels hackish.

brute4s99 updated this revision to Diff 80333.Apr 16 2020, 10:15 PM

work around to fully support the windows backend

brute4s99 marked 2 inline comments as done.Apr 16 2020, 10:15 PM
albertvaka added a comment.Apr 16 2020, 10:25 PM

@vonreth @broulik Can you folks give this a final review? We have been building KDE Connect for Windows off a custom branch with this patch, but I would like to use official builds of KNotifications so it would be great if we can merge it.

Revision Contents
Changeset List

PathPackages
Msrc/notifybysnore.cpp (37 lines)

Diff 80333

View Options

src/notifybysnore.cpp

Loading...