Differential D22554

Finer No-Dbus on Windows
AbandonedPublic
Actions

Authored by brute4s99 on Jul 19 2019, 10:51 AM.

Details

Reviewers
nicolasfella
broulik
Summary

remove another dependency related to DBus from Windows builds

Diff Detail

Repository
R289 KNotifications
Branch
arcpatch-D22554
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14316
Build 14334: arc lint + arc unit
brute4s99 created this revision.Jul 19 2019, 10:51 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald TranscriptJul 19 2019, 10:51 AM
brute4s99 requested review of this revision.Jul 19 2019, 10:51 AM
nicolasfella added inline comments.Jul 19 2019, 10:55 AM
src/CMakeLists.txt
90

Now we have two checks for this

brute4s99 marked an inline comment as done.Jul 19 2019, 11:05 AM
andriusr added a subscriber: andriusr.Jul 19 2019, 12:03 PM
andriusr added inline comments.
src/CMakeLists.txt
79

extra endif() ?

nicolasfella added a comment.Jul 19 2019, 1:16 PM

Now HAVE_DBUSMENUQT won't be set. Previously it was set to 0 in this case

brute4s99 added a comment.Jul 19 2019, 5:11 PM
In D22554#497984, @nicolasfella wrote:

Now HAVE_DBUSMENUQT won't be set. Previously it was set to 0 in this case

Which line number are you referring to?

brute4s99 marked an inline comment as done.Jul 19 2019, 5:37 PM
nicolasfella added inline comments.Jul 19 2019, 5:42 PM
src/CMakeLists.txt
68

Here

brute4s99 updated this revision to Diff 62383.Jul 23 2019, 9:49 AM

let's put a pin in this for a while until I get a better solution for DBus on Windows

nicolasfella added a comment.Apr 14 2020, 3:24 PM

@brute4s99 Is this still relevant?

brute4s99 added a comment.Apr 28 2020, 10:32 PM

closing this diff.

brute4s99 abandoned this revision.Apr 28 2020, 10:33 PM

Revision Contents
Changeset List

PathPackages
Msrc/CMakeLists.txt (25 lines)

Diff 62383

View Options

src/CMakeLists.txt

Loading...