SnoreToast fails to build on MSYS2 due to missing
which apparently is not available for this compiler.
This patch changes dependency on SnoreToast from required to optional.
As a result, it allows to actually build KNotifications on MSYS2.
Details
Details
Built application on Windows, which links to KNotifications.
Diff Detail
Diff Detail
- Repository
- R289 KNotifications
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 27140 Build 27158: arc lint + arc unit
Comment Actions
SnoreToast fails to build on MSYS2 due to missing
which apparently is not available for this compiler.
I'm sorry, missing what exactly?
Comment Actions
Well the code is header only, so gcc can use it too.
Everything needed is to pull in a binary, that's not ideal but I guess its better than no notifications on Windows.
Comment Actions
I see. I've updated the patch. Linking to downloaded library is now possible, and there is a fallback if no library is present.
Comment Actions
I still do not understand the utility of this patch. What do you hope to fix by this patch exactly?
SnoreToast fails to build on MSYS2 due to missing
which apparently is not available for this compiler.
which compiler are you referring to here?
This patch changes dependency on SnoreToast from required to optional.
As a result, it allows to actually build KNotifications on MSYS2.
why do you want to build KNotifications on MSYS2?
More inline comments follow, please take a look.
| CMakeLists.txt | ||
|---|---|---|
| 77 | why do we need Qt5Network for all kinds of Windows builds? | |
| 80 | the option should be MSYS specific rather than being SnoreToast specific. | |
Comment Actions
Thanks for looking into that matter.
I hope to fix KNotifications build on MSYS2 where there is no possibility to compile SnoreToast.
It was possible to compile KNotifications without neither compiling SnoreToast, nor downloading its binaries before. This patch brings that possibility while allowing to build with SnoreToast enabled as well.
SnoreToast fails to build on MSYS2 due to missing
which apparently is not available for this compiler.which compiler are you referring to here?
MinGW from MSYS2.
This patch changes dependency on SnoreToast from required to optional.
As a result, it allows to actually build KNotifications on MSYS2.why do you want to build KNotifications on MSYS2?
I have my own build of KF5 libraries which I use to package app that I forked.
More inline comments follow, please take a look.
| CMakeLists.txt | ||
|---|---|---|
| 77 | We don't need it, but if it would be found together with SnoreToast then SnoreToast would be enabled by default in MSVC and MSYS2 builds. | |
| 80 | I think it should be SnoreToast specific because if you download the binary of SnoreToast then you could possibly compile KNotifications with it on MSYS2. | |
| CMakeLists.txt | ||
|---|---|---|
| 75 | please maintain the REQUIRED call for normal Windows builds. | |
| CMakeLists.txt | ||
|---|---|---|
| 75 | Is it ready to land now? | |