Extend KDE Connect to images, video, audio, selection
AbandonedPublic

Authored by broulik on Jun 22 2019, 10:46 AM.

Details

Reviewers
fvogt
davidedmundson
nicolasfella
Group Reviewers
Plasma
Summary

This lets it share image, video, and audio URLs as well as text selection via KDE Connect.
For text selection a separate entry "Copy to" is added.

Test Plan

Right clicked image, sent it to KDE connect, had my browser open it. Same for video player.

Only compat issue with older host is that sending a text selection will instead just open the page if not supported but I think that's pretty minor.

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Jun 22 2019, 10:46 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 22 2019, 10:46 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jun 22 2019, 10:46 AM
broulik updated this revision to Diff 60315.
  • Simplify
broulik updated this revision to Diff 60324.Jun 22 2019, 11:18 AM
  • Fix id mismatch
fvogt added inline comments.Jun 22 2019, 1:39 PM
host/kdeconnectplugin.cpp
188

This looks like an ugly hack. Is there any reason not to add a new shareText event?

broulik planned changes to this revision.Jun 22 2019, 1:49 PM

Will add a separate shareText method.
Will re-introduce some subsystem status query thing and then set kdeconnect plugin to version 2 and then only show the "copy" entry if host host has version >= 2

broulik abandoned this revision.May 29 2020, 7:56 AM

We have image/video/audio now, text selection I might add later but maybe not soo useful after alll