[Folder View] Load icon only for isPopup case

Authored by broulik on Sep 2 2019, 12:34 PM.


Group Reviewers

There's no point in loading the icon when it cannot be seen.

Test Plan

No longer have desktop containment query the icon name of the root item
Panel icon still shows proper icon and updates live

Diff Detail

R119 Plasma Desktop
Lint Skipped
Unit Tests Skipped
broulik created this revision.Sep 2 2019, 12:34 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 2 2019, 12:34 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Sep 2 2019, 12:34 PM
broulik edited the test plan for this revision. (Show Details)
hein requested changes to this revision.Sep 4 2019, 12:09 AM

Hmm, I'm not a fan. That only the isPopup case ends up showing the icon in the shell is something you and I know from the outside, but I don't think a widget should be making that assumption. Otherwise we bake implementation details of the containents into widget code, and if we ever change the former we have to fix the widgets. Take for example a widget list like the one bandied about for config modes on the sprint.

This revision now requires changes to proceed.Sep 4 2019, 12:09 AM
broulik abandoned this revision.Fri, May 29, 7:05 AM