bdhruve (Bhavisha Dhruve)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Feb 22 2016, 11:06 AM (143 w, 2 d)
Availability
Available

Recent Activity

Thu, Nov 15

bdhruve added a comment to T8712: Forming a welcome team to guide newcomers.

Hello Everyone,

We have created a Matrix group: https://matrix.to/#/#kde-welcome:matrix.org
Anyone interested to be part of the team, please feel free to join :)

Awesome!

Is this Matrix-only, or is it bridged to IRC?

Thu, Nov 15, 3:27 PM · Goal settings 2017

Wed, Nov 14

bdhruve added a comment to T8712: Forming a welcome team to guide newcomers.

Hello Everyone,

Wed, Nov 14, 4:19 AM · Goal settings 2017

Oct 13 2018

bdhruve added a comment to T8712: Forming a welcome team to guide newcomers.

Hi @bdhruve , before responding to your suggestions, I would like to be sure if you are referring to this guide: https://community.kde.org/Plasma/DeveloperGuide

Or is it about something else?

Oct 13 2018, 3:34 AM · Goal settings 2017

Oct 3 2018

bdhruve added a comment to T8712: Forming a welcome team to guide newcomers.

Well from my end i was going through the Kde-dev-guide, and i offered a few suggestions to Valorie would love to share here as well,
ln the Dev guide it states KDE from developers viewpoint, we could add some thing like KDE from a new contributor point of view or some other nice term, and in this we could give information about:

Oct 3 2018, 1:56 AM · Goal settings 2017
bdhruve added a comment to T8712: Forming a welcome team to guide newcomers.

A good next step might be creating a formal Phabricator group for this, to which people could add themselves. Then for example we could document that new contributors should add the group as a reviewer for their first patches, which could help make sure that those critical first patches don't get lost and always have someone available who can help. Thoughts?

Oct 3 2018, 1:49 AM · Goal settings 2017
bdhruve updated the task description for T8712: Forming a welcome team to guide newcomers.
Oct 3 2018, 1:45 AM · Goal settings 2017

Jul 19 2018

bdhruve committed R1005:035fa0ecccf0: Verify if favorite and alternative changes persist across session restart. (authored by bdhruve).
Verify if favorite and alternative changes persist across session restart.
Jul 19 2018, 11:01 AM
bdhruve closed D13560: Verify if favorite and alternative changes persist across session restart..
Jul 19 2018, 11:01 AM
bdhruve updated the diff for D13560: Verify if favorite and alternative changes persist across session restart..

Removed kicker-logout needle.

Jul 19 2018, 10:24 AM
bdhruve updated the diff for D13560: Verify if favorite and alternative changes persist across session restart..

Rebase to master branch and remove wait_still_screen.

Jul 19 2018, 10:00 AM

Jul 16 2018

bdhruve updated the diff for D13560: Verify if favorite and alternative changes persist across session restart..

Add Logout function using krunner in basetest

Jul 16 2018, 12:26 PM

Jul 5 2018

bdhruve added a comment to D13560: Verify if favorite and alternative changes persist across session restart..

Does this really need a test? Did this ever break?

It appears to me this is essentially doing a test of kconfig/plasmashell's use of kconfig, which should be much more efficiently tested via a unit test (and likely already is)

Jul 5 2018, 12:25 PM
bdhruve updated the diff for D13560: Verify if favorite and alternative changes persist across session restart..

Add logout function in basetest

Jul 5 2018, 12:02 PM

Jun 15 2018

bdhruve requested review of D13560: Verify if favorite and alternative changes persist across session restart..
Jun 15 2018, 12:54 PM

Jun 12 2018

bdhruve committed R1005:073e6da1e9fc: Add test to verify the Alternative Menu (authored by bdhruve).
Add test to verify the Alternative Menu
Jun 12 2018, 11:36 AM
bdhruve closed D13410: Add test to verify the Alternative Menu.
Jun 12 2018, 11:36 AM
bdhruve added a comment to D13410: Add test to verify the Alternative Menu.

As @bshah pointed on IRC this may or may not need updating of the needles.

The plasma-folder test now switches the background to a constant color. Some of the needle failures were due to plasma being partially translucent and thus the wallpaper bleeding into the needles. As we didn't want to disable all desktop effects, I instead opted to fixate the color. As a result your new needles might not match. However, out of the existing needles only one had a problem there, so you may be fine.

In any case, I am fine with landing it and fixing it through jenkins if redoing the needles locally seems like too much work.

Jun 12 2018, 11:12 AM

Jun 11 2018

bdhruve updated the diff for D13410: Add test to verify the Alternative Menu.

Reset back to kickoff at end of test

Jun 11 2018, 12:55 PM

Jun 7 2018

bdhruve added a comment to D13410: Add test to verify the Alternative Menu.

To explain the comment in test plan, while testing it in plasma_desktop suite it is not able to assert the folder_desktop screen even though the last screen-shot in plasma-favorites.pm is folder-desktop screen. However test itself works fine individually.

Jun 7 2018, 4:37 PM
bdhruve requested review of D13410: Add test to verify the Alternative Menu.
Jun 7 2018, 4:16 PM

Jun 5 2018

bdhruve committed R1005:7f0128f74f24: Extended test for verifying the Remove from Favorite option. (authored by bdhruve).
Extended test for verifying the Remove from Favorite option.
Jun 5 2018, 10:52 AM
bdhruve closed D13239: Extended test for verifying the Remove from Favorite option..
Jun 5 2018, 10:52 AM

Jun 2 2018

bdhruve updated the diff for D13239: Extended test for verifying the Remove from Favorite option..

Fixed issues mentioned by sitter

Jun 2 2018, 12:44 PM

Jun 1 2018

bdhruve updated the diff for D13239: Extended test for verifying the Remove from Favorite option..

Fixed issues mentioned by bshah

Jun 1 2018, 10:37 AM

May 31 2018

bdhruve requested review of D13239: Extended test for verifying the Remove from Favorite option..
May 31 2018, 2:20 PM

May 29 2018

bdhruve committed R1005:ff63650c9dfc: Add test to verify the Add to Favorite option. (authored by bdhruve).
Add test to verify the Add to Favorite option.
May 29 2018, 3:29 PM
bdhruve closed D13132: Add test to verify the Add to Favorite option..
May 29 2018, 3:29 PM

May 28 2018

bdhruve updated the diff for D13132: Add test to verify the Add to Favorite option..
  • Added plasma_favorite.pm in the main plasma test suite
  • Get rid of fractional pixel values
  • Fixed coding style issue
May 28 2018, 4:50 PM

May 26 2018

bdhruve added a reviewer for D13132: Add test to verify the Add to Favorite option.: sitter.
May 26 2018, 9:04 AM
bdhruve added a reviewer for D13132: Add test to verify the Add to Favorite option.: bshah.
May 26 2018, 9:02 AM
bdhruve requested review of D13132: Add test to verify the Add to Favorite option..
May 26 2018, 8:20 AM

Jan 29 2018

bdhruve claimed T7601: OpenQA plasma mobile.
Jan 29 2018, 1:30 PM · Plasma: Mobile

Oct 27 2017

bdhruve committed R659:c42539a5982c: Fixed the Font Size issue. (authored by bdhruve).
Fixed the Font Size issue.
Oct 27 2017, 4:08 AM
bdhruve closed D8501: Fixed the Font Size issue..
Oct 27 2017, 4:08 AM

Oct 26 2017

bdhruve created D8501: Fixed the Font Size issue..
Oct 26 2017, 3:13 PM
bdhruve committed R659:c8ce4e08b826: Fix crash on koko startup. (authored by bdhruve).
Fix crash on koko startup.
Oct 26 2017, 9:23 AM
bdhruve closed D8472: Fix crash on koko startup..
Oct 26 2017, 9:23 AM

Oct 25 2017

bdhruve created D8472: Fix crash on koko startup..
Oct 25 2017, 1:18 PM

Aug 14 2017

bdhruve updated subscribers of D5579: Introduce QQuickItem to nest kwin_wayland.
Aug 14 2017, 7:48 AM · KWin, Plasma on Wayland
bdhruve updated subscribers of D5579: Introduce QQuickItem to nest kwin_wayland.

Ping @graesslin @davidedmundson, should I do any more changes or this can be submitted?

Aug 14 2017, 7:43 AM · KWin, Plasma on Wayland

May 4 2017

bdhruve added a comment to D5579: Introduce QQuickItem to nest kwin_wayland.

Ping. Do i have to make any more changes?

May 4 2017, 5:27 AM · KWin, Plasma on Wayland

Apr 25 2017

bdhruve added a comment to D5579: Introduce QQuickItem to nest kwin_wayland.

This patch is follow-up of D1989.

Apr 25 2017, 12:58 PM · KWin, Plasma on Wayland
bdhruve created D5579: Introduce QQuickItem to nest kwin_wayland.
Apr 25 2017, 12:54 PM · KWin, Plasma on Wayland
bdhruve abandoned D1989: Introduce QQuickItem to nest kwin_wayland.

This revision was started last year which had lot of discussions. Had a few of unfinished issues to be fixed as well.
So creating a new one which has fixed the last few issues addressed by @graesslin and @davidedmundson. And i am extremely apologetic for such a long delay.

Apr 25 2017, 12:17 PM · KWin, Plasma on Wayland

Aug 22 2016

bdhruve added a comment to D1989: Introduce QQuickItem to nest kwin_wayland.

I would like to see this integrated. But I think a few things need to be done:

  • I would love to see the example you had in your blog post added to tests
  • I'm still unhappy about the name KWinQml - it's just not saying what it is. And actually it's not Qml at all. It's a declarative implementation. Might need brainstorming, maybe even broader on the mailinglist.
Aug 22 2016, 6:48 AM · KWin, Plasma on Wayland

Aug 10 2016

bdhruve added a comment to D1989: Introduce QQuickItem to nest kwin_wayland.

Mark comments as done.

Aug 10 2016, 7:59 AM · KWin, Plasma on Wayland
bdhruve updated the diff for D1989: Introduce QQuickItem to nest kwin_wayland.

Fix keyEvent code for non-X11 platforms.

Aug 10 2016, 7:35 AM · KWin, Plasma on Wayland

Aug 9 2016

bdhruve added a comment to D1989: Introduce QQuickItem to nest kwin_wayland.

I just remembered: on X11 one needs to subtract 8 from the key code...

Aug 9 2016, 8:18 AM · KWin, Plasma on Wayland
bdhruve updated the diff for D1989: Introduce QQuickItem to nest kwin_wayland.

Added back the keyEvent handling and works perfectly now.

Aug 9 2016, 8:06 AM · KWin, Plasma on Wayland
bdhruve updated the diff for D1989: Introduce QQuickItem to nest kwin_wayland.

Remove keyEvent handling.

Aug 9 2016, 7:35 AM · KWin, Plasma on Wayland

Aug 8 2016

bdhruve added a comment to D1989: Introduce QQuickItem to nest kwin_wayland.
  • KeyPress events to send keys.

    However, keyevents are not working as it should, if i press 'a' it types something different.

might be that this is just not possible to send key events like that. In general QKeyEvent delivers the keysym. That is the scan code translated through the keyboard layout. The nativeSccanCode should have the original value but I would not trust it completely.

Maybe leave key events out for the moment as an we don't necessarily need key events.

Aug 8 2016, 3:33 PM · KWin, Plasma on Wayland

Aug 7 2016

bdhruve updated the diff for D1989: Introduce QQuickItem to nest kwin_wayland.

Pass different input events from QML to Kwin,

Aug 7 2016, 12:29 PM · KWin, Plasma on Wayland

Jul 21 2016

bdhruve added inline comments to D1989: Introduce QQuickItem to nest kwin_wayland.
Jul 21 2016, 12:35 PM · KWin, Plasma on Wayland
bdhruve updated the diff for D1989: Introduce QQuickItem to nest kwin_wayland.
  • Performed the nullptr check for the buffer attached to the surface.
  • Removed qDebug() statements.
  • Fixed coding style.
  • Fixed issue of only first frame rendering.
Jul 21 2016, 12:20 PM · KWin, Plasma on Wayland

Jul 19 2016

bdhruve updated the diff for D1989: Introduce QQuickItem to nest kwin_wayland.
  • Fixed automatic selection of backend to look for WAYLAND_SOCKET also
  • Rendering kwin instance
  • Fixed minor issues.
Jul 19 2016, 12:08 PM · KWin, Plasma on Wayland

Jul 12 2016

bdhruve added a comment to D1989: Introduce QQuickItem to nest kwin_wayland.

Looks good now and I think we can look into the next steps: rendering the KWin instance you launch. The launched KWin instance connects to your Wayland server, binds to the Shell and will create a ShellSurface. That you will get through a signal on m_shell - compare wayland_server.cpp:148. I would as a next step try to hook into this and see whether the surface gets created. Once you have that you can look into rendering it.

For that the ShellSurfaceInterface is connected to a SurfaceInterface. The rendering happens on the SurfaceInterface. There's a damaged signal which you should use to trigger a repaint of your QQuickItem. When rendering you can access the buffer on the SurfaceInterface. If KWin uses KWIN_COMPOSE=Q you can access the buffer as a QImage and just render it. Pretty straight forward - hopefully. But first try to see whether you get the ShellSurface created. If not we need to look into what goes wrong.

I've added the slot for checking if surface gets created but signal doesn't get emitted. Would you please show me the way to proceed further now.

Jul 12 2016, 6:41 AM · KWin, Plasma on Wayland

Jul 8 2016

bdhruve added a comment to D1989: Introduce QQuickItem to nest kwin_wayland.

Looks good now and I think we can look into the next steps: rendering the KWin instance you launch. The launched KWin instance connects to your Wayland server, binds to the Shell and will create a ShellSurface. That you will get through a signal on m_shell - compare wayland_server.cpp:148. I would as a next step try to hook into this and see whether the surface gets created. Once you have that you can look into rendering it.

For that the ShellSurfaceInterface is connected to a SurfaceInterface. The rendering happens on the SurfaceInterface. There's a damaged signal which you should use to trigger a repaint of your QQuickItem. When rendering you can access the buffer on the SurfaceInterface. If KWin uses KWIN_COMPOSE=Q you can access the buffer as a QImage and just render it. Pretty straight forward - hopefully. But first try to see whether you get the ShellSurface created. If not we need to look into what goes wrong.

Jul 8 2016, 7:26 AM · KWin, Plasma on Wayland
bdhruve updated the diff for D1989: Introduce QQuickItem to nest kwin_wayland.

Fixed issues mentioned by @graesslin and connect to surfaceCreated.

Jul 8 2016, 7:18 AM · KWin, Plasma on Wayland

Jul 6 2016

bdhruve updated the diff for D1989: Introduce QQuickItem to nest kwin_wayland.

Fixed issues mentioned by @graesslin.

Jul 6 2016, 7:48 AM · KWin, Plasma on Wayland

Jul 4 2016

bdhruve updated the diff for D1989: Introduce QQuickItem to nest kwin_wayland.

Fixed issues mentioned by @graesslin.

Jul 4 2016, 11:46 AM · KWin, Plasma on Wayland
bdhruve added a comment to D1989: Introduce QQuickItem to nest kwin_wayland.

I would like to see a test case which verifies that it starts the kwin_wayland instance and terminates it again.

Jul 4 2016, 11:39 AM · KWin, Plasma on Wayland

Jul 1 2016

bdhruve updated the diff for D1989: Introduce QQuickItem to nest kwin_wayland.

Fixed code as per mentioned by @bshah.

Jul 1 2016, 9:48 AM · KWin, Plasma on Wayland

Jun 29 2016

bdhruve updated the diff for D1989: Introduce QQuickItem to nest kwin_wayland.

Fixed copyright header.

Jun 29 2016, 10:53 AM · KWin, Plasma on Wayland
bdhruve updated the diff for D1989: Introduce QQuickItem to nest kwin_wayland.

Fixed issues mentioned by @bshah

Jun 29 2016, 10:39 AM · KWin, Plasma on Wayland

Jun 28 2016

bdhruve added inline comments to D1989: Introduce QQuickItem to nest kwin_wayland.
Jun 28 2016, 11:55 AM · KWin, Plasma on Wayland
bdhruve updated the diff for D1989: Introduce QQuickItem to nest kwin_wayland.

Fixed issues addressed by @graesslin

Jun 28 2016, 11:24 AM · KWin, Plasma on Wayland

Jun 24 2016

bdhruve retitled D1989: Introduce QQuickItem to nest kwin_wayland from to Introduce QQuickItem to nest kwin_wayland.
Jun 24 2016, 6:46 AM · KWin, Plasma on Wayland

Jun 3 2016

bdhruve committed R108:6cae5f7ab925: Integrated FakeInput touch events into InputRedirection. (authored by bdhruve).
Integrated FakeInput touch events into InputRedirection.
Jun 3 2016, 2:22 PM
bdhruve closed D1758: Integrated FakeInput touch events into InputRedirection. by committing R108:6cae5f7ab925: Integrated FakeInput touch events into InputRedirection..
Jun 3 2016, 2:22 PM · Plasma
bdhruve retitled D1758: Integrated FakeInput touch events into InputRedirection. from to Integrated FakeInput touch events into InputRedirection..
Jun 3 2016, 11:31 AM · Plasma

May 31 2016

bdhruve committed R127:7d460ed00254: Add support for touch events in fakeinput protocol and interface. (authored by bdhruve).
Add support for touch events in fakeinput protocol and interface.
May 31 2016, 11:14 AM
bdhruve closed D1672: Add support for touch events in fakeinput protocol and interface. by committing R127:7d460ed00254: Add support for touch events in fakeinput protocol and interface..
May 31 2016, 11:14 AM · Plasma
bdhruve added a comment to D1672: Add support for touch events in fakeinput protocol and interface..

Thank you @graesslin and @bshah

May 31 2016, 11:13 AM · Plasma
bdhruve added a comment to D1672: Add support for touch events in fakeinput protocol and interface..
In D1672#31870, @bshah wrote:

Looks good.

May 31 2016, 10:49 AM · Plasma
bdhruve updated the diff for D1672: Add support for touch events in fakeinput protocol and interface..

Fixed the coding style issue.

May 31 2016, 10:07 AM · Plasma

May 30 2016

bdhruve updated the diff for D1672: Add support for touch events in fakeinput protocol and interface..

Track touchIds and update autotests.
(I am not sure if i did correctly or not.)

May 30 2016, 11:54 AM · Plasma

May 26 2016

bdhruve added a comment to D1672: Add support for touch events in fakeinput protocol and interface..

I'm wondering: should we ensure that the ids are correct. E.g. a touchUp for id 1 doesn't make sense if we never got a touchDown for id 1. This would require tracking the used ids in FakeInputInterface. But it must be done somewhere - either in the library or by the user of the library.

Martin, do you prefer this change to be done in this review only or in separate review.

I think it would be better to directly integrate it here.

May 26 2016, 10:04 AM · Plasma

May 25 2016

bdhruve added a comment to D1672: Add support for touch events in fakeinput protocol and interface..

I'm wondering: should we ensure that the ids are correct. E.g. a touchUp for id 1 doesn't make sense if we never got a touchDown for id 1. This would require tracking the used ids in FakeInputInterface. But it must be done somewhere - either in the library or by the user of the library.

May 25 2016, 2:20 PM · Plasma
bdhruve updated the diff for D1672: Add support for touch events in fakeinput protocol and interface..

Improved autotest

May 25 2016, 2:02 PM · Plasma
bdhruve updated the diff for D1672: Add support for touch events in fakeinput protocol and interface..

Use position instead of delta in touch motion, and added docs.

May 25 2016, 11:56 AM · Plasma
bdhruve updated the diff for D1672: Add support for touch events in fakeinput protocol and interface..

Fixed issues mentioned by @graesslin and @bshah

May 25 2016, 8:58 AM · Plasma

May 24 2016

bdhruve retitled D1672: Add support for touch events in fakeinput protocol and interface. from to Add support for touch events in fakeinput protocol and interface..
May 24 2016, 12:56 PM · Plasma

Feb 23 2016

bdhruve updated the diff for D1008: [Image Wallpaper] Make color picker visible for all positioning mode..

Fix issues mentioned by broulik.

Feb 23 2016, 7:42 AM · Plasma

Feb 22 2016

bdhruve retitled D1008: [Image Wallpaper] Make color picker visible for all positioning mode. from to [Image Wallpaper] Make color picker visible for all positioning mode..
Feb 22 2016, 2:13 PM · Plasma