- Opens the Application Launcher
- Switches to Application Tab
- Select Office menu
- Right click on Okular and select 'Add to Favorite' option
- Check if Okular appears on Favorite Tab
Details
Details
Diff Detail
Diff Detail
- Repository
- R1005 Neon OpenQA Components
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Looks good, I'd like to get rid of the fractional pixel values though.
Also, I think you can throw this into the main plasma test suite in main.pm I'd say.
| neon/needles/kickoff/kickoff-add-to-favorite.json | ||
|---|---|---|
| 5 | Did you rebuild needler? I thought I fixed decimal precision in a commit recently. Fractional pixels obviously aren't a thing in openqa 😆 | |
| neon/tests/plasma/plasma_favorite.pm | ||
| 26 | excess newline | |
| 48 | excess newline | |
Comment Actions
- Added plasma_favorite.pm in the main plasma test suite
- Get rid of fractional pixel values
- Fixed coding style issue
Comment Actions
Note that this seems to break the test on jenkins once : https://build.neon.kde.org/view/openqa%20%E2%9B%91/job/openqa_xenial_devedition-gitunstable_plasma/41/console but I was then not able to run test on jenkins due to lockscreen test failing at idle needle and on localsetup I can't reproduce this as well.. Not sure what's going on.
Comment Actions
It's been broken since @jriddell landed new stuff but then didn't update the needles.
[Dienstag, 22. Mai 2018] [12:00:54 CEST] <sitter> Riddell: I think you need to update some stuff https://build.neon.kde.org/view/openqa%20%E2%9B%91/job/openqa_xenial_devedition-gitunstable_plasma/ https://build.neon.kde.org/view/openqa%20%E2%9B%91/job/openqa_xenial_useredition_plasma/