Add test to verify the Add to Favorite option.

Authored by bdhruve on May 26 2018, 8:20 AM.


  • Opens the Application Launcher
  • Switches to Application Tab
  • Select Office menu
  • Right click on Okular and select 'Add to Favorite' option
  • Check if Okular appears on Favorite Tab

Diff Detail

R1005 Neon OpenQA Components
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
bdhruve requested review of this revision.May 26 2018, 8:20 AM
bdhruve created this revision.
bdhruve added a reviewer: sitter.
sitter requested changes to this revision.May 28 2018, 7:01 AM

Looks good, I'd like to get rid of the fractional pixel values though.

Also, I think you can throw this into the main plasma test suite in I'd say.


Did you rebuild needler? I thought I fixed decimal precision in a commit recently. Fractional pixels obviously aren't a thing in openqa πŸ˜†


excess newline


excess newline

This revision now requires changes to proceed.May 28 2018, 7:01 AM
bdhruve updated this revision to Diff 35037.May 28 2018, 4:50 PM
  • Added in the main plasma test suite
  • Get rid of fractional pixel values
  • Fixed coding style issue
sitter accepted this revision.May 29 2018, 9:48 AM

LGTM now

This revision is now accepted and ready to land.May 29 2018, 9:48 AM
This revision was automatically updated to reflect the committed changes.
bshah added a comment.May 29 2018, 4:25 PM

Note that this seems to break the test on jenkins once : but I was then not able to run test on jenkins due to lockscreen test failing at idle needle and on localsetup I can't reproduce this as well.. Not sure what's going on.

It's been broken since @jriddell landed new stuff but then didn't update the needles.

[Dienstag, 22. Mai 2018] [12:00:54 CEST] <sitter>	Riddell: I think you need to update some stuff