- Right click on Okular option in favorite tab
- Check if Okular has removed from the favorite tab
Ideally, you can just remove kickoff-remove-from-favorite needle and just use the kickoff-favorite needle here, also I'd say the name kickoff-remove for next needle is confusing...
I suggest to,
Otherwise code looks good to me.
Looks like a really good addition.
I have some style complaints though. Feel free to push when you have them sorted.
So, I only just noticed this, but, in the entire test you can basically replace "right" with 'right' (single quotes when you don't need to interpolate a string).
Additionally you can drop all timeout arguments that are 20 or 30. The default is 30, so unless you need substantial divergence from that (e.g. when something is very IO bound) you don't need to define a timeout out all.
30*2 ➡ 60? ;)
The rule I've been following in the code is: if it is less than a minute use the actual seconds, if it is above a minute multiply 60.
Should kickoff-favorite-removed maybe be called kickoff-favorite and represent the default appearance and the current kickoff-favorite be renamed to kickoff-favorite-okular to represent the kickoff state during the test? You could then also assert kickoff-favorite at the very beginning to assert that the defaults actually look like that even before we change them by adding okular.