:-) Thank you for the lesson.

• Apply suggested changes
• Add KFileMetaData link
• Correct new bug links
• Change recommendation text

• Apply suggested changes

In D12027#242602, @ngraham wrote:

so comment is an extracted property, and userComment is the thing that you can set in Dolphin?

• Apply suggested changes

baloo-widgets become unstable in CI because of this. https://build.kde.org/job/Applications%20baloo-widgets%20kf5-qt5%20SUSEQt5.9/34/testReport/

This is the last patch, before I let baloodb rest for some time.

"Immediately add term to stack when it is complete" as commit message?

Let the rebasing begin... :-) and thanks.

I'm not very familiar with the concept of iterators (yet). To me it looks like auto i = new OrPostingIterator(iters); i->docId(); will return 0 and i->next() returns a valid docId. After that i->docId(); is also valid.
Is this how iterators work? Naively I would expect i->docId(); to be valid after construction or both i->docId(); and i->next() to be invalid.

While reading in IDE realized (*it) resolves to PostingIterator** I got a little dizzy at first, then started to play with this code and came up with this.
In Constructor:

for (PostingIterator* it : m_iterators) {
  if (it == nullptr) {
    m_iterators.erase(&it);
   } else {
     auto docId = it->next();
     if (docId && (docId < m_nextId || m_nextId == 0)) {
       m_nextId = docId;
     }
  }
}

In OrPostingIterator::next()

for (PostingIterator* it : m_iterators) {
    auto docId = it->docId();
    if (docId <= m_docId) {
        docId = it->next();
        if (docId == 0) {
            m_iterators.erase(&it);
            continue;
        }
    }
    m_nextId = m_nextId ? qMin(docId , m_nextId) : docId;
}

I'm not 100% sure if this does exactly the same. But if it does, for readers of my skill level this code will be easier to understand, I guess.
BTW, &it also makes me dizzy :-)

In D12027#242204, @ngraham wrote:

Does this change the string that's displayed in the UI? If so, maybe just "Comments" or "Notes"

After the last build filemetadataitemcounttest failed for no obvious reason (40 elements versus 38 expected). Also since then 'Genre' tag is showing up with an empty value for some audio sample files in Info Panel.
It would be helpful if somebody could confirm this. It might be that something is wrong upstream.
EDIT: Fixed in D12029

• Correct typo

lgtm. Please rebase (preferrably after landing D11826), so I can run the test.

 Cherry Pick Failed!
 Exception 
Command failed with error #1!
COMMAND
git cherry-pick 'arcpatch-D11907'

Couldn't test. This has to rebased first. It doesn't really matter as I had tested this before. Just land it.
Wrt "Test Plan": Most people just write 'make test' otherwise the commit message will be very long.

• Distinguish tests

@bruns Considering the fast pace baloo currently has, I'd like to have a go at this. I think I'd learn a thing or two while trying. Will you watch, please?

• Add 'fallback' test

• Apply suggested changes

• Apply suggested changes

• Internally use QLocale:FormatType

First draft:

What is puzzling me even more: The locale seems to change with the file. ???

Is it normal behaviour that arc diff has to be forced with --update Dxxxxx after a rebase?

In D11242#241225, @ngraham wrote:

In testing this out along with the UI to enable it, I found that it only affected the date shown under "Creation Date" in my PDFs, and not the date shown under "Modified".

• filemetadatadatedisplaytest: Use en_US locale

• Apply some sugested changes

Oops, accepted it too quickly, forgot about the failmessages.

• Remove obsolete comments

• Apply suggested changes

• Add semicolons

Hi!
Regard this as a bug report, please. I did not test, not even built it, because calligra is too large for my little machine.
Hope this is useful.

Citing myself

In T8349#136807, @michaelh wrote:

Just as an idea: Implement user defineable groups. That way users could drop their most important tags/searches/whatever into it and expand and collapse as they wish.

@nicolasfella Beware tags:/ currently is a little broken.

$ kioclient5 ls "tags:/Watched"
Log Horizon?/home/otto/Videos/Log Horizon

In general a agree with you. But what is panels supposed to be? Optimally one should not have to scroll it at all, imho.
Just as an idea: Implement user defineable groups. That way users could drop their most important tags/searches/whatever into it and expand and collapse as they wish.

Wrt tags in panel

$ kioclient5 ls tags:/ | wc -l
353

How is places supposed to cope? (Ok, I should do some clean up, but ~50-100 tags will probably remain.)

I got hold of the wrong end of the stick, we're talking about icons in places here. I change my opinion to the opposite. Colored icons there

1. won't bother me as I rarely use it
2. would in fact help to know which panel is in front (tree or places).
3. The "overlay argument" is probably not valid in this context.

Sorry for the noise.

• Remove duplicated data again

With this D11826 makes a difference. In terms of comprehension I'm also almost there.
testNestedParentheses still has some value as it tests nested parentheses more extensively than the one already there.

Regard this as accepted, but please see D11907 for landing sequence.

• Add (a AND b) AND (c OR d) can be merged as (a AND b AND (c OR D)

• Remove duplicated data

• Rename testOptimizedLogic
• Add a different testOptimizedLogic

Apart from QLatin1Char and token.isEmpty() we're done, I think.
I asked on IRC about the importance of QLatin1Char the answer was "it depends", QLatin1Char is conservative the code as-is more concise. So, change it or leave it, your decision.

• Correct typo(?)

On third thought:
Sooner or later the info sets for tooltips and info panel have to be configured separately. When we see the need for that this will have to change anyway.
I'm thinking of something like the application (dolphin) telling baloo-widgets which properties it wants and how to display them. I think such an approach is more reasonable as baloo-widgets is actually a service provider and as such should make as few decisions as possible. Currently dolphin is baloo-widgets only customer, but I think it could and should be used by other applications too.

In D11897#239375, @cfeck wrote:

The real question is, why Baloo Widgets is not part of Frameworks :P

On second thought:
~/.config/baloofileinformationrc only records properties different from the default (=true).
As a consequence for a configured account we would have to

• Iterate over every possible property of kfilemetadata and
  • check if it set to false,
    • assume true if not.

This somewhat foils our intention of "code clean-up and more explicitness" as it adds computation ( sort of ) to the (purely) declarative approach we see here.
In the end the code as is will be more clear and expressive.

In D11913#239972, @ngraham wrote:

I think there's definite value in code clean-up and more explicitness, and I'm willing to work with you to make sure we don't regress anything. But it doesn't seem like a super high priority.

In D11913#239851, @ngraham wrote:

Let's make sure we don't regress anything in this transition. We're missing "originUrl" a whole bunch of audio-, video-, ePub-, and PDF-related properties that are currently visible by default.

Let me announce that I'm willing to take all the heat from any potential issues, so feel free to offer formal acceptance, folks! :-)

Can I have this as a signature?

For me @16x16: less color == better icon. I like my DE to visually calm.
Also please consider overlays from e.g. dolphin's git plugin they would become less distinct with a colored base icon.

Ping

In D11882#239638, @alexeymin wrote:

Code looks fine, but I did not test if it actually works. ;)

• Move excess space to line 58

Why is sum(+1) == +3 but noone accepted this? Is there social convention I miss?
(It's scaring me off from simply accepting this.)
+1

In D11897#239433, @ngraham wrote:

Forgot that there actually already is a method to ensure that existing users don't get the change: increase the version number of the file. Now the upgrade case works just fine. This is ready for review.