Differential D12007

Add test case for parsing of double opening '(('
ClosedPublic
Actions

Authored by bruns on Apr 7 2018, 2:52 AM.

Details

Reviewers
michaelh
Group Reviewers
Baloo
Commits
R293:4e69ffeab75f: Add test case for parsing of double opening '(('
Summary

Parsing of e.g. "a OR ((b AND c) AND d)" currently fails, as for
the opening '((' only one token is created by the lexer.

CCBUG:392620

Test Plan
QDEBUG : AdvancedQueryParserTest::testNestedParentheses(a OR ((b AND c) AND d))   result term [ OR ( : a (QString)) [ AND ( : b (QString)) ( : c (QString)) ] ( : d (QString)) ]
QDEBUG : AdvancedQueryParserTest::testNestedParentheses(a OR ((b AND c) AND d)) expected term [ OR ( : a (QString)) [ AND ( : b (QString)) ( : c (QString)) ( : d (QString)) ] ]
XFAIL  : AdvancedQueryParserTest::testNestedParentheses(a OR ((b AND c) AND d)) Opening '((' parsed incorrectly

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Apr 7 2018, 2:52 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptApr 7 2018, 2:52 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
bruns requested review of this revision.Apr 7 2018, 2:52 AM
michaelh edited the summary of this revision. (Show Details)Apr 7 2018, 5:23 AM
michaelh edited the summary of this revision. (Show Details)
michaelh added inline comments.Apr 7 2018, 6:24 AM
autotests/unit/lib/advancedqueryparsertest.cpp
278–303

BUG:392620? (Not sure)

291

as above

bruns updated this revision to Diff 31634.Apr 8 2018, 12:56 AM
bruns marked 2 inline comments as done.
michaelh accepted this revision as: michaelh.Apr 8 2018, 9:58 AM
This revision is now accepted and ready to land.Apr 8 2018, 9:58 AM
michaelh added a comment.Apr 8 2018, 9:59 AM

Let the rebasing begin... :-) and thanks.

Closed by commit R293:4e69ffeab75f: Add test case for parsing of double opening '((' (authored by bruns). · Explain WhyApr 8 2018, 3:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 31679

View Options

autotests/unit/lib/advancedqueryparsertest.cpp

Loading...