I think that this implementation is much more cleaner
- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Mar 12 2018
Mar 10 2018
Mar 9 2018
What is the problem with that @laysrodrigues ?
Mar 4 2018
Mar 3 2018
Mar 1 2018
Feb 27 2018
This is a problem that need to be solved in atcore, and not doing workarounds in the printerhost.
Feb 26 2018
Feb 25 2018
Feb 24 2018
Feb 19 2018
In D10645#209208, @rizzitello wrote:In D10645#209201, @patrickelectric wrote:@rizzitello I'll ping the #Solid people about this.
it not so much solid does not work on windows , its more we were not deploying it .. and qt provides us with a system independent way to do this with objects we are already using
Feb 18 2018
Good patch, but before merging it, I would ask for two days after this message to talk with the Solid people about this issue.
@rizzitello I'll ping the #Solid people about this.
isn't this a solid bug ?
A last thing, this patch have some trailing spaces !
Feb 13 2018
Feb 12 2018
Feb 11 2018
In D10436#204545, @rizzitello wrote:In D10436#204418, @patrickelectric wrote:Why we are doing tests with descriptions ?
For exactly the same reason we were checking the toString calls to have full test coverage.
Why we are doing tests with descriptions ?
Feb 10 2018
In D10423#204087, @rizzitello wrote:Future tooltips for any other rectify buttons may need to be tweaked when
we have them.
merged.
Feb 9 2018
The best thing is to replace the gcode class to more generic classes. But
remove this abstraction is a kickback, we can use this class to provide a
lot of important information to the graphic interface, gcode editor, gcode
information and etc.. besides that, isn't hard to maintain what is standard
protocol, only small things change between this main class.
If the gcode class isn't helpfully we need to reformulate it and no remove.
In D10331#203357, @rizzitello wrote:In D10331#203355, @patrickelectric wrote:In D10331#202789, @rizzitello wrote:
- Remove Use of gcodecommands
- Remove GcodeCommands
why ??
- Less code to maintain
- Lots of code for little gain
- Code is slightly more readabe in atcore with only QStringLiteral("G28") instead of GCode::toCommand(GCode::G28));
- GCode::toString was used 5 times. Strings returned by this might not be accurate for your firmware. This class contained lots of strings for the translators that we never used. Maybe this could be used in atelier to help users make gcodes ? ?
Feb 8 2018
In D10331#202789, @rizzitello wrote:
- Remove Use of gcodecommands
- Remove GcodeCommands
Feb 7 2018
we can merge this ?
Feb 4 2018
Feb 2 2018
Use this and not ref
Jan 20 2018
@rizzitello I think that this need more love from our part.
Jan 17 2018
- Firmware: Add default validateCommand
- Firmware: Add default translate
- binary compatibility ftw !
Sith comments
- Firmware: Add default translate
Jan 16 2018
Jan 14 2018
Jan 7 2018
Nov 27 2017
- atcore: Only print if connected
- Do not send serial commands if serial isn't open
- atcore: Only print if connected
Update.
- Do not change to printing states if disconnected
- Do not send serial commands if serial isn't open
Nov 26 2017
Nov 23 2017
should this be M18, no ?
Nov 17 2017
This is working with udp h264 encode ?
Nov 13 2017
Maybe we can add a message output to a bot or something like.