Differential D10330

Safer Disconnect from printer
ClosedPublic
Actions

Authored by rizzitello on Feb 5 2018, 5:21 PM.

Details

Reviewers
laysrodrigues
patrickelectric
tcanabrava
Commits
R232:010244b3ad6b: Safer Disconnect from printer
R232:2786a5400242: Unload Firmware plugin when closing a connection. disconnect serial::recv…
Summary

Unload firmware when disconnected

Diff Detail

Repository
R232 AtCore
Branch
unloadSerial
Lint
No Linters Available
Unit
No Unit Test Coverage
rizzitello requested review of this revision.Feb 5 2018, 5:21 PM
rizzitello created this revision.
rizzitello updated this revision to Diff 26607.Feb 5 2018, 5:34 PM
  • correct local branch
laysrodrigues accepted this revision.Feb 6 2018, 12:35 AM
This revision is now accepted and ready to land.Feb 6 2018, 12:35 AM
patrickelectric added inline comments.Feb 7 2018, 6:39 PM
src/atcore.cpp
373

Add firmware name and path ?

rizzitello added a comment.Feb 7 2018, 7:03 PM

There are in the log higher up when the plugin is loaded

rizzitello updated this revision to Diff 26742.Feb 8 2018, 2:30 AM
  • Add Firmware Name in the message
rizzitello marked an inline comment as done.Feb 8 2018, 2:30 AM
patrickelectric accepted this revision.Feb 8 2018, 12:23 PM
laysrodrigues accepted this revision.Feb 8 2018, 7:47 PM
rizzitello closed this revision.Feb 8 2018, 9:12 PM

Revision Contents
Changeset List

PathPackages
Msrc/atcore.cpp (4 lines)

Diff 26742

View Options

src/atcore.cpp

Loading...