Update Profiles Dialog
ClosedPublic
Actions

Authored by rizzitello on Feb 19 2018, 3:35 AM.

Details

Reviewers

laysrodrigues
patrickelectric
tcanabrava

Commits

R231:efc3a3bab76b: Update Profile Dialog
R231:bb4154a69223: Update Profiles Dialog

Summary

Add firmware selector to the dialog under advanced
Labels for maximum bed and extruder temperatures converted them to qSpinBox

Diff Detail

Repository

R231 Atelier

Branch

profileUpdate

Lint

No Linters Available

Unit

No Unit Test Coverage

rizzitello requested review of this revision.Feb 19 2018, 3:35 AM

rizzitello created this revision.

rizzitello added reviewers: laysrodrigues, patrickelectric, tcanabrava.Feb 19 2018, 3:36 AM

rizzitello added a subscriber: Atelier: AtCore.

reivew

personal review

rizzitello added inline comments.Feb 19 2018, 3:48 AM

src/mainwindow.cpp
110–111	lines 116-120 will be removed when D10645 is merged

rizzitello mentioned this in D10645: Solve T6826 +.Feb 19 2018, 3:52 AM

@rizzitello You need to adapt ConnectSettingsDialog method profileData to load the correct info of bed and extruder temps.

This revision now requires changes to proceed.Feb 19 2018, 12:13 PM

In D10648#209411, @laysrodrigues wrote:

@rizzitello You need to adapt ConnectSettingsDialog method profileData to load the correct info of bed and extruder temps.

This Is Done.

In D10645.

data["bedTemp"] = settings.value(QStringLiteral("maximumTemperatureBed"), QStringLiteral("0"));
data["hotendTemp"] = settings.value(QStringLiteral("maximumTemperatureExtruder"), QStringLiteral("0"));

update for new base

laysrodrigues accepted this revision.Feb 24 2018, 2:26 AM

This revision is now accepted and ready to land.Feb 24 2018, 2:26 AM

patrickelectric accepted this revision.Feb 24 2018, 4:02 AM

rizzitello closed this revision.Feb 24 2018, 1:15 PM

Revision Contents
Changeset List

			Path	Packages
M			src/dialogs/profilesdialog.h (3 lines)
M			src/dialogs/profilesdialog.cpp (23 lines)
M			src/dialogs/profilesdialog.ui (38 lines)
M			src/mainwindow.h (2 lines)
M			src/mainwindow.cpp (11 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	27512	68b88da		Feb 19 2018, 3:35 AM	★	★
Diff 2	27514	68b88da	- reivew	Feb 19 2018, 3:40 AM	★	★
Diff 3	27515	68b88da	- personal review	Feb 19 2018, 3:47 AM	★	★
Diff 4	27640	fbe1e20	- update for new base	Feb 20 2018, 9:11 PM	★	★